From: Ian Abbott <abbotti@mev.co.uk>
To: kernel-janitors@vger.kernel.org
Subject: Re: [patch] staging: comedi: double unlock in usbduxsigma_attach()
Date: Fri, 22 Jun 2012 08:37:14 +0000 [thread overview]
Message-ID: <4FE42EBA.9010002@mev.co.uk> (raw)
In-Reply-To: <20120622071459.GB27618@elgon.mountain>
On 2012-06-22 08:14, Dan Carpenter wrote:
> There was a double unlock introduced in 60ff461067 ("staging: comedi:
> usbduxsigma: use attach_usb() hook").
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/staging/comedi/drivers/usbduxsigma.c b/drivers/staging/comedi/drivers/usbduxsigma.c
> index 28f41e9..015b0d0 100644
> --- a/drivers/staging/comedi/drivers/usbduxsigma.c
> +++ b/drivers/staging/comedi/drivers/usbduxsigma.c
> @@ -2781,7 +2781,6 @@ static int usbduxsigma_attach(struct comedi_device *dev,
> if (index < 0) {
> dev_err(dev->class_dev,
> "usbduxsigma: error: attach failed, dev not connected to the usb bus.\n");
> - up(&start_stop_sem);
> ret = -ENODEV;
> } else
> ret = usbduxsigma_attach_common(dev, &usbduxsub[index],
Oops, I must have missed that one!
Acked-by: Ian Abbott <abbotti@mev.co.uk>
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
prev parent reply other threads:[~2012-06-22 8:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-22 7:14 [patch] staging: comedi: double unlock in usbduxsigma_attach() Dan Carpenter
2012-06-22 8:37 ` Ian Abbott [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FE42EBA.9010002@mev.co.uk \
--to=abbotti@mev.co.uk \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.