* [patch] staging: comedi: double unlock in usbduxsigma_attach()
@ 2012-06-22 7:14 Dan Carpenter
2012-06-22 8:37 ` Ian Abbott
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2012-06-22 7:14 UTC (permalink / raw)
To: kernel-janitors
There was a double unlock introduced in 60ff461067 ("staging: comedi:
usbduxsigma: use attach_usb() hook").
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/staging/comedi/drivers/usbduxsigma.c b/drivers/staging/comedi/drivers/usbduxsigma.c
index 28f41e9..015b0d0 100644
--- a/drivers/staging/comedi/drivers/usbduxsigma.c
+++ b/drivers/staging/comedi/drivers/usbduxsigma.c
@@ -2781,7 +2781,6 @@ static int usbduxsigma_attach(struct comedi_device *dev,
if (index < 0) {
dev_err(dev->class_dev,
"usbduxsigma: error: attach failed, dev not connected to the usb bus.\n");
- up(&start_stop_sem);
ret = -ENODEV;
} else
ret = usbduxsigma_attach_common(dev, &usbduxsub[index],
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [patch] staging: comedi: double unlock in usbduxsigma_attach()
2012-06-22 7:14 [patch] staging: comedi: double unlock in usbduxsigma_attach() Dan Carpenter
@ 2012-06-22 8:37 ` Ian Abbott
0 siblings, 0 replies; 2+ messages in thread
From: Ian Abbott @ 2012-06-22 8:37 UTC (permalink / raw)
To: kernel-janitors
On 2012-06-22 08:14, Dan Carpenter wrote:
> There was a double unlock introduced in 60ff461067 ("staging: comedi:
> usbduxsigma: use attach_usb() hook").
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/staging/comedi/drivers/usbduxsigma.c b/drivers/staging/comedi/drivers/usbduxsigma.c
> index 28f41e9..015b0d0 100644
> --- a/drivers/staging/comedi/drivers/usbduxsigma.c
> +++ b/drivers/staging/comedi/drivers/usbduxsigma.c
> @@ -2781,7 +2781,6 @@ static int usbduxsigma_attach(struct comedi_device *dev,
> if (index < 0) {
> dev_err(dev->class_dev,
> "usbduxsigma: error: attach failed, dev not connected to the usb bus.\n");
> - up(&start_stop_sem);
> ret = -ENODEV;
> } else
> ret = usbduxsigma_attach_common(dev, &usbduxsub[index],
Oops, I must have missed that one!
Acked-by: Ian Abbott <abbotti@mev.co.uk>
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-06-22 8:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-06-22 7:14 [patch] staging: comedi: double unlock in usbduxsigma_attach() Dan Carpenter
2012-06-22 8:37 ` Ian Abbott
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.