From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Laxman Dewangan <ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: vinod.koul-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 2/2] dma: tegra: do not set transfer desc flag to DMA_CTRL_ACK in cyclic mode
Date: Fri, 22 Jun 2012 11:10:25 -0600 [thread overview]
Message-ID: <4FE4A701.1040303@wwwdotorg.org> (raw)
In-Reply-To: <1340365364-16276-2-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
On 06/22/2012 05:42 AM, Laxman Dewangan wrote:
> The sound dmaengine pcm driver uses the dma in cyclic mode and
> it does not ack the transfer descriptor after transfer stops.
> This may lead to hold that desc in chip's dma driver and does
> not allow to reuse/free that descriptors. Hence not enabling
> flag DMA_CTRL_ACK when dma runs in cyclic mode.
> diff --git a/drivers/dma/tegra20-apb-dma.c b/drivers/dma/tegra20-apb-dma.c
> @@ -1093,7 +1093,7 @@ struct dma_async_tx_descriptor *tegra_dma_prep_dma_cyclic(
> - dma_desc->txd.flags = DMA_CTRL_ACK;
> + dma_desc->txd.flags = 0;
I honestly have no idea about this one. If the dmaengine maintainers
think it's semantically correct, I have no objections.
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Warren <swarren@wwwdotorg.org>
To: Laxman Dewangan <ldewangan@nvidia.com>
Cc: vinod.koul@intel.com, dan.j.williams@intel.com,
linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org
Subject: Re: [PATCH 2/2] dma: tegra: do not set transfer desc flag to DMA_CTRL_ACK in cyclic mode
Date: Fri, 22 Jun 2012 11:10:25 -0600 [thread overview]
Message-ID: <4FE4A701.1040303@wwwdotorg.org> (raw)
In-Reply-To: <1340365364-16276-2-git-send-email-ldewangan@nvidia.com>
On 06/22/2012 05:42 AM, Laxman Dewangan wrote:
> The sound dmaengine pcm driver uses the dma in cyclic mode and
> it does not ack the transfer descriptor after transfer stops.
> This may lead to hold that desc in chip's dma driver and does
> not allow to reuse/free that descriptors. Hence not enabling
> flag DMA_CTRL_ACK when dma runs in cyclic mode.
> diff --git a/drivers/dma/tegra20-apb-dma.c b/drivers/dma/tegra20-apb-dma.c
> @@ -1093,7 +1093,7 @@ struct dma_async_tx_descriptor *tegra_dma_prep_dma_cyclic(
> - dma_desc->txd.flags = DMA_CTRL_ACK;
> + dma_desc->txd.flags = 0;
I honestly have no idea about this one. If the dmaengine maintainers
think it's semantically correct, I have no objections.
next prev parent reply other threads:[~2012-06-22 17:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-22 11:42 [PATCH 1/2] dma: tegra: set DMA_CYCLIC capability Laxman Dewangan
2012-06-22 11:42 ` Laxman Dewangan
[not found] ` <1340365364-16276-1-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-06-22 11:42 ` [PATCH 2/2] dma: tegra: do not set transfer desc flag to DMA_CTRL_ACK in cyclic mode Laxman Dewangan
2012-06-22 11:42 ` Laxman Dewangan
[not found] ` <1340365364-16276-2-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-06-22 17:10 ` Stephen Warren [this message]
2012-06-22 17:10 ` Stephen Warren
2012-06-22 17:09 ` [PATCH 1/2] dma: tegra: set DMA_CYCLIC capability Stephen Warren
2012-06-22 17:09 ` Stephen Warren
2012-06-27 13:29 ` Vinod Koul
2012-06-27 13:29 ` Vinod Koul
2012-06-27 13:42 ` Laxman Dewangan
[not found] ` <4FEB0DB6.7040105-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-06-27 13:49 ` Vinod Koul
2012-06-27 13:49 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FE4A701.1040303@wwwdotorg.org \
--to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
--cc=dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=vinod.koul-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.