* [Ocfs2-devel] fix mlog_errno in ocfs2_global_read_info @ 2012-06-25 8:00 Tiger Yang 2012-06-25 8:03 ` [Ocfs2-devel] [PATCH 1/1] ocfs2: remove redundant and incorrect mlog_error Tiger Yang 2012-06-25 8:04 ` [Ocfs2-devel] fix mlog_errno in ocfs2_global_read_info Marek Królikowski 0 siblings, 2 replies; 6+ messages in thread From: Tiger Yang @ 2012-06-25 8:00 UTC (permalink / raw) To: ocfs2-devel Hi, All, When mount ocfs2 with option usrquota and grpquota, we will see below message: (mount.ocfs2,9434,1):ocfs2_global_read_info:403 ERROR: status = 24 (mount.ocfs2,9434,3):ocfs2_global_read_info:403 ERROR: status = 24 But actually this should not be a error. In ocfs2_global_read_info, if read_quota() succeed, status is the size of the struct ocfs2_global_disk_dqinfo, only when it is not equal to the correct size, it will be a error. So this positive value should be return and should not log it as a error. I made a patch to fix this, and in the patch I removed the redundant mlog_errno also. Thanks for review Tiger ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Ocfs2-devel] [PATCH 1/1] ocfs2: remove redundant and incorrect mlog_error 2012-06-25 8:00 [Ocfs2-devel] fix mlog_errno in ocfs2_global_read_info Tiger Yang @ 2012-06-25 8:03 ` Tiger Yang 2012-07-04 6:26 ` Joel Becker 2012-06-25 8:04 ` [Ocfs2-devel] fix mlog_errno in ocfs2_global_read_info Marek Królikowski 1 sibling, 1 reply; 6+ messages in thread From: Tiger Yang @ 2012-06-25 8:03 UTC (permalink / raw) To: ocfs2-devel out_err already logged all the negative status, so remove mlog_errno before goto there. If quota_read succeed, positive (non zero) status should be return and it's not a error. Signed-off-by: Tiger Yang <tiger.yang@oracle.com> --- fs/ocfs2/quota_global.c | 11 +++-------- 1 files changed, 3 insertions(+), 8 deletions(-) diff --git a/fs/ocfs2/quota_global.c b/fs/ocfs2/quota_global.c index 92fcd57..cb0f017 100644 --- a/fs/ocfs2/quota_global.c +++ b/fs/ocfs2/quota_global.c @@ -358,10 +358,8 @@ int ocfs2_global_read_info(struct super_block *sb, int type) oinfo->dqi_gqi_count = 0; oinfo->dqi_gqinode = gqinode; status = ocfs2_lock_global_qf(oinfo, 0); - if (status < 0) { - mlog_errno(status); + if (status < 0) goto out_err; - } status = ocfs2_extent_map_get_blocks(gqinode, 0, &oinfo->dqi_giblk, &pcount, NULL); @@ -381,7 +379,6 @@ int ocfs2_global_read_info(struct super_block *sb, int type) status); if (status >= 0) status = -EIO; - mlog_errno(status); goto out_err; } info->dqi_bgrace = le32_to_cpu(dinfo.dqi_bgrace); @@ -398,14 +395,12 @@ int ocfs2_global_read_info(struct super_block *sb, int type) schedule_delayed_work(&oinfo->dqi_sync_work, msecs_to_jiffies(oinfo->dqi_syncms)); -out_err: - if (status) - mlog_errno(status); return status; out_unlock: ocfs2_unlock_global_qf(oinfo, 0); +out_err: mlog_errno(status); - goto out_err; + return status; } /* Write information to global quota file. Expects exlusive lock on quota -- 1.7.4.4 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Ocfs2-devel] [PATCH 1/1] ocfs2: remove redundant and incorrect mlog_error 2012-06-25 8:03 ` [Ocfs2-devel] [PATCH 1/1] ocfs2: remove redundant and incorrect mlog_error Tiger Yang @ 2012-07-04 6:26 ` Joel Becker 0 siblings, 0 replies; 6+ messages in thread From: Joel Becker @ 2012-07-04 6:26 UTC (permalink / raw) To: ocfs2-devel I have Jan's patch, which keeps mlog_errno near the errors. this is good for locating the problem. Joel On Mon, Jun 25, 2012 at 04:03:24PM +0800, Tiger Yang wrote: > out_err already logged all the negative status, so remove mlog_errno > before goto there. If quota_read succeed, positive (non zero) > status should be return and it's not a error. > > Signed-off-by: Tiger Yang <tiger.yang@oracle.com> > --- > fs/ocfs2/quota_global.c | 11 +++-------- > 1 files changed, 3 insertions(+), 8 deletions(-) > > diff --git a/fs/ocfs2/quota_global.c b/fs/ocfs2/quota_global.c > index 92fcd57..cb0f017 100644 > --- a/fs/ocfs2/quota_global.c > +++ b/fs/ocfs2/quota_global.c > @@ -358,10 +358,8 @@ int ocfs2_global_read_info(struct super_block *sb, int type) > oinfo->dqi_gqi_count = 0; > oinfo->dqi_gqinode = gqinode; > status = ocfs2_lock_global_qf(oinfo, 0); > - if (status < 0) { > - mlog_errno(status); > + if (status < 0) > goto out_err; > - } > > status = ocfs2_extent_map_get_blocks(gqinode, 0, &oinfo->dqi_giblk, > &pcount, NULL); > @@ -381,7 +379,6 @@ int ocfs2_global_read_info(struct super_block *sb, int type) > status); > if (status >= 0) > status = -EIO; > - mlog_errno(status); > goto out_err; > } > info->dqi_bgrace = le32_to_cpu(dinfo.dqi_bgrace); > @@ -398,14 +395,12 @@ int ocfs2_global_read_info(struct super_block *sb, int type) > schedule_delayed_work(&oinfo->dqi_sync_work, > msecs_to_jiffies(oinfo->dqi_syncms)); > > -out_err: > - if (status) > - mlog_errno(status); > return status; > out_unlock: > ocfs2_unlock_global_qf(oinfo, 0); > +out_err: > mlog_errno(status); > - goto out_err; > + return status; > } > > /* Write information to global quota file. Expects exlusive lock on quota > -- > 1.7.4.4 > -- Life's Little Instruction Book #451 "Don't be afraid to say, 'I'm sorry.'" http://www.jlbec.org/ jlbec at evilplan.org ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Ocfs2-devel] fix mlog_errno in ocfs2_global_read_info 2012-06-25 8:00 [Ocfs2-devel] fix mlog_errno in ocfs2_global_read_info Tiger Yang 2012-06-25 8:03 ` [Ocfs2-devel] [PATCH 1/1] ocfs2: remove redundant and incorrect mlog_error Tiger Yang @ 2012-06-25 8:04 ` Marek Królikowski 2012-06-25 8:16 ` Tiger Yang 1 sibling, 1 reply; 6+ messages in thread From: Marek Królikowski @ 2012-06-25 8:04 UTC (permalink / raw) To: ocfs2-devel Don`t use usrquota and grpquota - this is amazing unstable i wait for patch 7 month and still in progress.... And FYI this is not only this error look i got many many in dmesg when someone get email and he is over quota there is error in dmesg like this: (local,29785,2):ocfs2_write_begin:1953 ERROR: status = -122 (courier-imapd,26241,1):ocfs2_write_begin:1953 ERROR: status = -122 And many many other errors with status -122... if possible disable quota or You get kernel panic when u write/read/move file with FS quota support on ocfs2 cluster. Thanks -----Oryginalna wiadomo??----- From: Tiger Yang Sent: Monday, June 25, 2012 10:00 AM To: ocfs2-devel at oss.oracle.com Cc: Mark Fasheh Subject: [Ocfs2-devel] fix mlog_errno in ocfs2_global_read_info Hi, All, When mount ocfs2 with option usrquota and grpquota, we will see below message: (mount.ocfs2,9434,1):ocfs2_global_read_info:403 ERROR: status = 24 (mount.ocfs2,9434,3):ocfs2_global_read_info:403 ERROR: status = 24 But actually this should not be a error. In ocfs2_global_read_info, if read_quota() succeed, status is the size of the struct ocfs2_global_disk_dqinfo, only when it is not equal to the correct size, it will be a error. So this positive value should be return and should not log it as a error. I made a patch to fix this, and in the patch I removed the redundant mlog_errno also. Thanks for review Tiger _______________________________________________ Ocfs2-devel mailing list Ocfs2-devel at oss.oracle.com http://oss.oracle.com/mailman/listinfo/ocfs2-devel ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Ocfs2-devel] fix mlog_errno in ocfs2_global_read_info 2012-06-25 8:04 ` [Ocfs2-devel] fix mlog_errno in ocfs2_global_read_info Marek Królikowski @ 2012-06-25 8:16 ` Tiger Yang 2012-06-25 8:19 ` Marek Królikowski 0 siblings, 1 reply; 6+ messages in thread From: Tiger Yang @ 2012-06-25 8:16 UTC (permalink / raw) To: ocfs2-devel Hi, Marek, I know you are suffered with quota bug, but I am trying to fix this issue soon. Thanks, Tiger On 06/25/2012 04:04 PM, Marek Kr?likowski wrote: > Don`t use usrquota and grpquota - this is amazing unstable i wait for > patch 7 month and still in progress.... > And FYI this is not only this error look i got many many in dmesg when > someone get email and he is over quota there is error in dmesg like this: > (local,29785,2):ocfs2_write_begin:1953 ERROR: status = -122 > (courier-imapd,26241,1):ocfs2_write_begin:1953 ERROR: status = -122 > > And many many other errors with status -122... if possible disable > quota or You get kernel panic when u write/read/move file with FS > quota support on ocfs2 cluster. > Thanks > > > -----Oryginalna wiadomo??----- From: Tiger Yang > Sent: Monday, June 25, 2012 10:00 AM > To: ocfs2-devel at oss.oracle.com > Cc: Mark Fasheh > Subject: [Ocfs2-devel] fix mlog_errno in ocfs2_global_read_info > > Hi, All, > > When mount ocfs2 with option usrquota and grpquota, we will see below > message: > > (mount.ocfs2,9434,1):ocfs2_global_read_info:403 ERROR: status = 24 > (mount.ocfs2,9434,3):ocfs2_global_read_info:403 ERROR: status = 24 > > But actually this should not be a error. > > In ocfs2_global_read_info, if read_quota() succeed, status is the size > of the struct ocfs2_global_disk_dqinfo, only when it is not equal to the > correct size, it will be a error. So this positive value should be > return and should not log it as a error. > > I made a patch to fix this, and in the patch I removed the redundant > mlog_errno also. > > Thanks for review > > Tiger > > _______________________________________________ > Ocfs2-devel mailing list > Ocfs2-devel at oss.oracle.com > http://oss.oracle.com/mailman/listinfo/ocfs2-devel ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Ocfs2-devel] fix mlog_errno in ocfs2_global_read_info 2012-06-25 8:16 ` Tiger Yang @ 2012-06-25 8:19 ` Marek Królikowski 0 siblings, 0 replies; 6+ messages in thread From: Marek Królikowski @ 2012-06-25 8:19 UTC (permalink / raw) To: ocfs2-devel Hello Tiger Thank You for taking the topic - good to hear someone want repair this. If You got any question or need any help please send email to me. Thanks, Marek -----Oryginalna wiadomo??----- From: Tiger Yang Sent: Monday, June 25, 2012 10:16 AM To: Marek Kr?likowski Cc: ocfs2-devel at oss.oracle.com ; Mark Fasheh Subject: Re: [Ocfs2-devel] fix mlog_errno in ocfs2_global_read_info Hi, Marek, I know you are suffered with quota bug, but I am trying to fix this issue soon. Thanks, Tiger On 06/25/2012 04:04 PM, Marek Kr?likowski wrote: > Don`t use usrquota and grpquota - this is amazing unstable i wait for > patch 7 month and still in progress.... > And FYI this is not only this error look i got many many in dmesg when > someone get email and he is over quota there is error in dmesg like this: > (local,29785,2):ocfs2_write_begin:1953 ERROR: status = -122 > (courier-imapd,26241,1):ocfs2_write_begin:1953 ERROR: status = -122 > > And many many other errors with status -122... if possible disable quota > or You get kernel panic when u write/read/move file with FS quota support > on ocfs2 cluster. > Thanks > > > -----Oryginalna wiadomo??----- From: Tiger Yang > Sent: Monday, June 25, 2012 10:00 AM > To: ocfs2-devel at oss.oracle.com > Cc: Mark Fasheh > Subject: [Ocfs2-devel] fix mlog_errno in ocfs2_global_read_info > > Hi, All, > > When mount ocfs2 with option usrquota and grpquota, we will see below > message: > > (mount.ocfs2,9434,1):ocfs2_global_read_info:403 ERROR: status = 24 > (mount.ocfs2,9434,3):ocfs2_global_read_info:403 ERROR: status = 24 > > But actually this should not be a error. > > In ocfs2_global_read_info, if read_quota() succeed, status is the size > of the struct ocfs2_global_disk_dqinfo, only when it is not equal to the > correct size, it will be a error. So this positive value should be > return and should not log it as a error. > > I made a patch to fix this, and in the patch I removed the redundant > mlog_errno also. > > Thanks for review > > Tiger > > _______________________________________________ > Ocfs2-devel mailing list > Ocfs2-devel at oss.oracle.com > http://oss.oracle.com/mailman/listinfo/ocfs2-devel ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-07-04 6:26 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2012-06-25 8:00 [Ocfs2-devel] fix mlog_errno in ocfs2_global_read_info Tiger Yang 2012-06-25 8:03 ` [Ocfs2-devel] [PATCH 1/1] ocfs2: remove redundant and incorrect mlog_error Tiger Yang 2012-07-04 6:26 ` Joel Becker 2012-06-25 8:04 ` [Ocfs2-devel] fix mlog_errno in ocfs2_global_read_info Marek Królikowski 2012-06-25 8:16 ` Tiger Yang 2012-06-25 8:19 ` Marek Królikowski
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.