From: Roland Stigge <stigge@antcom.de>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: axel.lin@gmail.com, riyer@nvidia.com,
michael.hennerich@analog.com, grant.likely@secretlab.ca,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, kevin.wells@nxp.com,
srinivas.bakki@nxp.com, devicetree-discuss@lists.ozlabs.org,
rob.herring@calxeda.com, aletes.xgr@gmail.com
Subject: Re: [PATCH v6] input: keyboard: Add keys driver for the LPC32xx SoC
Date: Mon, 25 Jun 2012 11:32:13 +0200 [thread overview]
Message-ID: <4FE8301D.9050108@antcom.de> (raw)
In-Reply-To: <20120625070614.GA13876@core.coreip.homeip.net>
Hi Dmitry!
On 06/25/2012 09:06 AM, Dmitry Torokhov wrote:
> On Sun, Jun 24, 2012 at 04:44:38PM +0200, Roland Stigge wrote:
>> This patch adds a driver for the key scan interface of the LPC32xx SoC
>>
>> Signed-off-by: Roland Stigge <stigge@antcom.de>
>>
>
> This looks _very_ good, I just have a couple more comments:
Thanks for reviewing!
I think I'm addressing all of those points in my v7 patch.
Roland
WARNING: multiple messages have this Message-ID (diff)
From: stigge@antcom.de (Roland Stigge)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6] input: keyboard: Add keys driver for the LPC32xx SoC
Date: Mon, 25 Jun 2012 11:32:13 +0200 [thread overview]
Message-ID: <4FE8301D.9050108@antcom.de> (raw)
In-Reply-To: <20120625070614.GA13876@core.coreip.homeip.net>
Hi Dmitry!
On 06/25/2012 09:06 AM, Dmitry Torokhov wrote:
> On Sun, Jun 24, 2012 at 04:44:38PM +0200, Roland Stigge wrote:
>> This patch adds a driver for the key scan interface of the LPC32xx SoC
>>
>> Signed-off-by: Roland Stigge <stigge@antcom.de>
>>
>
> This looks _very_ good, I just have a couple more comments:
Thanks for reviewing!
I think I'm addressing all of those points in my v7 patch.
Roland
next prev parent reply other threads:[~2012-06-25 9:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-24 14:44 [PATCH v6] input: keyboard: Add keys driver for the LPC32xx SoC Roland Stigge
2012-06-24 14:44 ` Roland Stigge
2012-06-25 7:06 ` Dmitry Torokhov
2012-06-25 7:06 ` Dmitry Torokhov
2012-06-25 9:32 ` Roland Stigge [this message]
2012-06-25 9:32 ` Roland Stigge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FE8301D.9050108@antcom.de \
--to=stigge@antcom.de \
--cc=aletes.xgr@gmail.com \
--cc=axel.lin@gmail.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=dmitry.torokhov@gmail.com \
--cc=grant.likely@secretlab.ca \
--cc=kevin.wells@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.hennerich@analog.com \
--cc=riyer@nvidia.com \
--cc=rob.herring@calxeda.com \
--cc=srinivas.bakki@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.