From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: Ezequiel Garcia <elezegarcia@gmail.com>
Cc: linux-media@vger.kernel.org
Subject: Re: [PATCH 01/12] saa7164: Use i2c_rc properly to store i2c register status
Date: Mon, 25 Jun 2012 16:29:49 -0300 [thread overview]
Message-ID: <4FE8BC2D.9030902@redhat.com> (raw)
In-Reply-To: <1340047425-32000-1-git-send-email-elezegarcia@gmail.com>
Em 18-06-2012 16:23, Ezequiel Garcia escreveu:
> Signed-off-by: Ezequiel Garcia <elezegarcia@gmail.com>
> ---
> drivers/media/video/saa7164/saa7164-i2c.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/media/video/saa7164/saa7164-i2c.c b/drivers/media/video/saa7164/saa7164-i2c.c
> index 26148f7..536f7dc 100644
> --- a/drivers/media/video/saa7164/saa7164-i2c.c
> +++ b/drivers/media/video/saa7164/saa7164-i2c.c
> @@ -123,7 +123,7 @@ int saa7164_i2c_register(struct saa7164_i2c *bus)
> bus->i2c_algo.data = bus;
> bus->i2c_adap.algo_data = bus;
> i2c_set_adapdata(&bus->i2c_adap, bus);
> - i2c_add_adapter(&bus->i2c_adap);
> + bus->i2c_rc = i2c_add_adapter(&bus->i2c_adap);
>
> bus->i2c_client.adapter = &bus->i2c_adap;
>
>
-ENODESCRIPTION.
What are you intending with this change? AFAICT, i2c_add_bus_adapter()
returns 0 on success and a negative value otherwise. Why should it be
stored at bus->i2c_rc?
The same applies to the entire patch series.
Regards,
Mauro
next prev parent reply other threads:[~2012-06-25 19:29 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-18 19:23 [PATCH 01/12] saa7164: Use i2c_rc properly to store i2c register status Ezequiel Garcia
2012-06-18 19:23 ` [PATCH 02/12] saa7164: Remove useless struct i2c_algo_bit_data Ezequiel Garcia
2012-06-18 19:23 ` [PATCH 03/12] saa7164: Replace struct memcpy with struct assignment Ezequiel Garcia
2012-06-18 19:23 ` [PATCH 04/12] cx23885: Use i2c_rc properly to store i2c register status Ezequiel Garcia
2012-06-18 19:23 ` [PATCH 05/12] cx23885: Remove useless struct i2c_algo_bit_data Ezequiel Garcia
2012-06-18 19:23 ` [PATCH 06/12] cx23885: Replace struct memcpy with struct assignment Ezequiel Garcia
2012-06-18 19:23 ` [PATCH 07/12] cx231xx: Use i2c_rc properly to store i2c register status Ezequiel Garcia
2012-06-18 19:23 ` [PATCH 08/12] cx231xx: Remove useless struct i2c_algo_bit_data usage Ezequiel Garcia
2012-06-18 19:23 ` [PATCH 09/12] cx231xx: Replace struct memcpy with struct assignment Ezequiel Garcia
2012-06-18 19:23 ` [PATCH 10/12] cx25821: Use i2c_rc properly to store i2c register status Ezequiel Garcia
2012-06-18 19:23 ` [PATCH 11/12] cx25821: Remove useless struct i2c_algo_bit_data usage Ezequiel Garcia
2012-06-18 19:23 ` [PATCH 12/12] cx25821: Replace struct memcpy with struct assignment Ezequiel Garcia
2012-06-25 19:29 ` Mauro Carvalho Chehab [this message]
2012-06-25 19:42 ` [PATCH 01/12] saa7164: Use i2c_rc properly to store i2c register status Ezequiel Garcia
2012-06-25 19:49 ` Mauro Carvalho Chehab
2012-06-25 20:06 ` Ezequiel Garcia
2012-06-25 20:53 ` Mauro Carvalho Chehab
2012-06-26 16:40 ` Ezequiel Garcia
2012-06-26 18:23 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FE8BC2D.9030902@redhat.com \
--to=mchehab@redhat.com \
--cc=elezegarcia@gmail.com \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.