From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: Ezequiel Garcia <elezegarcia@gmail.com>
Cc: linux-media@vger.kernel.org
Subject: Re: [PATCH 01/12] saa7164: Use i2c_rc properly to store i2c register status
Date: Mon, 25 Jun 2012 17:53:00 -0300 [thread overview]
Message-ID: <4FE8CFAC.20302@redhat.com> (raw)
In-Reply-To: <CALF0-+V_NCb2TMdd9SS-jrPKS8ocWRNAvwo1-ptPCW2GtNZEkw@mail.gmail.com>
Em 25-06-2012 17:06, Ezequiel Garcia escreveu:
> On Mon, Jun 25, 2012 at 4:49 PM, Mauro Carvalho Chehab
> <mchehab@redhat.com> wrote:
>>
>> If i2c_rc was never initialized, then just remove it. If it is required,
>> then there's a bug somewhere out there on those drivers.
>>
>> IMHO, if the I2C bus doesn't register, any driver that requires I2C bus
>> should return -ENODEV.
>
> Agreed.
>
>>
>> It should be noticed that there are a few devices that don't need I2C bus
>> to work: simple video grabber cards that don't have anything on their I2C.
>> There are several of them at bttv, and a few at cx88 and saa7134. Maybe that's
>> the reason why those drivers have a var to indicate if i2c got registered.
>
> Mmm, that would explain mysterious i2c_rc.
>
> Anyway, I'm still a *q-bit* unsure about which drivers require i2c to
> work and which don't.
> I'm gonna investigate this carefully and send a v2 (probably just to
> send a v3 later :)
Yeah, research is needed ;) As "bttv" is the mother of the I2C code found at
other PCI drivers, as it is one of the oldest implementations, I bet you'll
find this field propagated without usage on some drivers (and probably other
unused fields as well ;) )
>
> Thanks for reviewing,
> Ezequiel.
>
Regards,
Mauro
next prev parent reply other threads:[~2012-06-25 20:53 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-18 19:23 [PATCH 01/12] saa7164: Use i2c_rc properly to store i2c register status Ezequiel Garcia
2012-06-18 19:23 ` [PATCH 02/12] saa7164: Remove useless struct i2c_algo_bit_data Ezequiel Garcia
2012-06-18 19:23 ` [PATCH 03/12] saa7164: Replace struct memcpy with struct assignment Ezequiel Garcia
2012-06-18 19:23 ` [PATCH 04/12] cx23885: Use i2c_rc properly to store i2c register status Ezequiel Garcia
2012-06-18 19:23 ` [PATCH 05/12] cx23885: Remove useless struct i2c_algo_bit_data Ezequiel Garcia
2012-06-18 19:23 ` [PATCH 06/12] cx23885: Replace struct memcpy with struct assignment Ezequiel Garcia
2012-06-18 19:23 ` [PATCH 07/12] cx231xx: Use i2c_rc properly to store i2c register status Ezequiel Garcia
2012-06-18 19:23 ` [PATCH 08/12] cx231xx: Remove useless struct i2c_algo_bit_data usage Ezequiel Garcia
2012-06-18 19:23 ` [PATCH 09/12] cx231xx: Replace struct memcpy with struct assignment Ezequiel Garcia
2012-06-18 19:23 ` [PATCH 10/12] cx25821: Use i2c_rc properly to store i2c register status Ezequiel Garcia
2012-06-18 19:23 ` [PATCH 11/12] cx25821: Remove useless struct i2c_algo_bit_data usage Ezequiel Garcia
2012-06-18 19:23 ` [PATCH 12/12] cx25821: Replace struct memcpy with struct assignment Ezequiel Garcia
2012-06-25 19:29 ` [PATCH 01/12] saa7164: Use i2c_rc properly to store i2c register status Mauro Carvalho Chehab
2012-06-25 19:42 ` Ezequiel Garcia
2012-06-25 19:49 ` Mauro Carvalho Chehab
2012-06-25 20:06 ` Ezequiel Garcia
2012-06-25 20:53 ` Mauro Carvalho Chehab [this message]
2012-06-26 16:40 ` Ezequiel Garcia
2012-06-26 18:23 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FE8CFAC.20302@redhat.com \
--to=mchehab@redhat.com \
--cc=elezegarcia@gmail.com \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.