From: Kamezawa Hiroyuki <kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
To: Michal Hocko <mhocko-AlSwsSmVLrQ@public.gmane.org>
Cc: Wanpeng Li <liwp.linux-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>,
Balbir Singh
<bsingharora-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Andrew Morton
<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
Eric Dumazet
<eric.dumazet-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Mike Frysinger <vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org>,
Arun Sharma <asharma-b10kYP2dOMg@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v3 3/4] memcg: optimize memcg_get_hierarchical_limit
Date: Tue, 26 Jun 2012 11:45:44 +0900 [thread overview]
Message-ID: <4FE92258.4040900@jp.fujitsu.com> (raw)
In-Reply-To: <20120625110926.GJ19805-VqjxzfR4DlwKmadIfiO5sKVXKuFTiq87@public.gmane.org>
(2012/06/25 20:09), Michal Hocko wrote:
> On Mon 25-06-12 18:43:57, Wanpeng Li wrote:
>> On Mon, Jun 25, 2012 at 06:52:25PM +0900, Kamezawa Hiroyuki wrote:
>>> (2012/06/25 17:44), Wanpeng Li wrote:
>>>> From: Wanpeng Li <liwp-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
>>>>
>>>> Optimize memcg_get_hierarchical_limit to save cpu cycle.
>>>>
>>>> Signed-off-by: Wanpeng Li <liwp.linux-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>>>
>>> I can't understand the benefit of this patch to the real world...
>>>
>>> So, if you wrote the patch description as "clean up" rather than optimize,
>>> ok, I'll agree.
>> OK, I will change to "Cleanup". Thank you Kame.
>
> Does this really clean something up?
>
I just thought unused variable is trash even if it disappears after complie.
Thanks,
-Kame
WARNING: multiple messages have this Message-ID (diff)
From: Kamezawa Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
To: Michal Hocko <mhocko@suse.cz>
Cc: Wanpeng Li <liwp.linux@gmail.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Balbir Singh <bsingharora@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Eric Dumazet <eric.dumazet@gmail.com>,
Mike Frysinger <vapier@gentoo.org>, Arun Sharma <asharma@fb.com>,
linux-kernel@vger.kernel.org, cgroups@vger.kernel.org
Subject: Re: [PATCH v3 3/4] memcg: optimize memcg_get_hierarchical_limit
Date: Tue, 26 Jun 2012 11:45:44 +0900 [thread overview]
Message-ID: <4FE92258.4040900@jp.fujitsu.com> (raw)
In-Reply-To: <20120625110926.GJ19805@tiehlicka.suse.cz>
(2012/06/25 20:09), Michal Hocko wrote:
> On Mon 25-06-12 18:43:57, Wanpeng Li wrote:
>> On Mon, Jun 25, 2012 at 06:52:25PM +0900, Kamezawa Hiroyuki wrote:
>>> (2012/06/25 17:44), Wanpeng Li wrote:
>>>> From: Wanpeng Li <liwp@linux.vnet.ibm.com>
>>>>
>>>> Optimize memcg_get_hierarchical_limit to save cpu cycle.
>>>>
>>>> Signed-off-by: Wanpeng Li <liwp.linux@gmail.com>
>>>
>>> I can't understand the benefit of this patch to the real world...
>>>
>>> So, if you wrote the patch description as "clean up" rather than optimize,
>>> ok, I'll agree.
>> OK, I will change to "Cleanup". Thank you Kame.
>
> Does this really clean something up?
>
I just thought unused variable is trash even if it disappears after complie.
Thanks,
-Kame
next prev parent reply other threads:[~2012-06-26 2:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-25 8:44 [PATCH v3 3/4] memcg: optimize memcg_get_hierarchical_limit Wanpeng Li
2012-06-25 8:44 ` Wanpeng Li
[not found] ` <1340613872-9581-1-git-send-email-liwp.linux-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-06-25 9:46 ` Michal Hocko
2012-06-25 9:46 ` Michal Hocko
2012-06-25 9:52 ` Kamezawa Hiroyuki
2012-06-25 9:52 ` Kamezawa Hiroyuki
[not found] ` <4FE834D9.8070903-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2012-06-25 10:43 ` Wanpeng Li
2012-06-25 10:43 ` Wanpeng Li
2012-06-25 11:09 ` Michal Hocko
2012-06-25 11:09 ` Michal Hocko
[not found] ` <20120625110926.GJ19805-VqjxzfR4DlwKmadIfiO5sKVXKuFTiq87@public.gmane.org>
2012-06-25 11:19 ` Wanpeng Li
2012-06-25 11:19 ` Wanpeng Li
2012-06-26 2:45 ` Kamezawa Hiroyuki [this message]
2012-06-26 2:45 ` Kamezawa Hiroyuki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FE92258.4040900@jp.fujitsu.com \
--to=kamezawa.hiroyu-+cum20s59erqfuhtdcdx3a@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=asharma-b10kYP2dOMg@public.gmane.org \
--cc=bsingharora-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=eric.dumazet-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=liwp.linux-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=mhocko-AlSwsSmVLrQ@public.gmane.org \
--cc=vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.