From: Shubhrajyoti <shubhrajyoti@ti.com>
To: Felipe Balbi <balbi@ti.com>
Cc: ben-linux@fluff.org, Tony Lindgren <tony@atomide.com>,
Santosh Shilimkar <santosh.shilimkar@ti.com>,
Russell King <linux@arm.linux.org.uk>,
Linux OMAP Mailing List <linux-omap@vger.kernel.org>,
Linux ARM Kernel Mailing List
<linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
w.sang@pengutronix.de
Subject: Re: [PATCH v2 05/17] i2c: omap: split out [XR]DR and [XR]RDY
Date: Tue, 26 Jun 2012 16:11:30 +0530 [thread overview]
Message-ID: <4FE991DA.5070301@ti.com> (raw)
In-Reply-To: <1339691067-919-6-git-send-email-balbi@ti.com>
Hi Felipe,
On Thursday 14 June 2012 09:54 PM, Felipe Balbi wrote:
> return IRQ_HANDLED;
> }
>
> - if (stat & (OMAP_I2C_STAT_RRDY | OMAP_I2C_STAT_RDR)) {
> + if (stat & OMAP_I2C_STAT_RDR) {
> u8 num_bytes = 1;
>
> + if (dev->fifo_size)
> + num_bytes = dev->fifo_size;
In case of a draining interrupt. The byte count may not be the fifo size.
Do you agree?
> +
> + while (num_bytes--) {
> + if (!dev->buf_len) {
WARNING: multiple messages have this Message-ID (diff)
From: shubhrajyoti@ti.com (Shubhrajyoti)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 05/17] i2c: omap: split out [XR]DR and [XR]RDY
Date: Tue, 26 Jun 2012 16:11:30 +0530 [thread overview]
Message-ID: <4FE991DA.5070301@ti.com> (raw)
In-Reply-To: <1339691067-919-6-git-send-email-balbi@ti.com>
Hi Felipe,
On Thursday 14 June 2012 09:54 PM, Felipe Balbi wrote:
> return IRQ_HANDLED;
> }
>
> - if (stat & (OMAP_I2C_STAT_RRDY | OMAP_I2C_STAT_RDR)) {
> + if (stat & OMAP_I2C_STAT_RDR) {
> u8 num_bytes = 1;
>
> + if (dev->fifo_size)
> + num_bytes = dev->fifo_size;
In case of a draining interrupt. The byte count may not be the fifo size.
Do you agree?
> +
> + while (num_bytes--) {
> + if (!dev->buf_len) {
next prev parent reply other threads:[~2012-06-26 10:41 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-14 16:24 [PATCH v2 00/17] Big OMAP I2C Cleanup Felipe Balbi
2012-06-14 16:24 ` Felipe Balbi
2012-06-14 16:24 ` [PATCH v2 01/17] i2c: omap: simplify num_bytes handling Felipe Balbi
2012-06-14 16:24 ` Felipe Balbi
2012-06-14 16:24 ` Felipe Balbi
2012-06-14 16:24 ` [PATCH v2 02/17] i2c: omap: decrease indentation level on data handling Felipe Balbi
2012-06-14 16:24 ` Felipe Balbi
2012-06-14 16:24 ` Felipe Balbi
2012-06-14 16:24 ` [PATCH v2 03/17] i2c: omap: add blank lines Felipe Balbi
2012-06-14 16:24 ` Felipe Balbi
2012-06-14 16:24 ` [PATCH v2 04/17] i2c: omap: simplify omap_i2c_ack_stat() Felipe Balbi
2012-06-14 16:24 ` Felipe Balbi
2012-06-14 16:24 ` [PATCH v2 05/17] i2c: omap: split out [XR]DR and [XR]RDY Felipe Balbi
2012-06-14 16:24 ` Felipe Balbi
2012-06-26 10:41 ` Shubhrajyoti [this message]
2012-06-26 10:41 ` Shubhrajyoti
2012-07-02 11:33 ` Felipe Balbi
2012-07-02 11:33 ` Felipe Balbi
2012-07-02 11:51 ` Shubhrajyoti
2012-07-02 11:51 ` Shubhrajyoti
2012-06-14 16:24 ` [PATCH v2 06/17] i2c: omap: improve 1p153 errata handling Felipe Balbi
2012-06-14 16:24 ` Felipe Balbi
2012-06-14 16:24 ` [PATCH v2 07/17] i2c: omap: re-factor receive/transmit data loop Felipe Balbi
2012-06-14 16:24 ` Felipe Balbi
2012-06-14 16:24 ` [PATCH v2 08/17] i2c: omap: switch over to do {} while loop Felipe Balbi
2012-06-14 16:24 ` Felipe Balbi
2012-06-14 16:24 ` [PATCH v2 09/17] i2c: omap: ack IRQ in parts Felipe Balbi
2012-06-14 16:24 ` Felipe Balbi
2012-06-14 16:24 ` Felipe Balbi
2012-06-14 16:24 ` [PATCH v2 10/17] i2c: omap: get rid of the "complete" label Felipe Balbi
2012-06-14 16:24 ` Felipe Balbi
2012-06-14 16:24 ` [PATCH v2 11/17] i2c: omap: switch to devm_* API Felipe Balbi
2012-06-14 16:24 ` Felipe Balbi
2012-06-14 16:24 ` [PATCH v2 12/17] i2c: omap: switch to platform_get_irq() Felipe Balbi
2012-06-14 16:24 ` Felipe Balbi
2012-06-14 16:24 ` [PATCH v2 13/17] i2c: omap: bus: add a receiver flag Felipe Balbi
2012-06-14 16:24 ` Felipe Balbi
2012-06-14 16:24 ` [PATCH v2 14/17] i2c: omap: simplify errata check Felipe Balbi
2012-06-14 16:24 ` Felipe Balbi
2012-06-14 16:24 ` [PATCH v2 15/17] i2c: omap: always return IRQ_HANDLED Felipe Balbi
2012-06-14 16:24 ` Felipe Balbi
2012-06-14 16:24 ` [PATCH v2 16/17] i2c: omap: simplify IRQ exit path Felipe Balbi
2012-06-14 16:24 ` Felipe Balbi
2012-06-14 16:24 ` [PATCH v2 17/17] i2c: omap: resize fifos before each message Felipe Balbi
2012-06-14 16:24 ` Felipe Balbi
2012-06-14 17:59 ` [PATCH v2 00/17] Big OMAP I2C Cleanup Wolfram Sang
2012-06-14 17:59 ` Wolfram Sang
2012-06-26 10:51 ` Shubhrajyoti
2012-06-26 10:51 ` Shubhrajyoti
2012-07-02 11:37 ` Felipe Balbi
2012-07-02 11:37 ` Felipe Balbi
2012-07-02 11:53 ` Shubhrajyoti
2012-07-02 11:53 ` Shubhrajyoti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FE991DA.5070301@ti.com \
--to=shubhrajyoti@ti.com \
--cc=balbi@ti.com \
--cc=ben-linux@fluff.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=santosh.shilimkar@ti.com \
--cc=tony@atomide.com \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.