All of lore.kernel.org
 help / color / mirror / Atom feed
From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clk: mxs: fix ref_io clock definition
Date: Wed, 27 Jun 2012 09:46:21 +0200	[thread overview]
Message-ID: <4FEABA4D.7000004@free-electrons.com> (raw)
In-Reply-To: <1340331709-15188-1-git-send-email-shawn.guo@linaro.org>

Hi,

Le 22/06/2012 04:21, Shawn Guo a ?crit :
> The definition of clocks ref_io0 and ref_io1 were inverted.  It causes
> a mmc regression on some boards right away.  Fix the regression by
> correcting the ref_io clock definition.
> 
> Reported-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>

> ---
>  drivers/clk/mxs/clk-imx28.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/clk/mxs/clk-imx28.c b/drivers/clk/mxs/clk-imx28.c
> index 2826a26..17e85a1 100644
> --- a/drivers/clk/mxs/clk-imx28.c
> +++ b/drivers/clk/mxs/clk-imx28.c
> @@ -245,8 +245,8 @@ int __init mx28_clocks_init(void)
>  	clks[pll2] = mxs_clk_pll("pll2", "ref_xtal", PLL2CTRL0, 23, 50000000);
>  	clks[ref_cpu] = mxs_clk_ref("ref_cpu", "pll0", FRAC0, 0);
>  	clks[ref_emi] = mxs_clk_ref("ref_emi", "pll0", FRAC0, 1);
> -	clks[ref_io0] = mxs_clk_ref("ref_io0", "pll0", FRAC0, 2);
> -	clks[ref_io1] = mxs_clk_ref("ref_io1", "pll0", FRAC0, 3);
> +	clks[ref_io1] = mxs_clk_ref("ref_io1", "pll0", FRAC0, 2);
> +	clks[ref_io0] = mxs_clk_ref("ref_io0", "pll0", FRAC0, 3);
>  	clks[ref_pix] = mxs_clk_ref("ref_pix", "pll0", FRAC1, 0);
>  	clks[ref_hsadc] = mxs_clk_ref("ref_hsadc", "pll0", FRAC1, 1);
>  	clks[ref_gpmi] = mxs_clk_ref("ref_gpmi", "pll0", FRAC1, 2);


-- 
Maxime Ripard, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

      reply	other threads:[~2012-06-27  7:46 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-22  2:21 [PATCH] clk: mxs: fix ref_io clock definition Shawn Guo
2012-06-27  7:46 ` Maxime Ripard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FEABA4D.7000004@free-electrons.com \
    --to=maxime.ripard@free-electrons.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.