All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] clk: mxs: fix ref_io clock definition
@ 2012-06-22  2:21 Shawn Guo
  2012-06-27  7:46 ` Maxime Ripard
  0 siblings, 1 reply; 2+ messages in thread
From: Shawn Guo @ 2012-06-22  2:21 UTC (permalink / raw)
  To: linux-arm-kernel

The definition of clocks ref_io0 and ref_io1 were inverted.  It causes
a mmc regression on some boards right away.  Fix the regression by
correcting the ref_io clock definition.

Reported-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
---
 drivers/clk/mxs/clk-imx28.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/clk/mxs/clk-imx28.c b/drivers/clk/mxs/clk-imx28.c
index 2826a26..17e85a1 100644
--- a/drivers/clk/mxs/clk-imx28.c
+++ b/drivers/clk/mxs/clk-imx28.c
@@ -245,8 +245,8 @@ int __init mx28_clocks_init(void)
 	clks[pll2] = mxs_clk_pll("pll2", "ref_xtal", PLL2CTRL0, 23, 50000000);
 	clks[ref_cpu] = mxs_clk_ref("ref_cpu", "pll0", FRAC0, 0);
 	clks[ref_emi] = mxs_clk_ref("ref_emi", "pll0", FRAC0, 1);
-	clks[ref_io0] = mxs_clk_ref("ref_io0", "pll0", FRAC0, 2);
-	clks[ref_io1] = mxs_clk_ref("ref_io1", "pll0", FRAC0, 3);
+	clks[ref_io1] = mxs_clk_ref("ref_io1", "pll0", FRAC0, 2);
+	clks[ref_io0] = mxs_clk_ref("ref_io0", "pll0", FRAC0, 3);
 	clks[ref_pix] = mxs_clk_ref("ref_pix", "pll0", FRAC1, 0);
 	clks[ref_hsadc] = mxs_clk_ref("ref_hsadc", "pll0", FRAC1, 1);
 	clks[ref_gpmi] = mxs_clk_ref("ref_gpmi", "pll0", FRAC1, 2);
-- 
1.7.5.4

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [PATCH] clk: mxs: fix ref_io clock definition
  2012-06-22  2:21 [PATCH] clk: mxs: fix ref_io clock definition Shawn Guo
@ 2012-06-27  7:46 ` Maxime Ripard
  0 siblings, 0 replies; 2+ messages in thread
From: Maxime Ripard @ 2012-06-27  7:46 UTC (permalink / raw)
  To: linux-arm-kernel

Hi,

Le 22/06/2012 04:21, Shawn Guo a ?crit :
> The definition of clocks ref_io0 and ref_io1 were inverted.  It causes
> a mmc regression on some boards right away.  Fix the regression by
> correcting the ref_io clock definition.
> 
> Reported-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>

> ---
>  drivers/clk/mxs/clk-imx28.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/clk/mxs/clk-imx28.c b/drivers/clk/mxs/clk-imx28.c
> index 2826a26..17e85a1 100644
> --- a/drivers/clk/mxs/clk-imx28.c
> +++ b/drivers/clk/mxs/clk-imx28.c
> @@ -245,8 +245,8 @@ int __init mx28_clocks_init(void)
>  	clks[pll2] = mxs_clk_pll("pll2", "ref_xtal", PLL2CTRL0, 23, 50000000);
>  	clks[ref_cpu] = mxs_clk_ref("ref_cpu", "pll0", FRAC0, 0);
>  	clks[ref_emi] = mxs_clk_ref("ref_emi", "pll0", FRAC0, 1);
> -	clks[ref_io0] = mxs_clk_ref("ref_io0", "pll0", FRAC0, 2);
> -	clks[ref_io1] = mxs_clk_ref("ref_io1", "pll0", FRAC0, 3);
> +	clks[ref_io1] = mxs_clk_ref("ref_io1", "pll0", FRAC0, 2);
> +	clks[ref_io0] = mxs_clk_ref("ref_io0", "pll0", FRAC0, 3);
>  	clks[ref_pix] = mxs_clk_ref("ref_pix", "pll0", FRAC1, 0);
>  	clks[ref_hsadc] = mxs_clk_ref("ref_hsadc", "pll0", FRAC1, 1);
>  	clks[ref_gpmi] = mxs_clk_ref("ref_gpmi", "pll0", FRAC1, 2);


-- 
Maxime Ripard, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-06-27  7:46 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-06-22  2:21 [PATCH] clk: mxs: fix ref_io clock definition Shawn Guo
2012-06-27  7:46 ` Maxime Ripard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.