From: Glauber Costa <glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
To: Wanpeng Li <liwp.linux-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Andrew Morton
<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
Michal Hocko <mhocko-AlSwsSmVLrQ@public.gmane.org>,
Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>,
KAMEZAWA Hiroyuki
<kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>,
Balbir Singh
<bsingharora-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v2] memcg: unify mem_control_xxx to memcg_xxx
Date: Wed, 27 Jun 2012 12:43:50 +0400 [thread overview]
Message-ID: <4FEAC7C6.7030601@parallels.com> (raw)
In-Reply-To: <1340756175-3420-1-git-send-email-liwp.linux-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
On 06/27/2012 04:16 AM, Wanpeng Li wrote:
> From: Wanpeng Li <liwp-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
>
> Changelog:
>
> V2 -> V1:
>
> * replace memory_cgroup_xxx by memcg_xxx
>
> Unify memcg functions to memcg_xxx.
This patch achieves nothing.
You're changing a couple of function names. Andrew stated goal was to
change *all* function names from mem_cgroup_xxx to memcg_xxx, not just
one or two.
This can be done mechanically by replacing occurrences of mem_cgroup_xxx
with memcg_xxx, and verifying that your final result is correct by
compiling the kernel with and without the combination of config options
that matters here, plus a set of randconfigs - or anything like that.
Make sure you have Andrew's latest patch in your tree, that converts the
config option names.
WARNING: multiple messages have this Message-ID (diff)
From: Glauber Costa <glommer@parallels.com>
To: Wanpeng Li <liwp.linux@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Michal Hocko <mhocko@suse.cz>,
Johannes Weiner <hannes@cmpxchg.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Balbir Singh <bsingharora@gmail.com>,
<linux-kernel@vger.kernel.org>, <cgroups@vger.kernel.org>
Subject: Re: [PATCH v2] memcg: unify mem_control_xxx to memcg_xxx
Date: Wed, 27 Jun 2012 12:43:50 +0400 [thread overview]
Message-ID: <4FEAC7C6.7030601@parallels.com> (raw)
In-Reply-To: <1340756175-3420-1-git-send-email-liwp.linux@gmail.com>
On 06/27/2012 04:16 AM, Wanpeng Li wrote:
> From: Wanpeng Li <liwp@linux.vnet.ibm.com>
>
> Changelog:
>
> V2 -> V1:
>
> * replace memory_cgroup_xxx by memcg_xxx
>
> Unify memcg functions to memcg_xxx.
This patch achieves nothing.
You're changing a couple of function names. Andrew stated goal was to
change *all* function names from mem_cgroup_xxx to memcg_xxx, not just
one or two.
This can be done mechanically by replacing occurrences of mem_cgroup_xxx
with memcg_xxx, and verifying that your final result is correct by
compiling the kernel with and without the combination of config options
that matters here, plus a set of randconfigs - or anything like that.
Make sure you have Andrew's latest patch in your tree, that converts the
config option names.
next prev parent reply other threads:[~2012-06-27 8:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-27 0:16 [PATCH v2] memcg: unify mem_control_xxx to memcg_xxx Wanpeng Li
2012-06-27 0:16 ` Wanpeng Li
[not found] ` <1340756175-3420-1-git-send-email-liwp.linux-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-06-27 8:43 ` Glauber Costa [this message]
2012-06-27 8:43 ` Glauber Costa
[not found] ` <4FEAC7C6.7030601-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-06-27 8:59 ` Michal Hocko
2012-06-27 8:59 ` Michal Hocko
[not found] ` <20120627085917.GA5683-VqjxzfR4DlwKmadIfiO5sKVXKuFTiq87@public.gmane.org>
2012-06-27 9:00 ` Glauber Costa
2012-06-27 9:00 ` Glauber Costa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FEAC7C6.7030601@parallels.com \
--to=glommer-bzqdu9zft3wakbo8gow8eq@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=bsingharora-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org \
--cc=kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=liwp.linux-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=mhocko-AlSwsSmVLrQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.