* [PATCH 0/3] staging: ozwpan: Update TODO & fixes
@ 2012-06-26 12:03 Rupesh Gujare
2012-06-26 12:03 ` [PATCH 1/3] staging: ozwpan: Unregister with sysfs while unloading Rupesh Gujare
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Rupesh Gujare @ 2012-06-26 12:03 UTC (permalink / raw)
To: devel; +Cc: gregkh, linux-kernel
This patch patch series updates TODO & fixes issues found during development.
Rupesh Gujare (3):
[PATCH 1/3] staging: ozwpan: Unregister with sysfs while unloading.
[PATCH 2/3] staging: ozwpan: Fix compilation issue due to export.h
[PATCH 3/3] staging: ozwpan: Update TODO file
drivers/staging/ozwpan/TODO | 11 ++++++-----
drivers/staging/ozwpan/ozcdev.c | 12 ++++++++----
drivers/staging/ozwpan/ozhcd.c | 2 +-
3 files changed, 15 insertions(+), 10 deletions(-)
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH 1/3] staging: ozwpan: Unregister with sysfs while unloading. 2012-06-26 12:03 [PATCH 0/3] staging: ozwpan: Update TODO & fixes Rupesh Gujare @ 2012-06-26 12:03 ` Rupesh Gujare 2012-06-26 12:03 ` [PATCH 2/3] staging: ozwpan: Fix compilation issue due to export.h Rupesh Gujare 2012-06-26 12:03 ` [PATCH 3/3] staging: ozwpan: Update TODO file Rupesh Gujare 2 siblings, 0 replies; 6+ messages in thread From: Rupesh Gujare @ 2012-06-26 12:03 UTC (permalink / raw) To: devel; +Cc: gregkh, linux-kernel, Rupesh Gujare Destroy device node & unregister device class from sysfs while unloading driver Signed-off-by: Rupesh Gujare <rgujare@ozmodevices.com> --- drivers/staging/ozwpan/ozcdev.c | 12 ++++++++---- 1 files changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/staging/ozwpan/ozcdev.c b/drivers/staging/ozwpan/ozcdev.c index 929756a..d983219 100644 --- a/drivers/staging/ozwpan/ozcdev.c +++ b/drivers/staging/ozwpan/ozcdev.c @@ -42,6 +42,7 @@ struct oz_serial_ctx { /*------------------------------------------------------------------------------ */ static struct oz_cdev g_cdev; +struct class *g_oz_class; /*------------------------------------------------------------------------------ * Context: process and softirq */ @@ -330,7 +331,6 @@ const struct file_operations oz_fops = { int oz_cdev_register(void) { int err; - struct class *cl; struct device *dev; memset(&g_cdev, 0, sizeof(g_cdev)); err = alloc_chrdev_region(&g_cdev.devnum, 0, 1, "ozwpan"); @@ -348,12 +348,12 @@ int oz_cdev_register(void) oz_trace("Failed to add cdev\n"); goto out2; } - cl = class_create(THIS_MODULE, "ozmo_wpan"); - if (IS_ERR(cl)) { + g_oz_class = class_create(THIS_MODULE, "ozmo_wpan"); + if (IS_ERR(g_oz_class)) { oz_trace("Failed to register ozmo_wpan class\n"); goto out1; } - dev = device_create(cl, NULL, g_cdev.devnum, NULL, "ozwpan"); + dev = device_create(g_oz_class, NULL, g_cdev.devnum, NULL, "ozwpan"); if (IS_ERR(dev)) { oz_trace("Failed to create sysfs entry for cdev\n"); goto out1; @@ -373,6 +373,10 @@ int oz_cdev_deregister(void) { cdev_del(&g_cdev.cdev); unregister_chrdev_region(g_cdev.devnum, 1); + if (g_oz_class) { + device_destroy(g_oz_class, g_cdev.devnum); + class_destroy(g_oz_class); + } return 0; } /*------------------------------------------------------------------------------ -- 1.7.5.4 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/3] staging: ozwpan: Fix compilation issue due to export.h 2012-06-26 12:03 [PATCH 0/3] staging: ozwpan: Update TODO & fixes Rupesh Gujare 2012-06-26 12:03 ` [PATCH 1/3] staging: ozwpan: Unregister with sysfs while unloading Rupesh Gujare @ 2012-06-26 12:03 ` Rupesh Gujare 2012-06-26 22:07 ` Greg KH 2012-06-26 12:03 ` [PATCH 3/3] staging: ozwpan: Update TODO file Rupesh Gujare 2 siblings, 1 reply; 6+ messages in thread From: Rupesh Gujare @ 2012-06-26 12:03 UTC (permalink / raw) To: devel; +Cc: gregkh, linux-kernel, Rupesh Gujare Fixes compilation error caused due to header file. Signed-off-by: Rupesh Gujare <rgujare@ozmodevices.com> --- drivers/staging/ozwpan/ozhcd.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/staging/ozwpan/ozhcd.c b/drivers/staging/ozwpan/ozhcd.c index 251f07c..e3efa41 100644 --- a/drivers/staging/ozwpan/ozhcd.c +++ b/drivers/staging/ozwpan/ozhcd.c @@ -28,7 +28,7 @@ #include <linux/usb.h> #include <linux/jiffies.h> #include <linux/slab.h> -#include <linux/export.h> +#include <linux/module.h> #include "linux/usb/hcd.h" #include <asm/unaligned.h> #include "ozconfig.h" -- 1.7.5.4 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 2/3] staging: ozwpan: Fix compilation issue due to export.h 2012-06-26 12:03 ` [PATCH 2/3] staging: ozwpan: Fix compilation issue due to export.h Rupesh Gujare @ 2012-06-26 22:07 ` Greg KH 2012-06-27 9:55 ` Rupesh Gujare 0 siblings, 1 reply; 6+ messages in thread From: Greg KH @ 2012-06-26 22:07 UTC (permalink / raw) To: Rupesh Gujare; +Cc: devel, linux-kernel On Tue, Jun 26, 2012 at 01:03:40PM +0100, Rupesh Gujare wrote: > Fixes compilation error caused due to header file. > > Signed-off-by: Rupesh Gujare <rgujare@ozmodevices.com> > --- > drivers/staging/ozwpan/ozhcd.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/staging/ozwpan/ozhcd.c b/drivers/staging/ozwpan/ozhcd.c > index 251f07c..e3efa41 100644 > --- a/drivers/staging/ozwpan/ozhcd.c > +++ b/drivers/staging/ozwpan/ozhcd.c > @@ -28,7 +28,7 @@ > #include <linux/usb.h> > #include <linux/jiffies.h> > #include <linux/slab.h> > -#include <linux/export.h> > +#include <linux/module.h> I don't understand, what is this fixing? It builds for me ok here, why is module.h needed instead of export.h? confused, greg k-h ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/3] staging: ozwpan: Fix compilation issue due to export.h 2012-06-26 22:07 ` Greg KH @ 2012-06-27 9:55 ` Rupesh Gujare 0 siblings, 0 replies; 6+ messages in thread From: Rupesh Gujare @ 2012-06-27 9:55 UTC (permalink / raw) To: Greg KH; +Cc: devel, linux-kernel On 26/06/12 23:07, Greg KH wrote: > On Tue, Jun 26, 2012 at 01:03:40PM +0100, Rupesh Gujare wrote: >> Fixes compilation error caused due to header file. >> >> Signed-off-by: Rupesh Gujare <rgujare@ozmodevices.com> >> --- >> drivers/staging/ozwpan/ozhcd.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/drivers/staging/ozwpan/ozhcd.c b/drivers/staging/ozwpan/ozhcd.c >> index 251f07c..e3efa41 100644 >> --- a/drivers/staging/ozwpan/ozhcd.c >> +++ b/drivers/staging/ozwpan/ozhcd.c >> @@ -28,7 +28,7 @@ >> #include <linux/usb.h> >> #include <linux/jiffies.h> >> #include <linux/slab.h> >> -#include <linux/export.h> >> +#include <linux/module.h> > I don't understand, what is this fixing? It builds for me ok here, why > is module.h needed instead of export.h? > > confused, > Greg, Sorry about that. Looks like I tried to compile against distribution kernel, which was throwing error. Please ignore this patch. -- Regards, Rupesh Gujare ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 3/3] staging: ozwpan: Update TODO file 2012-06-26 12:03 [PATCH 0/3] staging: ozwpan: Update TODO & fixes Rupesh Gujare 2012-06-26 12:03 ` [PATCH 1/3] staging: ozwpan: Unregister with sysfs while unloading Rupesh Gujare 2012-06-26 12:03 ` [PATCH 2/3] staging: ozwpan: Fix compilation issue due to export.h Rupesh Gujare @ 2012-06-26 12:03 ` Rupesh Gujare 2 siblings, 0 replies; 6+ messages in thread From: Rupesh Gujare @ 2012-06-26 12:03 UTC (permalink / raw) To: devel; +Cc: gregkh, linux-kernel, Rupesh Gujare Update TODO file. Signed-off-by: Rupesh Gujare <rgujare@ozmodevices.com> --- drivers/staging/ozwpan/TODO | 11 ++++++----- 1 files changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/staging/ozwpan/TODO b/drivers/staging/ozwpan/TODO index c2d30a7..b5db245 100644 --- a/drivers/staging/ozwpan/TODO +++ b/drivers/staging/ozwpan/TODO @@ -1,10 +1,11 @@ TODO: - - review user mode interface and determine if ioctls can be replaced - with something better. correctly export data structures to user mode - if ioctls are still required and allocate ioctl numbers from - ioctl-number.txt. + - Convert event tracing code to in-kernel tracing infrastructure + - Check for remaining ioctl & check if that can be converted into + sysfs entries + - Convert debug prints to appropriate dev_debug or something better + - Modify Kconfig to add CONFIG option for enabling/disabling event + tracing. - check USB HCD implementation is complete and correct. - - remove any debug and trace code. - code review by USB developer community. - testing with as many devices as possible. -- 1.7.5.4 ^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-06-27 9:55 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2012-06-26 12:03 [PATCH 0/3] staging: ozwpan: Update TODO & fixes Rupesh Gujare 2012-06-26 12:03 ` [PATCH 1/3] staging: ozwpan: Unregister with sysfs while unloading Rupesh Gujare 2012-06-26 12:03 ` [PATCH 2/3] staging: ozwpan: Fix compilation issue due to export.h Rupesh Gujare 2012-06-26 22:07 ` Greg KH 2012-06-27 9:55 ` Rupesh Gujare 2012-06-26 12:03 ` [PATCH 3/3] staging: ozwpan: Update TODO file Rupesh Gujare
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.