From: "Christian König" <deathsimple@vodafone.de>
To: "Michel Dänzer" <michel@daenzer.net>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 1/3] drm/radeon: move ring locking out of reset path
Date: Fri, 29 Jun 2012 17:18:52 +0200 [thread overview]
Message-ID: <4FEDC75C.2020003@vodafone.de> (raw)
In-Reply-To: <1340982540.3562.204.camel@thor.local>
On 29.06.2012 17:09, Michel Dänzer wrote:
> On Fre, 2012-06-29 at 16:45 +0200, Christian König wrote:
>> Hold the ring lock the whole time the reset is in progress,
>> otherwise another process can submit new jobs.
> Sounds good, but doesn't this create other paths (e.g. initialization,
> resume) where the ring is being accessed without holding the lock? Isn't
> that a problem?
Thought about that also.
For init I'm pretty sure that no application can submit commands before
we are done, otherwise we are doomed anyway.
For resume I'm not really sure, but I think that applications are
resumed after the hardware driver had a chance of doing so.
Christian.
next prev parent reply other threads:[~2012-06-29 15:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-29 14:45 [PATCH 1/3] drm/radeon: move ring locking out of reset path Christian König
2012-06-29 14:45 ` [PATCH 2/3] drm/radeon: add error handling to fence_wait_empty_locked Christian König
2012-06-29 15:19 ` Michel Dänzer
2012-06-29 14:45 ` [PATCH 3/3] drm/radeon: add error handling to radeon_vm_unbind_locked Christian König
2012-06-29 15:13 ` Michel Dänzer
2012-06-29 15:09 ` [PATCH 1/3] drm/radeon: move ring locking out of reset path Michel Dänzer
2012-06-29 15:18 ` Christian König [this message]
2012-06-29 16:15 ` Michel Dänzer
2012-07-02 15:41 ` Jerome Glisse
2012-07-02 15:58 ` Christian König
2012-07-02 16:01 ` Jerome Glisse
2012-07-02 16:15 ` Jerome Glisse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FEDC75C.2020003@vodafone.de \
--to=deathsimple@vodafone.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=michel@daenzer.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.