setools FTBFS in python module

setools FTBFS in python module

[Laurent Bigonville]

Hi,

setools is currently FTBFS in debian due to swig 2.0.7 with the
following error:

> ../../../libqpol/include/qpol/terule_query.h:118:13: note: previous
> declaration of 'qpol_terule_get_rule_type' was here qpol_wrap.c: In
> function 'qpol_terule_get_rule_type': qpol_wrap.c:4888:3: warning:
> passing argument 1 of 'qpol_terule_get_rule_type' from incompatible
> pointer type [enabled by default] qpol_wrap.c:4885:16: note: expected
> 'struct qpol_terule *' but argument is of type 'struct qpol_policy_t
> *' qpol_wrap.c:4888:3: warning: passing argument 2 of
> 'qpol_terule_get_rule_type' from incompatible pointer type [enabled
> by default] qpol_wrap.c:4885:16: note: expected 'struct qpol_policy_t
> *' but argument is of type 'struct qpol_terule *' qpol_wrap.c:4888:3:
> error: too many arguments to function 'qpol_terule_get_rule_type'
> qpol_wrap.c:4885:16: note: declared here qpol_wrap.c: At top level:
> qpol_wrap.c:4895:31: error: conflicting types for
> 'qpol_terule_get_source_type' In file included
> from ../../../libqpol/include/qpol/policy.h:60:0,
> from ../../../libqpol/include/../include/qpol/avrule_query.h:34, from
> qpol_wrap.c:3010:

OpenSuse is applying a patch[1] that is fixing the issue. Do you think
that this patch could be merged (as well as the other swig patch that
fix swig 2.0 detection?).

Also what is the status of setools? It seems that all the distribution
(RedHat, OpenSuse, Debian,...) are applying a bunch of other patches.
Shouldn't all these be merged? Or is setools definitely dead?

Cheers

Laurent Bigonville

[0] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=672040
[1]
https://build.opensuse.org/package/view_file?file=setools-swig-2.0.7.patch&package=setools&project=security%3ASELinux&rev=fa0565dafcc84c3c18514867f92270a1

--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.

Re: setools FTBFS in python module

[Daniel J Walsh]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 06/28/2012 06:56 AM, Laurent Bigonville wrote:
> Hi,
> 
> setools is currently FTBFS in debian due to swig 2.0.7 with the following
> error:
> 
>> ../../../libqpol/include/qpol/terule_query.h:118:13: note: previous 
>> declaration of 'qpol_terule_get_rule_type' was here qpol_wrap.c: In 
>> function 'qpol_terule_get_rule_type': qpol_wrap.c:4888:3: warning: 
>> passing argument 1 of 'qpol_terule_get_rule_type' from incompatible 
>> pointer type [enabled by default] qpol_wrap.c:4885:16: note: expected 
>> 'struct qpol_terule *' but argument is of type 'struct qpol_policy_t *'
>> qpol_wrap.c:4888:3: warning: passing argument 2 of 
>> 'qpol_terule_get_rule_type' from incompatible pointer type [enabled by
>> default] qpol_wrap.c:4885:16: note: expected 'struct qpol_policy_t *' but
>> argument is of type 'struct qpol_terule *' qpol_wrap.c:4888:3: error: too
>> many arguments to function 'qpol_terule_get_rule_type' 
>> qpol_wrap.c:4885:16: note: declared here qpol_wrap.c: At top level: 
>> qpol_wrap.c:4895:31: error: conflicting types for 
>> 'qpol_terule_get_source_type' In file included from
>> ../../../libqpol/include/qpol/policy.h:60:0, from
>> ../../../libqpol/include/../include/qpol/avrule_query.h:34, from 
>> qpol_wrap.c:3010:
> 
> OpenSuse is applying a patch[1] that is fixing the issue. Do you think that
> this patch could be merged (as well as the other swig patch that fix swig
> 2.0 detection?).
> 
> Also what is the status of setools? It seems that all the distribution 
> (RedHat, OpenSuse, Debian,...) are applying a bunch of other patches. 
> Shouldn't all these be merged? Or is setools definitely dead?
> 
> Cheers
> 
> Laurent Bigonville
> 
> [0] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=672040 [1] 
> https://build.opensuse.org/package/view_file?file=setools-swig-2.0.7.patch&package=setools&project=security%3ASELinux&rev=fa0565dafcc84c3c18514867f92270a1
>
>  -- This message was distributed to subscribers of the selinux mailing
> list. If you no longer wish to subscribe, send mail to
> majordomo@tycho.nsa.gov with the words "unsubscribe selinux" without quotes
> as the message.
> 
> 
I guess we need someone to take over upstream for this.  We are actively
developing it but upstream has not worked on it in a long time and has ignored
patches.  Eric Paris @ Red Hat has stepped up to take over upstream
responsibilities on the SELinux user space, and I guess some one needs to
request that setools be opened up the community.  I would gladly submit the
Fedora patches to a responsive upstream.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk/uBN8ACgkQrlYvE4MpobOC9ACgtkFq9GZvPru39knmtahivDTv
k04AoIQWaveZUhcMqjcIQH7DyGwqRJ7V
=v6/j
-----END PGP SIGNATURE-----

--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.