From: Jon Hunter <jon-hunter@ti.com>
To: "Mohammed, Afzal" <afzal@ti.com>
Cc: Tony Lindgren <tony@atomide.com>,
"paul@pwsan.com" <paul@pwsan.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v5 3/3] ARM: OMAP2+: onenand: prepare for gpmc driver migration
Date: Mon, 2 Jul 2012 12:29:03 -0500 [thread overview]
Message-ID: <4FF1DA5F.9000409@ti.com> (raw)
In-Reply-To: <C8443D0743D26F4388EA172BF4E2A7A93E9A1BB7@DBDE01.ent.ti.com>
On 07/02/2012 04:43 AM, Mohammed, Afzal wrote:
> Hi Tony,
>
> On Mon, Jul 02, 2012 at 12:06:51, Tony Lindgren wrote:
>> * Jon Hunter <jon-hunter@ti.com> [120628 09:48]:
>
>>> The above change seems to imply that Tony's n900 is dependent on the bootloader settings
>>> and not those being set by the kernel. Ideally, we should not need to set the async mode
>>> in the onenand before we set the onenand timings in the gpmc (per Afzal's changelog
>>> comment). This appears backwards.
>>
>> That should not be the case, I'm more likely to believe in Afzal's explanation.
>
> Not sure whether you are fine with fixing up this patch with added diff
>
> Assuming inferences so far is not wrong, right now this patch with the added diff
> would be perfectly fine.
>
> Problem would happen when we are at a stage to do gpmc reset using hwmod [seems
> miles to go before I sleep {or read gpmc hwmod reset} ;)]. If bootloader left
> onenand configured in sync mode, to switch onenand to async mode, first configuring
> gpmc to sync mode would be required & for that we need frequency information
> from onenand and to get that information from onenand, gpmc has to be configured
> for sync mode and to configure gpmc to sync mode ....
You are concerned about hwmod performing a reset of the gpmc during
boot? We should be able to use the HWMOD_INIT_NO_RESET flag to prevent
this. Would that work?
Cheers
Jon
WARNING: multiple messages have this Message-ID (diff)
From: jon-hunter@ti.com (Jon Hunter)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 3/3] ARM: OMAP2+: onenand: prepare for gpmc driver migration
Date: Mon, 2 Jul 2012 12:29:03 -0500 [thread overview]
Message-ID: <4FF1DA5F.9000409@ti.com> (raw)
In-Reply-To: <C8443D0743D26F4388EA172BF4E2A7A93E9A1BB7@DBDE01.ent.ti.com>
On 07/02/2012 04:43 AM, Mohammed, Afzal wrote:
> Hi Tony,
>
> On Mon, Jul 02, 2012 at 12:06:51, Tony Lindgren wrote:
>> * Jon Hunter <jon-hunter@ti.com> [120628 09:48]:
>
>>> The above change seems to imply that Tony's n900 is dependent on the bootloader settings
>>> and not those being set by the kernel. Ideally, we should not need to set the async mode
>>> in the onenand before we set the onenand timings in the gpmc (per Afzal's changelog
>>> comment). This appears backwards.
>>
>> That should not be the case, I'm more likely to believe in Afzal's explanation.
>
> Not sure whether you are fine with fixing up this patch with added diff
>
> Assuming inferences so far is not wrong, right now this patch with the added diff
> would be perfectly fine.
>
> Problem would happen when we are at a stage to do gpmc reset using hwmod [seems
> miles to go before I sleep {or read gpmc hwmod reset} ;)]. If bootloader left
> onenand configured in sync mode, to switch onenand to async mode, first configuring
> gpmc to sync mode would be required & for that we need frequency information
> from onenand and to get that information from onenand, gpmc has to be configured
> for sync mode and to configure gpmc to sync mode ....
You are concerned about hwmod performing a reset of the gpmc during
boot? We should be able to use the HWMOD_INIT_NO_RESET flag to prevent
this. Would that work?
Cheers
Jon
next prev parent reply other threads:[~2012-07-02 17:29 UTC|newest]
Thread overview: 92+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-27 6:33 [PATCH v5 0/3] Prepare for GPMC driver conversion Afzal Mohammed
2012-06-27 6:33 ` Afzal Mohammed
2012-06-27 6:33 ` [PATCH v5 1/3] ARM: OMAP2+: nand: unify init functions Afzal Mohammed
2012-06-27 6:33 ` Afzal Mohammed
2012-06-27 6:33 ` [PATCH v5 2/3] ARM: OMAP2+: gpmc: handle additional timings Afzal Mohammed
2012-06-27 6:33 ` Afzal Mohammed
2012-06-27 6:34 ` [PATCH v5 3/3] ARM: OMAP2+: onenand: prepare for gpmc driver migration Afzal Mohammed
2012-06-27 6:34 ` Afzal Mohammed
2012-06-27 14:58 ` Tony Lindgren
2012-06-27 14:58 ` Tony Lindgren
2012-06-28 9:32 ` Mohammed, Afzal
2012-06-28 9:32 ` Mohammed, Afzal
2012-06-28 12:32 ` Tony Lindgren
2012-06-28 12:32 ` Tony Lindgren
2012-06-28 12:33 ` Mohammed, Afzal
2012-06-28 12:33 ` Mohammed, Afzal
2012-06-28 12:44 ` Mohammed, Afzal
2012-06-28 12:44 ` Mohammed, Afzal
2012-07-30 7:36 ` Mohammed, Afzal
2012-07-30 7:36 ` Mohammed, Afzal
2012-06-28 16:43 ` Jon Hunter
2012-06-28 16:43 ` Jon Hunter
2012-06-28 19:00 ` Jon Hunter
2012-06-28 19:00 ` Jon Hunter
2012-07-02 6:26 ` Tony Lindgren
2012-07-02 6:26 ` Tony Lindgren
2012-06-29 6:15 ` Mohammed, Afzal
2012-06-29 6:15 ` Mohammed, Afzal
2012-06-29 6:38 ` Mohammed, Afzal
2012-06-29 6:38 ` Mohammed, Afzal
2012-06-29 14:15 ` Jon Hunter
2012-06-29 14:15 ` Jon Hunter
2012-07-02 10:04 ` Mohammed, Afzal
2012-07-02 10:04 ` Mohammed, Afzal
2012-07-02 6:36 ` Tony Lindgren
2012-07-02 6:36 ` Tony Lindgren
2012-07-02 9:43 ` Mohammed, Afzal
2012-07-02 9:43 ` Mohammed, Afzal
2012-07-02 17:29 ` Jon Hunter [this message]
2012-07-02 17:29 ` Jon Hunter
2012-07-03 4:35 ` Mohammed, Afzal
2012-07-03 4:35 ` Mohammed, Afzal
2012-07-03 15:10 ` Jon Hunter
2012-07-03 15:10 ` Jon Hunter
2012-07-04 5:36 ` Mohammed, Afzal
2012-07-04 5:36 ` Mohammed, Afzal
2012-07-02 17:25 ` Jon Hunter
2012-07-02 17:25 ` Jon Hunter
2012-07-03 8:17 ` Tony Lindgren
2012-07-03 8:17 ` Tony Lindgren
2012-07-03 15:12 ` Jon Hunter
2012-07-03 15:12 ` Jon Hunter
2012-07-04 7:00 ` Mohammed, Afzal
2012-07-04 7:00 ` Mohammed, Afzal
2012-07-04 7:51 ` Tony Lindgren
2012-07-04 7:51 ` Tony Lindgren
2012-07-05 10:24 ` Mohammed, Afzal
2012-07-05 10:24 ` Mohammed, Afzal
2012-07-05 10:55 ` Tony Lindgren
2012-07-05 10:55 ` Tony Lindgren
2012-07-05 11:58 ` Mohammed, Afzal
2012-07-05 11:58 ` Mohammed, Afzal
2012-07-05 14:49 ` Tony Lindgren
2012-07-05 14:49 ` Tony Lindgren
2012-07-05 14:51 ` Mohammed, Afzal
2012-07-05 14:51 ` Mohammed, Afzal
2012-07-06 12:05 ` Tony Lindgren
2012-07-06 12:05 ` Tony Lindgren
2012-07-10 6:20 ` Mohammed, Afzal
2012-07-10 6:20 ` Mohammed, Afzal
2012-07-10 9:45 ` Tony Lindgren
2012-07-10 9:45 ` Tony Lindgren
2012-07-10 10:04 ` Mohammed, Afzal
2012-07-10 10:04 ` Mohammed, Afzal
2012-07-10 13:17 ` Tony Lindgren
2012-07-10 13:17 ` Tony Lindgren
2012-07-10 13:47 ` Mohammed, Afzal
2012-07-10 13:47 ` Mohammed, Afzal
2012-07-10 17:15 ` Jon Hunter
2012-07-10 17:15 ` Jon Hunter
2012-07-11 6:47 ` Tony Lindgren
2012-07-11 6:47 ` Tony Lindgren
2012-07-13 4:36 ` Mohammed, Afzal
2012-07-13 4:36 ` Mohammed, Afzal
2012-08-06 13:38 ` gpmc generic retime function (subject was RE: [PATCH v5 3/3] ARM: OMAP2+: onenand: prepare for gpmc driver migration) Mohammed, Afzal
2012-08-06 13:38 ` Mohammed, Afzal
2012-08-17 15:02 ` Jon Hunter
2012-08-17 15:02 ` Jon Hunter
2012-08-21 11:14 ` Mohammed, Afzal
2012-08-21 11:14 ` Mohammed, Afzal
2012-06-27 10:08 ` [PATCH v5 0/3] Prepare for GPMC driver conversion Mohammed, Afzal
2012-06-27 10:08 ` Mohammed, Afzal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FF1DA5F.9000409@ti.com \
--to=jon-hunter@ti.com \
--cc=afzal@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.