From: "Andreas Färber" <afaerber@suse.de>
To: Scott Wood <scottwood@freescale.com>
Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/4] PPC: e500: rename mpc8544ds into generic file
Date: Mon, 02 Jul 2012 22:58:49 +0200 [thread overview]
Message-ID: <4FF20B89.7030007@suse.de> (raw)
In-Reply-To: <4FF20575.9090708@freescale.com>
Am 02.07.2012 22:32, schrieb Scott Wood:
> On 07/02/2012 12:06 PM, Scott Wood wrote:
>> On 07/02/2012 11:50 AM, Andreas Färber wrote:
>>> Am 28.06.2012 01:50, schrieb Scott Wood:
>>>> hw/ppc/Makefile.objs | 2 +-
>>>> hw/{ppce500_mpc8544ds.c => ppc/e500.c} | 16 ++++++++--------
>>>> 2 files changed, 9 insertions(+), 9 deletions(-)
>>>> rename hw/{ppce500_mpc8544ds.c => ppc/e500.c} (99%)
>>>>
>>>> diff --git a/hw/ppc/Makefile.objs b/hw/ppc/Makefile.objs
>>>> index aa4bbeb..aa77f64 100644
>>>> --- a/hw/ppc/Makefile.objs
>>>> +++ b/hw/ppc/Makefile.objs
>>>> @@ -15,7 +15,7 @@ obj-$(CONFIG_PSERIES) += spapr_pci.o pci-hotplug.o spapr_iommu.o
>>>> obj-y += ppc4xx_devs.o ppc4xx_pci.o ppc405_uc.o ppc405_boards.o
>>>> obj-y += ppc440_bamboo.o
>>>> # PowerPC E500 boards
>>>> -obj-$(CONFIG_FDT) += ppce500_mpc8544ds.o mpc8544_guts.o ppce500_spin.o
>>>> +obj-$(CONFIG_FDT) += ppc/e500.o mpc8544_guts.o ppce500_spin.o
>>>> # PowerPC 440 Xilinx ML507 reference board.
>>>> obj-y += virtex_ml507.o
>>>> # PowerPC OpenPIC
>>> [snip]
>>>
>>> The location seems perfect for the file and nicely simplifies the file
>>> name, but could we avoid ../ppc/ by doing:
>>>
>>> obj-$(CONFIG_FDT) += e500.o
>>>
>>> further down after the ../ prefix has been added for the legacy files?
>>
>> Ah, didn't notice that down there. Will fix.
>
> Wait, how will appending ../ help with the ppc/ prefix?
hw/ppc/ is the current directory. Therefore a ../ prefix is added for
all hw/ files in obj-y last thing in the Makefile. Your patch thus
constructs the path hw/ppc/../ppc/e500.o. My suggestion was to simply
use hw/ppc/e500.o. :)
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2012-07-02 20:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20120627235055.GA9149@tyr.buserror.net>
2012-07-02 16:50 ` [Qemu-devel] [PATCH 1/4] PPC: e500: rename mpc8544ds into generic file Andreas Färber
2012-07-02 17:06 ` Scott Wood
2012-07-02 20:32 ` [Qemu-devel] [Qemu-ppc] " Scott Wood
2012-07-02 20:58 ` Andreas Färber [this message]
2012-07-02 21:07 ` Scott Wood
2012-07-02 21:08 ` Alexander Graf
2012-07-02 21:16 ` Scott Wood
2012-07-02 21:17 ` Alexander Graf
2012-07-02 21:28 ` Scott Wood
2012-07-03 11:33 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FF20B89.7030007@suse.de \
--to=afaerber@suse.de \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.