All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
To: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org, linux-acpi@vger.kernel.org
Cc: rientjes@google.com, liuj97@gmail.com, len.brown@intel.com,
	benh@kernel.crashing.org, paulus@samba.org, cl@linux.com,
	minchan.kim@gmail.com, akpm@linux-foundation.org,
	kosaki.motohiro@jp.fujitsu.com
Subject: [RFC PATCH v2 12/13] memory-hotplug : add node_device_release
Date: Tue, 3 Jul 2012 15:05:15 +0900	[thread overview]
Message-ID: <4FF28B9B.5010409@jp.fujitsu.com> (raw)
In-Reply-To: <4FF287C3.4030901@jp.fujitsu.com>

When calling unregister_node(), the function shows following message at
device_release().

Device 'node2' does not have a release() function, it is broken and must be
fixed.

So the patch implements node_device_release()

CC: David Rientjes <rientjes@google.com>
CC: Jiang Liu <liuj97@gmail.com>
CC: Len Brown <len.brown@intel.com>
CC: Benjamin Herrenschmidt <benh@kernel.crashing.org>
CC: Paul Mackerras <paulus@samba.org>
CC: Christoph Lameter <cl@linux.com>
Cc: Minchan Kim <minchan.kim@gmail.com>
CC: Andrew Morton <akpm@linux-foundation.org>
CC: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Signed-off-by: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>

---
 drivers/base/node.c |    7 +++++++
 1 file changed, 7 insertions(+)

Index: linux-3.5-rc4/drivers/base/node.c
===================================================================
--- linux-3.5-rc4.orig/drivers/base/node.c	2012-07-03 14:21:44.882432167 +0900
+++ linux-3.5-rc4/drivers/base/node.c	2012-07-03 14:22:23.296951921 +0900
@@ -252,6 +252,12 @@ static inline void hugetlb_register_node
 static inline void hugetlb_unregister_node(struct node *node) {}
 #endif

+static void node_device_release(struct device *dev)
+{
+	struct node *node_dev = to_node(dev);
+
+	memset(node_dev, 0, sizeof(struct node));
+}

 /*
  * register_node - Setup a sysfs device for a node.
@@ -265,6 +271,7 @@ int register_node(struct node *node, int

 	node->dev.id = num;
 	node->dev.bus = &node_subsys;
+	node->dev.release = node_device_release;
 	error = device_register(&node->dev);

 	if (!error){

WARNING: multiple messages have this Message-ID (diff)
From: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
To: <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>,
	<linuxppc-dev@lists.ozlabs.org>, <linux-acpi@vger.kernel.org>
Cc: len.brown@intel.com, paulus@samba.org, minchan.kim@gmail.com,
	kosaki.motohiro@jp.fujitsu.com, rientjes@google.com,
	cl@linux.com, akpm@linux-foundation.org, liuj97@gmail.com
Subject: [RFC PATCH v2 12/13] memory-hotplug : add node_device_release
Date: Tue, 3 Jul 2012 15:05:15 +0900	[thread overview]
Message-ID: <4FF28B9B.5010409@jp.fujitsu.com> (raw)
In-Reply-To: <4FF287C3.4030901@jp.fujitsu.com>

When calling unregister_node(), the function shows following message at
device_release().

Device 'node2' does not have a release() function, it is broken and must be
fixed.

So the patch implements node_device_release()

CC: David Rientjes <rientjes@google.com>
CC: Jiang Liu <liuj97@gmail.com>
CC: Len Brown <len.brown@intel.com>
CC: Benjamin Herrenschmidt <benh@kernel.crashing.org>
CC: Paul Mackerras <paulus@samba.org>
CC: Christoph Lameter <cl@linux.com>
Cc: Minchan Kim <minchan.kim@gmail.com>
CC: Andrew Morton <akpm@linux-foundation.org>
CC: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Signed-off-by: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>

---
 drivers/base/node.c |    7 +++++++
 1 file changed, 7 insertions(+)

Index: linux-3.5-rc4/drivers/base/node.c
===================================================================
--- linux-3.5-rc4.orig/drivers/base/node.c	2012-07-03 14:21:44.882432167 +0900
+++ linux-3.5-rc4/drivers/base/node.c	2012-07-03 14:22:23.296951921 +0900
@@ -252,6 +252,12 @@ static inline void hugetlb_register_node
 static inline void hugetlb_unregister_node(struct node *node) {}
 #endif

+static void node_device_release(struct device *dev)
+{
+	struct node *node_dev = to_node(dev);
+
+	memset(node_dev, 0, sizeof(struct node));
+}

 /*
  * register_node - Setup a sysfs device for a node.
@@ -265,6 +271,7 @@ int register_node(struct node *node, int

 	node->dev.id = num;
 	node->dev.bus = &node_subsys;
+	node->dev.release = node_device_release;
 	error = device_register(&node->dev);

 	if (!error){

WARNING: multiple messages have this Message-ID (diff)
From: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
To: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org, linux-acpi@vger.kernel.org
Cc: rientjes@google.com, liuj97@gmail.com, len.brown@intel.com,
	benh@kernel.crashing.org, paulus@samba.org, cl@linux.com,
	minchan.kim@gmail.com, akpm@linux-foundation.org,
	kosaki.motohiro@jp.fujitsu.com
Subject: [RFC PATCH v2 12/13] memory-hotplug : add node_device_release
Date: Tue, 3 Jul 2012 15:05:15 +0900	[thread overview]
Message-ID: <4FF28B9B.5010409@jp.fujitsu.com> (raw)
In-Reply-To: <4FF287C3.4030901@jp.fujitsu.com>

When calling unregister_node(), the function shows following message at
device_release().

Device 'node2' does not have a release() function, it is broken and must be
fixed.

So the patch implements node_device_release()

CC: David Rientjes <rientjes@google.com>
CC: Jiang Liu <liuj97@gmail.com>
CC: Len Brown <len.brown@intel.com>
CC: Benjamin Herrenschmidt <benh@kernel.crashing.org>
CC: Paul Mackerras <paulus@samba.org>
CC: Christoph Lameter <cl@linux.com>
Cc: Minchan Kim <minchan.kim@gmail.com>
CC: Andrew Morton <akpm@linux-foundation.org>
CC: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Signed-off-by: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>

---
 drivers/base/node.c |    7 +++++++
 1 file changed, 7 insertions(+)

Index: linux-3.5-rc4/drivers/base/node.c
===================================================================
--- linux-3.5-rc4.orig/drivers/base/node.c	2012-07-03 14:21:44.882432167 +0900
+++ linux-3.5-rc4/drivers/base/node.c	2012-07-03 14:22:23.296951921 +0900
@@ -252,6 +252,12 @@ static inline void hugetlb_register_node
 static inline void hugetlb_unregister_node(struct node *node) {}
 #endif

+static void node_device_release(struct device *dev)
+{
+	struct node *node_dev = to_node(dev);
+
+	memset(node_dev, 0, sizeof(struct node));
+}

 /*
  * register_node - Setup a sysfs device for a node.
@@ -265,6 +271,7 @@ int register_node(struct node *node, int

 	node->dev.id = num;
 	node->dev.bus = &node_subsys;
+	node->dev.release = node_device_release;
 	error = device_register(&node->dev);

 	if (!error){

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
To: <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>,
	<linuxppc-dev@lists.ozlabs.org>, <linux-acpi@vger.kernel.org>
Cc: <rientjes@google.com>, <liuj97@gmail.com>, <len.brown@intel.com>,
	<benh@kernel.crashing.org>, <paulus@samba.org>, <cl@linux.com>,
	<minchan.kim@gmail.com>, <akpm@linux-foundation.org>,
	<kosaki.motohiro@jp.fujitsu.com>
Subject: [RFC PATCH v2 12/13] memory-hotplug : add node_device_release
Date: Tue, 3 Jul 2012 15:05:15 +0900	[thread overview]
Message-ID: <4FF28B9B.5010409@jp.fujitsu.com> (raw)
In-Reply-To: <4FF287C3.4030901@jp.fujitsu.com>

When calling unregister_node(), the function shows following message at
device_release().

Device 'node2' does not have a release() function, it is broken and must be
fixed.

So the patch implements node_device_release()

CC: David Rientjes <rientjes@google.com>
CC: Jiang Liu <liuj97@gmail.com>
CC: Len Brown <len.brown@intel.com>
CC: Benjamin Herrenschmidt <benh@kernel.crashing.org>
CC: Paul Mackerras <paulus@samba.org>
CC: Christoph Lameter <cl@linux.com>
Cc: Minchan Kim <minchan.kim@gmail.com>
CC: Andrew Morton <akpm@linux-foundation.org>
CC: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Signed-off-by: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>

---
 drivers/base/node.c |    7 +++++++
 1 file changed, 7 insertions(+)

Index: linux-3.5-rc4/drivers/base/node.c
===================================================================
--- linux-3.5-rc4.orig/drivers/base/node.c	2012-07-03 14:21:44.882432167 +0900
+++ linux-3.5-rc4/drivers/base/node.c	2012-07-03 14:22:23.296951921 +0900
@@ -252,6 +252,12 @@ static inline void hugetlb_register_node
 static inline void hugetlb_unregister_node(struct node *node) {}
 #endif

+static void node_device_release(struct device *dev)
+{
+	struct node *node_dev = to_node(dev);
+
+	memset(node_dev, 0, sizeof(struct node));
+}

 /*
  * register_node - Setup a sysfs device for a node.
@@ -265,6 +271,7 @@ int register_node(struct node *node, int

 	node->dev.id = num;
 	node->dev.bus = &node_subsys;
+	node->dev.release = node_device_release;
 	error = device_register(&node->dev);

 	if (!error){


  parent reply	other threads:[~2012-07-03  6:05 UTC|newest]

Thread overview: 86+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-03  5:48 [RFC PATCH v2 0/13] memory-hotplug : hot-remove physical memory Yasuaki Ishimatsu
2012-07-03  5:48 ` Yasuaki Ishimatsu
2012-07-03  5:48 ` Yasuaki Ishimatsu
2012-07-03  5:52 ` [RFC PATCH v2 1/13] memory-hotplug : rename remove_memory to offline_memory Yasuaki Ishimatsu
2012-07-03  5:52   ` Yasuaki Ishimatsu
2012-07-03  5:52   ` Yasuaki Ishimatsu
2012-07-03  5:52   ` Yasuaki Ishimatsu
2012-07-03  5:54 ` [RFC PATCH v2 2/13] memory-hotplug : add physical memory hotplug code to acpi_memory_device_remove Yasuaki Ishimatsu
2012-07-03  5:54   ` Yasuaki Ishimatsu
2012-07-03  5:54   ` Yasuaki Ishimatsu
2012-07-03  5:54   ` Yasuaki Ishimatsu
2012-07-03  6:21   ` Wen Congyang
2012-07-03  6:21     ` Wen Congyang
2012-07-03  6:21     ` Wen Congyang
2012-07-03  7:40     ` Yasuaki Ishimatsu
2012-07-03  7:40       ` Yasuaki Ishimatsu
2012-07-03  7:40       ` Yasuaki Ishimatsu
2012-07-03  7:40       ` Yasuaki Ishimatsu
2012-07-03  7:49       ` Wen Congyang
2012-07-03  7:49         ` Wen Congyang
2012-07-03  7:49         ` Wen Congyang
2012-07-03  5:55 ` [RFC PATCH v2 3/13] unify argument of firmware_map_add_early/hotplug Yasuaki Ishimatsu
2012-07-03  5:55   ` Yasuaki Ishimatsu
2012-07-03  5:55   ` Yasuaki Ishimatsu
2012-07-03  5:55   ` Yasuaki Ishimatsu
2012-07-03  5:56 ` [RFC PATCH v2 4/13] memory-hotplug : remove /sys/firmware/memmap/X sysfs Yasuaki Ishimatsu
2012-07-03  5:56   ` Yasuaki Ishimatsu
2012-07-03  5:56   ` Yasuaki Ishimatsu
2012-07-03  6:35   ` Wen Congyang
2012-07-03  6:35     ` Wen Congyang
2012-07-03  6:35     ` Wen Congyang
2012-07-04  4:45     ` Yasuaki Ishimatsu
2012-07-04  4:45       ` Yasuaki Ishimatsu
2012-07-04  4:45       ` Yasuaki Ishimatsu
2012-07-04  5:08       ` Wen Congyang
2012-07-04  5:08         ` Wen Congyang
2012-07-04  5:08         ` Wen Congyang
2012-07-04  5:52         ` Yasuaki Ishimatsu
2012-07-04  5:52           ` Yasuaki Ishimatsu
2012-07-04  5:52           ` Yasuaki Ishimatsu
2012-07-04 10:01           ` Wen Congyang
2012-07-04 10:01             ` Wen Congyang
2012-07-04 10:01             ` Wen Congyang
2012-07-06  8:27             ` Yasuaki Ishimatsu
2012-07-06  8:27               ` Yasuaki Ishimatsu
2012-07-06  8:27               ` Yasuaki Ishimatsu
2012-07-06  9:20               ` Wen Congyang
2012-07-06  9:20                 ` Wen Congyang
2012-07-06  9:20                 ` Wen Congyang
2012-07-06  9:20                 ` Wen Congyang
2012-07-09  8:18                 ` Yasuaki Ishimatsu
2012-07-09  8:18                   ` Yasuaki Ishimatsu
2012-07-09  8:18                   ` Yasuaki Ishimatsu
2012-07-09  8:18                   ` Yasuaki Ishimatsu
2012-07-03  5:58 ` [RFC PATCH v2 5/13] memory-hotplug : does not release memory region in PAGES_PER_SECTION chunks Yasuaki Ishimatsu
2012-07-03  5:58   ` Yasuaki Ishimatsu
2012-07-03  5:58   ` Yasuaki Ishimatsu
2012-07-03  5:58   ` Yasuaki Ishimatsu
2012-07-03  5:59 ` [RFC PATCH v2 6/13] memory-hotplug : add memory_block_release Yasuaki Ishimatsu
2012-07-03  5:59   ` Yasuaki Ishimatsu
2012-07-03  5:59   ` Yasuaki Ishimatsu
2012-07-03  6:00 ` [RFC PATCH v2 7/13] memory-hotplug : remove_memory calls __remove_pages Yasuaki Ishimatsu
2012-07-03  6:00   ` Yasuaki Ishimatsu
2012-07-03  6:00   ` Yasuaki Ishimatsu
2012-07-03  6:00   ` Yasuaki Ishimatsu
2012-07-03  6:01 ` [RFC PATCH v2 8/13] memory-hotplug : check page type in get_page_bootmem Yasuaki Ishimatsu
2012-07-03  6:01   ` Yasuaki Ishimatsu
2012-07-03  6:01   ` Yasuaki Ishimatsu
2012-07-03  6:02 ` [RFC PATCH v2 9/13] memory-hotplug : move register_page_bootmem_info_node and put_page_bootmem for sparse-vmemmap Yasuaki Ishimatsu
2012-07-03  6:02   ` Yasuaki Ishimatsu
2012-07-03  6:02   ` Yasuaki Ishimatsu
2012-07-03  6:03 ` [RFC PATCH v2 10/13] memory-hotplug : implement register_page_bootmem_info_section of sparse-vmemmap Yasuaki Ishimatsu
2012-07-03  6:03   ` Yasuaki Ishimatsu
2012-07-03  6:03   ` Yasuaki Ishimatsu
2012-07-03  6:03   ` Yasuaki Ishimatsu
2012-07-03  6:04 ` [RFC PATCH v2 11/13] memory-hotplug : free memmap " Yasuaki Ishimatsu
2012-07-03  6:04   ` Yasuaki Ishimatsu
2012-07-03  6:04   ` Yasuaki Ishimatsu
2012-07-03  6:04   ` Yasuaki Ishimatsu
2012-07-03  6:05 ` Yasuaki Ishimatsu [this message]
2012-07-03  6:05   ` [RFC PATCH v2 12/13] memory-hotplug : add node_device_release Yasuaki Ishimatsu
2012-07-03  6:05   ` Yasuaki Ishimatsu
2012-07-03  6:05   ` Yasuaki Ishimatsu
2012-07-03  6:06 ` [RFC PATCH v2 13/13] memory-hotplug : remove sysfs file of node Yasuaki Ishimatsu
2012-07-03  6:06   ` Yasuaki Ishimatsu
2012-07-03  6:06   ` Yasuaki Ishimatsu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FF28B9B.5010409@jp.fujitsu.com \
    --to=isimatu.yasuaki@jp.fujitsu.com \
    --cc=akpm@linux-foundation.org \
    --cc=benh@kernel.crashing.org \
    --cc=cl@linux.com \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=len.brown@intel.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=liuj97@gmail.com \
    --cc=minchan.kim@gmail.com \
    --cc=paulus@samba.org \
    --cc=rientjes@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.