From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Shawn Guo <shawn.guo@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org, linux-can@vger.kernel.org
Subject: Re: [PATCH RESEND 3/5] can: flexcan: adopt pinctrl support
Date: Tue, 03 Jul 2012 12:00:52 +0200 [thread overview]
Message-ID: <4FF2C2D4.7070408@pengutronix.de> (raw)
In-Reply-To: <20120702015206.GA21003@S2101-09.ap.freescale.net>
[-- Attachment #1: Type: text/plain, Size: 871 bytes --]
On 07/02/2012 03:52 AM, Shawn Guo wrote:
> On Mon, Jul 02, 2012 at 12:49:37AM +0200, Marc Kleine-Budde wrote:
>>> + pinctrl = devm_pinctrl_get_select_default(&pdev->dev);
>>> + if (IS_ERR(pinctrl))
>>> + return PTR_ERR(pinctrl);
>>> +
>>> if (pdev->dev.of_node) {
>>> const u32 *clock_freq_p;
>>
>> I'm on mx28 and trying to load the flexcan driver via DT, but
>> devm_pinctrl_get_select_default fails with -19.
>>
> You need to have pinctrl state setup in dts, some like:
>
> http://article.gmane.org/gmane.linux.ports.arm.kernel/174148
Works like charm.
tnx, Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: mkl@pengutronix.de (Marc Kleine-Budde)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RESEND 3/5] can: flexcan: adopt pinctrl support
Date: Tue, 03 Jul 2012 12:00:52 +0200 [thread overview]
Message-ID: <4FF2C2D4.7070408@pengutronix.de> (raw)
In-Reply-To: <20120702015206.GA21003@S2101-09.ap.freescale.net>
On 07/02/2012 03:52 AM, Shawn Guo wrote:
> On Mon, Jul 02, 2012 at 12:49:37AM +0200, Marc Kleine-Budde wrote:
>>> + pinctrl = devm_pinctrl_get_select_default(&pdev->dev);
>>> + if (IS_ERR(pinctrl))
>>> + return PTR_ERR(pinctrl);
>>> +
>>> if (pdev->dev.of_node) {
>>> const u32 *clock_freq_p;
>>
>> I'm on mx28 and trying to load the flexcan driver via DT, but
>> devm_pinctrl_get_select_default fails with -19.
>>
> You need to have pinctrl state setup in dts, some like:
>
> http://article.gmane.org/gmane.linux.ports.arm.kernel/174148
Works like charm.
tnx, Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 262 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120703/003854e2/attachment.sig>
next prev parent reply other threads:[~2012-07-03 10:00 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-07 0:53 [PATCH RESEND 0/5] Adopt pinctrl support for a few outstanding imx drivers Shawn Guo
2012-05-07 0:53 ` Shawn Guo
2012-05-07 0:53 ` [PATCH RESEND 1/5] tty: serial: imx: adopt pinctrl support Shawn Guo
2012-05-07 0:53 ` Shawn Guo
2012-05-08 3:43 ` Dong Aisheng
2012-05-08 3:43 ` Dong Aisheng
2012-05-07 0:53 ` [PATCH RESEND 2/5] net: fec: " Shawn Guo
2012-05-07 0:53 ` Shawn Guo
2012-05-08 3:44 ` Dong Aisheng
2012-05-08 3:44 ` Dong Aisheng
2012-05-11 22:31 ` David Miller
2012-05-11 22:31 ` David Miller
2012-05-07 0:53 ` [PATCH RESEND 3/5] can: flexcan: " Shawn Guo
2012-05-07 0:53 ` Shawn Guo
2012-05-07 8:06 ` Marc Kleine-Budde
2012-05-07 8:06 ` Marc Kleine-Budde
2012-05-07 8:17 ` Shawn Guo
2012-05-07 8:17 ` Shawn Guo
2012-05-07 8:29 ` Marc Kleine-Budde
2012-05-07 8:29 ` Marc Kleine-Budde
2012-05-08 3:44 ` Dong Aisheng
2012-05-08 3:44 ` Dong Aisheng
2012-07-01 22:49 ` Marc Kleine-Budde
2012-07-01 22:49 ` Marc Kleine-Budde
2012-07-02 1:52 ` Shawn Guo
2012-07-02 1:52 ` Shawn Guo
2012-07-03 10:00 ` Marc Kleine-Budde [this message]
2012-07-03 10:00 ` Marc Kleine-Budde
[not found] ` <1336352040-28447-1-git-send-email-shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2012-05-07 0:53 ` [PATCH RESEND 4/5] i2c: imx: " Shawn Guo
2012-05-07 0:53 ` Shawn Guo
[not found] ` <1336352040-28447-5-git-send-email-shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2012-05-08 3:45 ` Dong Aisheng
2012-05-08 3:45 ` Dong Aisheng
2012-05-07 0:54 ` [PATCH RESEND 5/5] spi/imx: " Shawn Guo
2012-05-07 0:54 ` Shawn Guo
2012-05-08 3:45 ` Dong Aisheng
2012-05-08 3:45 ` Dong Aisheng
[not found] ` <20120508034545.GJ23607-Fb7DQEYuewWctlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org>
2012-05-20 4:40 ` Grant Likely
2012-05-20 4:40 ` Grant Likely
2012-05-20 5:19 ` Shawn Guo
2012-05-20 5:19 ` Shawn Guo
2012-05-07 6:50 ` [PATCH RESEND 0/5] Adopt pinctrl support for a few outstanding imx drivers Dong Aisheng
2012-05-07 6:50 ` Dong Aisheng
2012-05-07 6:50 ` Dong Aisheng
2012-05-07 7:34 ` Shawn Guo
2012-05-07 7:34 ` Shawn Guo
2012-05-07 7:53 ` Dong Aisheng
2012-05-07 7:53 ` Dong Aisheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FF2C2D4.7070408@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-can@vger.kernel.org \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.