All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mohammed Shafi Shajakhan <mohammed@qca.qualcomm.com>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] [RFC] ath9k: Fix MCI cleanup
Date: Tue, 3 Jul 2012 20:56:18 +0530	[thread overview]
Message-ID: <4FF30F1A.9020606@qca.qualcomm.com> (raw)
In-Reply-To: <1341328678-13824-1-git-send-email-mohammed@qca.qualcomm.com>

On Tuesday 03 July 2012 08:47 PM, Mohammed Shafi Shajakhan wrote:
> From: Mohammed Shafi Shajakhan<mohammed@qca.qualcomm.com>
>
> We are doing MCI cleanup eventhough BTCOEX is not enabled
> via module parameter. This means we do ath_mci_cleanup
> though we skipped calling ath_mci_setup. Yet it does not
> causes any issues now  as we free the DMA buffer allocated
> only when it is allocated during ath_mci_setup.
>
> Signed-off-by: Mohammed Shafi Shajakhan<mohammed@qca.qualcomm.com>
> ---
>   drivers/net/wireless/ath/ath9k/gpio.c |    4 +++-
>   1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath9k/gpio.c b/drivers/net/wireless/ath/ath9k/gpio.c
> index 5eac4d1..43557c2 100644
> --- a/drivers/net/wireless/ath/ath9k/gpio.c
> +++ b/drivers/net/wireless/ath/ath9k/gpio.c
> @@ -387,11 +387,13 @@ void ath9k_stop_btcoex(struct ath_softc *sc)
>
>   void ath9k_deinit_btcoex(struct ath_softc *sc)
>   {
> +	struct ath_hw *ah = sc->sc_ah;
> +
>           if ((sc->btcoex.no_stomp_timer)&&
>   	ath9k_hw_get_btcoex_scheme(sc->sc_ah) == ATH_BTCOEX_CFG_3WIRE)
>   		ath_gen_timer_free(sc->sc_ah, sc->btcoex.no_stomp_timer);
>
> -	if (AR_SREV_9462(sc->sc_ah))
> +	if (ath9k_hw_mci_is_enabled(ah))
>   		ath_mci_cleanup(sc);
>   }
>

also we unnecessarily call ar9003_mci_cleanup.

-- 
thanks,
shafi

WARNING: multiple messages have this Message-ID (diff)
From: Mohammed Shafi Shajakhan <mohammed@qca.qualcomm.com>
To: <linux-wireless@vger.kernel.org>
Cc: Mohammed Shafi Shajakhan <mohammed@qca.qualcomm.com>,
	"John W. Linville" <linville@tuxdriver.com>,
	Rodriguez Luis <rodrigue@qca.qualcomm.com>,
	<ath9k-devel@lists.ath9k.org>,
	Rajkumar Manoharan <rmanohar@qca.qualcomm.com>,
	Bala Shanmugam <bkamatch@qca.qualcomm.com>,
	Senthil Balasubramanian <senthilb@qca.qualcomm.com>
Subject: Re: [RFC] ath9k: Fix MCI cleanup
Date: Tue, 3 Jul 2012 20:56:18 +0530	[thread overview]
Message-ID: <4FF30F1A.9020606@qca.qualcomm.com> (raw)
In-Reply-To: <1341328678-13824-1-git-send-email-mohammed@qca.qualcomm.com>

On Tuesday 03 July 2012 08:47 PM, Mohammed Shafi Shajakhan wrote:
> From: Mohammed Shafi Shajakhan<mohammed@qca.qualcomm.com>
>
> We are doing MCI cleanup eventhough BTCOEX is not enabled
> via module parameter. This means we do ath_mci_cleanup
> though we skipped calling ath_mci_setup. Yet it does not
> causes any issues now  as we free the DMA buffer allocated
> only when it is allocated during ath_mci_setup.
>
> Signed-off-by: Mohammed Shafi Shajakhan<mohammed@qca.qualcomm.com>
> ---
>   drivers/net/wireless/ath/ath9k/gpio.c |    4 +++-
>   1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath9k/gpio.c b/drivers/net/wireless/ath/ath9k/gpio.c
> index 5eac4d1..43557c2 100644
> --- a/drivers/net/wireless/ath/ath9k/gpio.c
> +++ b/drivers/net/wireless/ath/ath9k/gpio.c
> @@ -387,11 +387,13 @@ void ath9k_stop_btcoex(struct ath_softc *sc)
>
>   void ath9k_deinit_btcoex(struct ath_softc *sc)
>   {
> +	struct ath_hw *ah = sc->sc_ah;
> +
>           if ((sc->btcoex.no_stomp_timer)&&
>   	ath9k_hw_get_btcoex_scheme(sc->sc_ah) == ATH_BTCOEX_CFG_3WIRE)
>   		ath_gen_timer_free(sc->sc_ah, sc->btcoex.no_stomp_timer);
>
> -	if (AR_SREV_9462(sc->sc_ah))
> +	if (ath9k_hw_mci_is_enabled(ah))
>   		ath_mci_cleanup(sc);
>   }
>

also we unnecessarily call ar9003_mci_cleanup.

-- 
thanks,
shafi

  reply	other threads:[~2012-07-03 15:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-03 15:17 [ath9k-devel] [RFC] ath9k: Fix MCI cleanup Mohammed Shafi Shajakhan
2012-07-03 15:17 ` Mohammed Shafi Shajakhan
2012-07-03 15:26 ` Mohammed Shafi Shajakhan [this message]
2012-07-03 15:26   ` Mohammed Shafi Shajakhan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FF30F1A.9020606@qca.qualcomm.com \
    --to=mohammed@qca.qualcomm.com \
    --cc=ath9k-devel@lists.ath9k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.