Re: [PATCH] ARM: architected timers: Mark the clockevent with the C3_STOP feature

[Marc Zyngier <marc.zyngier@arm.com>]

On 04/07/12 10:54, Santosh Shilimkar wrote:
> ARM arch timers stop in low power state and hence can not wakeup CPUs in
> deeper idle states when used as cloc event devices. Marking these clock event
> devices with C3_STOP so that during lowpower states, the tick is managed by
> wakeup capable broadcast timer.
> 
> Cc: Marc Zyngier <marc.zyngier@arm.com>
> Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>

Hi Santosh,

I already have queued an identical patch from Lorenzo.
Thanks for reminder anyway!

	M.

> ---
>  arch/arm/kernel/arch_timer.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/kernel/arch_timer.c b/arch/arm/kernel/arch_timer.c
> index dd58035..df44c8c 100644
> --- a/arch/arm/kernel/arch_timer.c
> +++ b/arch/arm/kernel/arch_timer.c
> @@ -137,7 +137,7 @@ static int __cpuinit arch_timer_setup(struct clock_event_device *clk)
>  	/* Be safe... */
>  	arch_timer_disable();
>  
> -	clk->features = CLOCK_EVT_FEAT_ONESHOT;
> +	clk->features = CLOCK_EVT_FEAT_ONESHOT | CLOCK_EVT_FEAT_C3STOP;
>  	clk->name = "arch_sys_timer";
>  	clk->rating = 450;
>  	clk->set_mode = arch_timer_set_mode;


-- 
Jazz is not dead. It just smells funny...