From: Paolo Bonzini <pbonzini@redhat.com>
To: mc@linux.vnet.ibm.com
Cc: stefanha@linux.vnet.ibm.com, linux-scsi@vger.kernel.org,
senwang@linux.vnet.ibm.com, zwanp@cn.ibm.com,
linuxram@us.ibm.com, linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH v2] virtio-scsi: hotplug support for virtio-scsi
Date: Wed, 04 Jul 2012 14:35:04 +0200 [thread overview]
Message-ID: <4FF43878.3000207@redhat.com> (raw)
In-Reply-To: <20120704041124.Horde.MN5WeZir309P8-qsGUCj3vA@imap.linux.ibm.com>
Il 04/07/2012 10:11, mc@linux.vnet.ibm.com ha scritto:
>>>
>>>
>>> Signed-off-by: Cong Meng <mc@linux.vnet.ibm.com>
>>> Signed-off-by: Sen Wang <senwang@linux.vnet.ibm.com>
>>
>> The SoB lines are swapped. Otherwise looks good. Since you have to
>> respin, please add dropped event support too, it shouldn't be hard.
>
> What does "The SoB lines are swapped" mean? should the changelog be
> placed after SoB lines?
No, the patch sender should be the last SoB line. Sen Wang should hence
come before you, not after.
Paolo
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: mc@linux.vnet.ibm.com
Cc: stefanha@linux.vnet.ibm.com, linuxram@us.ibm.com,
senwang@linux.vnet.ibm.com, zwanp@cn.ibm.com,
virtualization@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: [PATCH v2] virtio-scsi: hotplug support for virtio-scsi
Date: Wed, 04 Jul 2012 14:35:04 +0200 [thread overview]
Message-ID: <4FF43878.3000207@redhat.com> (raw)
In-Reply-To: <20120704041124.Horde.MN5WeZir309P8-qsGUCj3vA@imap.linux.ibm.com>
Il 04/07/2012 10:11, mc@linux.vnet.ibm.com ha scritto:
>>>
>>>
>>> Signed-off-by: Cong Meng <mc@linux.vnet.ibm.com>
>>> Signed-off-by: Sen Wang <senwang@linux.vnet.ibm.com>
>>
>> The SoB lines are swapped. Otherwise looks good. Since you have to
>> respin, please add dropped event support too, it shouldn't be hard.
>
> What does "The SoB lines are swapped" mean? should the changelog be
> placed after SoB lines?
No, the patch sender should be the last SoB line. Sen Wang should hence
come before you, not after.
Paolo
next prev parent reply other threads:[~2012-07-04 12:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-03 5:41 [PATCH v2] virtio-scsi: hotplug support for virtio-scsi Cong Meng
2012-07-03 5:41 ` Cong Meng
2012-07-03 11:50 ` Paolo Bonzini
2012-07-03 11:50 ` Paolo Bonzini
2012-07-04 8:11 ` mc
2012-07-04 12:35 ` Paolo Bonzini [this message]
2012-07-04 12:35 ` Paolo Bonzini
2012-07-04 8:11 ` mc
2012-07-04 6:10 ` Zhi Yong Wu
2012-07-04 6:10 ` Zhi Yong Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FF43878.3000207@redhat.com \
--to=pbonzini@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxram@us.ibm.com \
--cc=mc@linux.vnet.ibm.com \
--cc=senwang@linux.vnet.ibm.com \
--cc=stefanha@linux.vnet.ibm.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=zwanp@cn.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.