From: pgaikwad@nvidia.com (Prashant Gaikwad)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clk: Fix cached parent ptrs allocation
Date: Thu, 5 Jul 2012 06:40:46 +0530 [thread overview]
Message-ID: <4FF4E996.7010003@nvidia.com> (raw)
In-Reply-To: <1341407737-1016-1-git-send-email-pgaikwad@nvidia.com>
On Wednesday 04 July 2012 06:45 PM, Prashant Gaikwad wrote:
> Compiler optimizes code someway that even if clk->parents
> is not NULL it tries to allocate parents array. Change the
> condition so that compiler does not optimize it in wrong
> way.
>
> Also, initialize i to num_parents to make sure parent
> is searched using parent name if parents is NULL.
>
> Signed-off-by: Prashant Gaikwad<pgaikwad@nvidia.com>
> ---
> Mike,
>
> There could be some other way to fix problem. I have not
> debugged it in detail but I think this simple change should do.
Mike,
Please ignore this patch as Rajendra has already sent patch to fix.
http://git.linaro.org/gitweb?p=people/mturquette/linux.git;a=commitdiff;h=863b13271f1608ab3af6f7a371047d9a66693e38
> drivers/clk/clk.c | 10 +++++-----
> 1 files changed, 5 insertions(+), 5 deletions(-)
>
WARNING: multiple messages have this Message-ID (diff)
From: Prashant Gaikwad <pgaikwad@nvidia.com>
To: Prashant Gaikwad <pgaikwad@nvidia.com>
Cc: "mturquette@ti.com" <mturquette@ti.com>,
"swarren@wwwdotorg.org" <swarren@wwwdotorg.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] clk: Fix cached parent ptrs allocation
Date: Thu, 5 Jul 2012 06:40:46 +0530 [thread overview]
Message-ID: <4FF4E996.7010003@nvidia.com> (raw)
In-Reply-To: <1341407737-1016-1-git-send-email-pgaikwad@nvidia.com>
On Wednesday 04 July 2012 06:45 PM, Prashant Gaikwad wrote:
> Compiler optimizes code someway that even if clk->parents
> is not NULL it tries to allocate parents array. Change the
> condition so that compiler does not optimize it in wrong
> way.
>
> Also, initialize i to num_parents to make sure parent
> is searched using parent name if parents is NULL.
>
> Signed-off-by: Prashant Gaikwad<pgaikwad@nvidia.com>
> ---
> Mike,
>
> There could be some other way to fix problem. I have not
> debugged it in detail but I think this simple change should do.
Mike,
Please ignore this patch as Rajendra has already sent patch to fix.
http://git.linaro.org/gitweb?p=people/mturquette/linux.git;a=commitdiff;h=863b13271f1608ab3af6f7a371047d9a66693e38
> drivers/clk/clk.c | 10 +++++-----
> 1 files changed, 5 insertions(+), 5 deletions(-)
>
next prev parent reply other threads:[~2012-07-05 1:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-04 13:15 [PATCH] clk: Fix cached parent ptrs allocation Prashant Gaikwad
2012-07-04 13:15 ` Prashant Gaikwad
2012-07-05 1:10 ` Prashant Gaikwad [this message]
2012-07-05 1:10 ` Prashant Gaikwad
2012-07-05 16:07 ` Stephen Warren
2012-07-05 16:07 ` Stephen Warren
2012-07-05 17:21 ` Prashant Gaikwad
2012-07-05 17:21 ` Prashant Gaikwad
2012-07-05 18:44 ` Stephen Warren
2012-07-05 18:44 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FF4E996.7010003@nvidia.com \
--to=pgaikwad@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.