From: Timur Tabi <b04825@freescale.com>
To: Zhao Chenhui <chenhui.zhao@freescale.com>
Cc: Wood Scott-B07421 <B07421@freescale.com>,
Li Yang-R58472 <r58472@freescale.com>,
Zhao Chenhui-B35336 <B35336@freescale.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH v7 1/5] powerpc/85xx: implement hardware timebase sync
Date: Thu, 5 Jul 2012 10:30:49 -0500 [thread overview]
Message-ID: <4FF5B329.9090005@freescale.com> (raw)
In-Reply-To: <20120705102529.GA7982@localhost.localdomain>
Zhao Chenhui wrote:
> If the guts node is missing, this code snippet will be skipped. If the guts node is existed,
> the return value of of_iomap(), namely guts, will be tested. If it is NULL, it shows
> that there is error in dts, or the ioremap() in of_iomap() failed. I think
> these errors are fatal errors, so I print an error info and return.
Ok, I see your point now. I'm concerned about what might happen if
someone else updates mpc85xx_smp_init() in the future, but there's nothing
actually wrong with your patch today.
--
Timur Tabi
Linux kernel developer at Freescale
WARNING: multiple messages have this Message-ID (diff)
From: Timur Tabi <b04825@freescale.com>
To: Zhao Chenhui <chenhui.zhao@freescale.com>
Cc: Zhao Chenhui-B35336 <B35336@freescale.com>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
Wood Scott-B07421 <B07421@freescale.com>,
"galak@kernel.crashing.org" <galak@kernel.crashing.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Li Yang-R58472 <r58472@freescale.com>, <leoli@freescale.com>
Subject: Re: [PATCH v7 1/5] powerpc/85xx: implement hardware timebase sync
Date: Thu, 5 Jul 2012 10:30:49 -0500 [thread overview]
Message-ID: <4FF5B329.9090005@freescale.com> (raw)
In-Reply-To: <20120705102529.GA7982@localhost.localdomain>
Zhao Chenhui wrote:
> If the guts node is missing, this code snippet will be skipped. If the guts node is existed,
> the return value of of_iomap(), namely guts, will be tested. If it is NULL, it shows
> that there is error in dts, or the ioremap() in of_iomap() failed. I think
> these errors are fatal errors, so I print an error info and return.
Ok, I see your point now. I'm concerned about what might happen if
someone else updates mpc85xx_smp_init() in the future, but there's nothing
actually wrong with your patch today.
--
Timur Tabi
Linux kernel developer at Freescale
next prev parent reply other threads:[~2012-07-05 15:31 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-03 10:21 [PATCH v7 1/5] powerpc/85xx: implement hardware timebase sync Zhao Chenhui
2012-07-03 10:21 ` Zhao Chenhui
2012-07-03 10:21 ` [PATCH v7 2/5] powerpc/85xx: add HOTPLUG_CPU support Zhao Chenhui
2012-07-03 10:21 ` Zhao Chenhui
2012-07-13 12:15 ` Kumar Gala
2012-07-13 12:15 ` Kumar Gala
2012-07-17 11:39 ` Zhao Chenhui-B35336
2012-07-17 11:39 ` Zhao Chenhui-B35336
2012-07-03 12:46 ` [PATCH v7 1/5] powerpc/85xx: implement hardware timebase sync Tabi Timur-B04825
2012-07-03 12:46 ` Tabi Timur-B04825
2012-07-04 3:14 ` Zhao Chenhui
2012-07-04 3:14 ` Zhao Chenhui
2012-07-04 3:17 ` Tabi Timur-B04825
2012-07-04 3:17 ` Tabi Timur-B04825
2012-07-04 3:45 ` Zhao Chenhui
2012-07-04 3:45 ` Zhao Chenhui
2012-07-04 15:19 ` Tabi Timur-B04825
2012-07-04 15:19 ` Tabi Timur-B04825
2012-07-05 10:25 ` Zhao Chenhui
2012-07-05 10:25 ` Zhao Chenhui
2012-07-05 15:30 ` Timur Tabi [this message]
2012-07-05 15:30 ` Timur Tabi
2012-07-05 17:11 ` Scott Wood
2012-07-05 17:11 ` Scott Wood
2012-07-05 15:31 ` Tabi Timur-B04825
2012-07-05 15:31 ` Tabi Timur-B04825
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FF5B329.9090005@freescale.com \
--to=b04825@freescale.com \
--cc=B07421@freescale.com \
--cc=B35336@freescale.com \
--cc=chenhui.zhao@freescale.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=r58472@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.