From: Stephen Warren <swarren@wwwdotorg.org>
To: Laxman Dewangan <ldewangan@nvidia.com>
Cc: broonie@opensource.wolfsonmicro.com, grant.likely@secretlab.ca,
rob.herring@calxeda.com, lrg@ti.com, swarren@nvidia.com,
sameo@linux.intel.com, linux-kernel@vger.kernel.org,
devicetree-discuss@lists.ozlabs.org
Subject: Re: [PATCH] regulator: tps65910: add support for input supply
Date: Thu, 05 Jul 2012 13:09:30 -0600 [thread overview]
Message-ID: <4FF5E66A.6010108@wwwdotorg.org> (raw)
In-Reply-To: <1341497004-23537-1-git-send-email-ldewangan@nvidia.com>
On 07/05/2012 08:03 AM, Laxman Dewangan wrote:
> There is multiple voltage input pins on device which
> takes the voltage input for different voltage regulator.
> Support to configure the voltage input supplied by
> different regulator for each regulators.
>
> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
A couple nit-picky comments below:
> diff --git a/Documentation/devicetree/bindings/mfd/tps65910.txt b/Documentation/devicetree/bindings/mfd/tps65910.txt
> +- vin-xxx-supply: Input voltage supply regulator.
It'd be nice to name these simply xxx-supply; the "vin-" seems redundant.
> + Missing of these properties will be assume as there is no parent regulator
> + for that input pins and always powered on.
> + The valid input supply properties are:
> + tps65910:
> + vin-vcc7-supply: VRTC input.
> + vin-vccio-supply: VIO input.
> + vin-vcc1-supply: VDD1 input.
> + vin-vcc2-supply: VDD2 input.
> + vin-vcc6-supply: VDIG1 and VDIG2 input.
> + vin-vcc5-supply: VPLL and VDAC input.
> + vin-vcc4-supply: VAUX1 and VAUX2 input.
> + vin-vcc3-supply: VAUX33 and VMMC input.
> + tps65911:
> + vin-vcc7-supply: VRTC input.
> + vin-vcc1-supply: VDD1 input.
> + vin-vcc2-supply: VDD2 input.
> + vin-vccio-supply: VIO input.
> + vin-vcc6-supply: LDO1 and LDO2 input.
> + vin-vcc5-supply: LDO3 and LDO4 input.
> + vin-vcc4-supply: LDO5 input.
> + vin-vcc3-supply: LDO6, LDO7 and LDO8 input.
It'd be nice to sort these lists of names so they appear in some
discernible order.
next prev parent reply other threads:[~2012-07-05 19:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-05 14:03 [PATCH] regulator: tps65910: add support for input supply Laxman Dewangan
2012-07-05 14:03 ` Laxman Dewangan
2012-07-05 19:09 ` Stephen Warren [this message]
2012-07-05 19:11 ` Mark Brown
2012-07-05 19:17 ` Stephen Warren
2012-07-06 6:45 ` Laxman Dewangan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FF5E66A.6010108@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=rob.herring@calxeda.com \
--cc=sameo@linux.intel.com \
--cc=swarren@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.