From: Laxman Dewangan <ldewangan@nvidia.com>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>,
"grant.likely@secretlab.ca" <grant.likely@secretlab.ca>,
"rob.herring@calxeda.com" <rob.herring@calxeda.com>,
"lrg@ti.com" <lrg@ti.com>, Stephen Warren <swarren@nvidia.com>,
"sameo@linux.intel.com" <sameo@linux.intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree-discuss@lists.ozlabs.org"
<devicetree-discuss@lists.ozlabs.org>
Subject: Re: [PATCH] regulator: tps65910: add support for input supply
Date: Fri, 6 Jul 2012 12:15:12 +0530 [thread overview]
Message-ID: <4FF68978.80703@nvidia.com> (raw)
In-Reply-To: <4FF5E857.7020204@wwwdotorg.org>
On Friday 06 July 2012 12:47 AM, Stephen Warren wrote:
> On 07/05/2012 01:11 PM, Mark Brown wrote:
>> On Thu, Jul 05, 2012 at 01:09:30PM -0600, Stephen Warren wrote:
>>> On 07/05/2012 08:03 AM, Laxman Dewangan wrote:
>>>> +- vin-xxx-supply: Input voltage supply regulator.
>>> It'd be nice to name these simply xxx-supply; the "vin-" seems
>>> redundant.
>> I suspect the pin is named vin_supply (ie, vin subscript supply) in
>> the datasheet so this is idiomatic.
> That's certainly true on some of the PMICs we use, but not this one
> according to the datasheet I looked at.
As per datasheet of tps65910 and tps65911, the prefix "vin" is not
there. I took from the other patch discussion.
I will remove it and then send new patch.
prev parent reply other threads:[~2012-07-06 6:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-05 14:03 [PATCH] regulator: tps65910: add support for input supply Laxman Dewangan
2012-07-05 14:03 ` Laxman Dewangan
2012-07-05 19:09 ` Stephen Warren
2012-07-05 19:11 ` Mark Brown
2012-07-05 19:17 ` Stephen Warren
2012-07-06 6:45 ` Laxman Dewangan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FF68978.80703@nvidia.com \
--to=ldewangan@nvidia.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=rob.herring@calxeda.com \
--cc=sameo@linux.intel.com \
--cc=swarren@nvidia.com \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.