From: Wang Sheng-Hui <shhuiw@gmail.com>
To: Theodore Ts'o <tytso@mit.edu>,
Andreas Dilger <adilger.kernel@dilger.ca>,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 1/2] ext4: fix the comment in ext4_ext_insert_extent for ext4_ext_try_to_merge in extents.c
Date: Fri, 06 Jul 2012 14:26:25 +0800 [thread overview]
Message-ID: <4FF68511.9050207@gmail.com> (raw)
The left and right extents merge is done by
ext4_ext_try_to_merge. No specific left/right
fun calls any more.
Signed-off-by: Wang Sheng-Hui <shhuiw@gmail.com>
---
fs/ext4/extents.c | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index 5207b7b..6c2a37d 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -1891,12 +1891,10 @@ has_space:
nearex->ee_len = newext->ee_len;
merge:
- /* try to merge extents to the right */
+ /* try to merge extents to the neighbours */
if (!(flag & EXT4_GET_BLOCKS_PRE_IO))
ext4_ext_try_to_merge(inode, path, nearex);
- /* try to merge extents to the left */
WARNING: multiple messages have this Message-ID (diff)
From: Wang Sheng-Hui <shhuiw@gmail.com>
To: "Theodore Ts'o" <tytso@mit.edu>,
Andreas Dilger <adilger.kernel@dilger.ca>,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 1/2] ext4: fix the comment in ext4_ext_insert_extent for ext4_ext_try_to_merge in extents.c
Date: Fri, 06 Jul 2012 14:26:25 +0800 [thread overview]
Message-ID: <4FF68511.9050207@gmail.com> (raw)
The left and right extents merge is done by
ext4_ext_try_to_merge. No specific left/right
fun calls any more.
Signed-off-by: Wang Sheng-Hui <shhuiw@gmail.com>
---
fs/ext4/extents.c | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index 5207b7b..6c2a37d 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -1891,12 +1891,10 @@ has_space:
nearex->ee_len = newext->ee_len;
merge:
- /* try to merge extents to the right */
+ /* try to merge extents to the neighbours */
if (!(flag & EXT4_GET_BLOCKS_PRE_IO))
ext4_ext_try_to_merge(inode, path, nearex);
- /* try to merge extents to the left */
-
/* time to correct all indexes above */
err = ext4_ext_correct_indexes(handle, inode, path);
if (err)
--
1.7.1
next reply other threads:[~2012-07-06 6:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-06 6:26 Wang Sheng-Hui [this message]
2012-07-06 6:26 ` [PATCH 1/2] ext4: fix the comment in ext4_ext_insert_extent for ext4_ext_try_to_merge in extents.c Wang Sheng-Hui
2012-07-07 15:15 ` Zheng Liu
2012-07-08 10:38 ` Wang Sheng-Hui
2012-07-08 10:38 ` Wang Sheng-Hui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FF68511.9050207@gmail.com \
--to=shhuiw@gmail.com \
--cc=adilger.kernel@dilger.ca \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.