From: Glauber Costa <glommer@parallels.com>
To: Li Zhong <zhong@linux.vnet.ibm.com>
Cc: Christoph Lameter <cl@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
Pekka Enberg <penberg@kernel.org>, linux-mm <linux-mm@kvack.org>,
Paul Mackerras <paulus@samba.org>, Matt Mackall <mpm@selenic.com>,
PowerPC email list <linuxppc-dev@lists.ozlabs.org>,
Wanlong Gao <gaowanlong@cn.fujitsu.com>
Subject: Re: [PATCH SLAB 1/2 v3] duplicate the cache name in SLUB's saved_alias list, SLAB, and SLOB
Date: Fri, 6 Jul 2012 13:04:17 +0400 [thread overview]
Message-ID: <4FF6AA11.2010303@parallels.com> (raw)
In-Reply-To: <1341561286.24895.9.camel@ThinkPad-T420>
On 07/06/2012 11:54 AM, Li Zhong wrote:
> + if (!c && lname)
> + kfree(lname);
> +
kfree can still be validly called with a NULL argument. No need for the
lname in the conditional.
WARNING: multiple messages have this Message-ID (diff)
From: Glauber Costa <glommer@parallels.com>
To: Li Zhong <zhong@linux.vnet.ibm.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Christoph Lameter <cl@linux-foundation.org>,
Pekka Enberg <penberg@kernel.org>, Matt Mackall <mpm@selenic.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>, linux-mm <linux-mm@kvack.org>,
PowerPC email list <linuxppc-dev@lists.ozlabs.org>,
Wanlong Gao <gaowanlong@cn.fujitsu.com>
Subject: Re: [PATCH SLAB 1/2 v3] duplicate the cache name in SLUB's saved_alias list, SLAB, and SLOB
Date: Fri, 6 Jul 2012 13:04:17 +0400 [thread overview]
Message-ID: <4FF6AA11.2010303@parallels.com> (raw)
In-Reply-To: <1341561286.24895.9.camel@ThinkPad-T420>
On 07/06/2012 11:54 AM, Li Zhong wrote:
> + if (!c && lname)
> + kfree(lname);
> +
kfree can still be validly called with a NULL argument. No need for the
lname in the conditional.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Glauber Costa <glommer@parallels.com>
To: Li Zhong <zhong@linux.vnet.ibm.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Christoph Lameter <cl@linux-foundation.org>,
Pekka Enberg <penberg@kernel.org>, Matt Mackall <mpm@selenic.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>, linux-mm <linux-mm@kvack.org>,
PowerPC email list <linuxppc-dev@lists.ozlabs.org>,
Wanlong Gao <gaowanlong@cn.fujitsu.com>
Subject: Re: [PATCH SLAB 1/2 v3] duplicate the cache name in SLUB's saved_alias list, SLAB, and SLOB
Date: Fri, 6 Jul 2012 13:04:17 +0400 [thread overview]
Message-ID: <4FF6AA11.2010303@parallels.com> (raw)
In-Reply-To: <1341561286.24895.9.camel@ThinkPad-T420>
On 07/06/2012 11:54 AM, Li Zhong wrote:
> + if (!c && lname)
> + kfree(lname);
> +
kfree can still be validly called with a NULL argument. No need for the
lname in the conditional.
next prev parent reply other threads:[~2012-07-06 9:07 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-06 7:54 [PATCH SLAB 1/2 v3] duplicate the cache name in SLUB's saved_alias list, SLAB, and SLOB Li Zhong
2012-07-06 7:54 ` Li Zhong
2012-07-06 7:54 ` Li Zhong
2012-07-06 7:57 ` [PATCH powerpc 2/2 v3] kfree the cache name of pgtable cache Li Zhong
2012-07-06 7:57 ` Li Zhong
2012-07-06 7:57 ` Li Zhong
2012-07-06 9:04 ` Glauber Costa [this message]
2012-07-06 9:04 ` [PATCH SLAB 1/2 v3] duplicate the cache name in SLUB's saved_alias list, SLAB, and SLOB Glauber Costa
2012-07-06 9:04 ` Glauber Costa
2012-07-06 13:56 ` Christoph Lameter
2012-07-06 13:56 ` Christoph Lameter
2012-07-06 13:56 ` Christoph Lameter
2012-07-09 2:42 ` Li Zhong
2012-07-09 2:42 ` Li Zhong
2012-07-09 2:42 ` Li Zhong
2012-07-09 14:01 ` Christoph Lameter
2012-07-09 14:01 ` Christoph Lameter
2012-07-09 14:01 ` Christoph Lameter
2012-07-10 1:35 ` Li Zhong
2012-07-10 1:35 ` Li Zhong
2012-07-10 1:35 ` Li Zhong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FF6AA11.2010303@parallels.com \
--to=glommer@parallels.com \
--cc=cl@linux-foundation.org \
--cc=gaowanlong@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpm@selenic.com \
--cc=paulus@samba.org \
--cc=penberg@kernel.org \
--cc=zhong@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.