* [PATCH] PM / IPMI: Remove empty legacy PCI PM callbacks
@ 2012-07-06 20:02 Rafael J. Wysocki
2012-07-06 20:50 ` Corey Minyard
0 siblings, 1 reply; 2+ messages in thread
From: Rafael J. Wysocki @ 2012-07-06 20:02 UTC (permalink / raw)
To: Linux PM mailing list; +Cc: LKML, Corey Minyard, openipmi-developer
From: Rafael J. Wysocki <rjw@sisk.pl>
The legacy PM callbacks provided by the IPMI PCI driver are
empty routines returning 0, so they can be safely dropped.
Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
---
drivers/char/ipmi/ipmi_si_intf.c | 16 ----------------
1 file changed, 16 deletions(-)
Index: linux/drivers/char/ipmi/ipmi_si_intf.c
===================================================================
--- linux.orig/drivers/char/ipmi/ipmi_si_intf.c
+++ linux/drivers/char/ipmi/ipmi_si_intf.c
@@ -2503,18 +2503,6 @@ static void __devexit ipmi_pci_remove(st
cleanup_one_si(info);
}
-#ifdef CONFIG_PM
-static int ipmi_pci_suspend(struct pci_dev *pdev, pm_message_t state)
-{
- return 0;
-}
-
-static int ipmi_pci_resume(struct pci_dev *pdev)
-{
- return 0;
-}
-#endif
-
static struct pci_device_id ipmi_pci_devices[] = {
{ PCI_DEVICE(PCI_HP_VENDOR_ID, PCI_MMC_DEVICE_ID) },
{ PCI_DEVICE_CLASS(PCI_ERMC_CLASSCODE, PCI_ERMC_CLASSCODE_MASK) },
@@ -2527,10 +2515,6 @@ static struct pci_driver ipmi_pci_driver
.id_table = ipmi_pci_devices,
.probe = ipmi_pci_probe,
.remove = __devexit_p(ipmi_pci_remove),
-#ifdef CONFIG_PM
- .suspend = ipmi_pci_suspend,
- .resume = ipmi_pci_resume,
-#endif
};
#endif /* CONFIG_PCI */
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] PM / IPMI: Remove empty legacy PCI PM callbacks
2012-07-06 20:02 [PATCH] PM / IPMI: Remove empty legacy PCI PM callbacks Rafael J. Wysocki
@ 2012-07-06 20:50 ` Corey Minyard
0 siblings, 0 replies; 2+ messages in thread
From: Corey Minyard @ 2012-07-06 20:50 UTC (permalink / raw)
To: Rafael J. Wysocki; +Cc: Linux PM mailing list, LKML, openipmi-developer
Looks fine to me.
Acked-by: Corey Minyard <cminyard@mvista.com>
On 07/06/2012 03:02 PM, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rjw@sisk.pl>
>
> The legacy PM callbacks provided by the IPMI PCI driver are
> empty routines returning 0, so they can be safely dropped.
>
> Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
> ---
> drivers/char/ipmi/ipmi_si_intf.c | 16 ----------------
> 1 file changed, 16 deletions(-)
>
> Index: linux/drivers/char/ipmi/ipmi_si_intf.c
> ===================================================================
> --- linux.orig/drivers/char/ipmi/ipmi_si_intf.c
> +++ linux/drivers/char/ipmi/ipmi_si_intf.c
> @@ -2503,18 +2503,6 @@ static void __devexit ipmi_pci_remove(st
> cleanup_one_si(info);
> }
>
> -#ifdef CONFIG_PM
> -static int ipmi_pci_suspend(struct pci_dev *pdev, pm_message_t state)
> -{
> - return 0;
> -}
> -
> -static int ipmi_pci_resume(struct pci_dev *pdev)
> -{
> - return 0;
> -}
> -#endif
> -
> static struct pci_device_id ipmi_pci_devices[] = {
> { PCI_DEVICE(PCI_HP_VENDOR_ID, PCI_MMC_DEVICE_ID) },
> { PCI_DEVICE_CLASS(PCI_ERMC_CLASSCODE, PCI_ERMC_CLASSCODE_MASK) },
> @@ -2527,10 +2515,6 @@ static struct pci_driver ipmi_pci_driver
> .id_table = ipmi_pci_devices,
> .probe = ipmi_pci_probe,
> .remove = __devexit_p(ipmi_pci_remove),
> -#ifdef CONFIG_PM
> - .suspend = ipmi_pci_suspend,
> - .resume = ipmi_pci_resume,
> -#endif
> };
> #endif /* CONFIG_PCI */
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-07-06 20:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-06 20:02 [PATCH] PM / IPMI: Remove empty legacy PCI PM callbacks Rafael J. Wysocki
2012-07-06 20:50 ` Corey Minyard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.