[PATCH 1/2]dhclient initqueue hook fix

[PATCH 1/2]dhclient initqueue hook fix

[Dave Young]

dhclient initqueue hook fix

setup_net is scheduled in initqueue, sometimes it does not get chance to run
So the default route will not be set properly

Add a check in initqueue/finished to resolve this issue.

Signed-off-by: Dave Young <dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
---
 modules.d/40network/dhclient-script.sh |    2 ++
 1 file changed, 2 insertions(+)

--- dracut.orig/modules.d/40network/dhclient-script.sh
+++ dracut/modules.d/40network/dhclient-script.sh
@@ -81,9 +81,11 @@ case $reason in
             echo "setup_net $netif"
             echo "source_hook initqueue/online $netif"
             [ -e /tmp/net.$netif.manualup ] || echo "/sbin/netroot $netif"
+            echo "> /tmp/setup_net_$netif.ok"
             echo "rm -f $hookdir/initqueue/setup_net_$netif.sh"
         } > $hookdir/initqueue/setup_net_$netif.sh
 
+        echo "[ -f /tmp/setup_net_$netif.ok ]" > $hookdir/initqueue/finished/dhclient-$netif.sh
         >/tmp/net.$netif.up
         ;;
     *) echo "dhcp: $reason";;

Re: [PATCH 1/2]dhclient initqueue hook fix

[Dave Young]

On 07/09/2012 02:56 PM, Dave Young wrote:

> dhclient initqueue hook fix
> 
> setup_net is scheduled in initqueue, sometimes it does not get chance to run
> So the default route will not be set properly
> 
> Add a check in initqueue/finished to resolve this issue.


Hi, harald

Could you review this patch?
I sent it several days ago, it went into my mailbox but seems it did not
get in the list archive..


> 
> Signed-off-by: Dave Young <dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> ---
>  modules.d/40network/dhclient-script.sh |    2 ++
>  1 file changed, 2 insertions(+)
> 
> --- dracut.orig/modules.d/40network/dhclient-script.sh
> +++ dracut/modules.d/40network/dhclient-script.sh
> @@ -81,9 +81,11 @@ case $reason in
>              echo "setup_net $netif"
>              echo "source_hook initqueue/online $netif"
>              [ -e /tmp/net.$netif.manualup ] || echo "/sbin/netroot $netif"
> +            echo "> /tmp/setup_net_$netif.ok"
>              echo "rm -f $hookdir/initqueue/setup_net_$netif.sh"
>          } > $hookdir/initqueue/setup_net_$netif.sh
>  
> +        echo "[ -f /tmp/setup_net_$netif.ok ]" > $hookdir/initqueue/finished/dhclient-$netif.sh
>          >/tmp/net.$netif.up
>          ;;
>      *) echo "dhcp: $reason";;
> --
> To unsubscribe from this list: send the line "unsubscribe initramfs" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html



-- 
Thanks
Dave

Re: [PATCH 1/2]dhclient initqueue hook fix

[Dave Young]

On 07/09/2012 02:56 PM, Dave Young wrote:

> dhclient initqueue hook fix
> 
> setup_net is scheduled in initqueue, sometimes it does not get chance to run
> So the default route will not be set properly
> 
> Add a check in initqueue/finished to resolve this issue.


Hi, harald. Could you give comment for this patch?

This might be only related to manually bring up network. I'm not sure
though.

> 
> Signed-off-by: Dave Young <dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> ---
>  modules.d/40network/dhclient-script.sh |    2 ++
>  1 file changed, 2 insertions(+)
> 
> --- dracut.orig/modules.d/40network/dhclient-script.sh
> +++ dracut/modules.d/40network/dhclient-script.sh
> @@ -81,9 +81,11 @@ case $reason in
>              echo "setup_net $netif"
>              echo "source_hook initqueue/online $netif"
>              [ -e /tmp/net.$netif.manualup ] || echo "/sbin/netroot $netif"
> +            echo "> /tmp/setup_net_$netif.ok"
>              echo "rm -f $hookdir/initqueue/setup_net_$netif.sh"
>          } > $hookdir/initqueue/setup_net_$netif.sh
>  
> +        echo "[ -f /tmp/setup_net_$netif.ok ]" > $hookdir/initqueue/finished/dhclient-$netif.sh
>          >/tmp/net.$netif.up
>          ;;
>      *) echo "dhcp: $reason";;
> --
> To unsubscribe from this list: send the line "unsubscribe initramfs" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html



-- 
Thanks
Dave

Re: [PATCH 1/2]dhclient initqueue hook fix

[Harald Hoyer]

Am 11.07.2012 10:14, schrieb Dave Young:
> On 07/09/2012 02:56 PM, Dave Young wrote:
> 
>> dhclient initqueue hook fix
>>
>> setup_net is scheduled in initqueue, sometimes it does not get chance to run
>> So the default route will not be set properly
>>
>> Add a check in initqueue/finished to resolve this issue.
> 
> 
> Hi, harald. Could you give comment for this patch?
> 
> This might be only related to manually bring up network. I'm not sure
> though.


Already pushed to upstream git

Re: [PATCH 1/2]dhclient initqueue hook fix

[Dave Young]

On 07/11/2012 05:55 PM, Harald Hoyer wrote:

> Am 11.07.2012 10:14, schrieb Dave Young:
>> On 07/09/2012 02:56 PM, Dave Young wrote:
>>
>>> dhclient initqueue hook fix
>>>
>>> setup_net is scheduled in initqueue, sometimes it does not get chance to run
>>> So the default route will not be set properly
>>>
>>> Add a check in initqueue/finished to resolve this issue.
>>
>>
>> Hi, harald. Could you give comment for this patch?
>>
>> This might be only related to manually bring up network. I'm not sure
>> though.
> 
> 
> Already pushed to upstream git


Thanks, should check the git before ask..

-- 
Thanks
Dave