From: Gerd Hoffmann <kraxel@redhat.com>
To: Alexander Graf <agraf@suse.de>
Cc: qemu-devel qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] configure: fix libsmartcard_nss compile check
Date: Mon, 09 Jul 2012 15:29:07 +0200 [thread overview]
Message-ID: <4FFADCA3.7060101@redhat.com> (raw)
In-Reply-To: <1341835600-2620-1-git-send-email-agraf@suse.de>
On 07/09/12 14:06, Alexander Graf wrote:
> When just calling ./configure on my box, I always ran into the same issue:
>
> In file included from /usr/include/nss3/pkcs11t.h:1780,
> from /usr/include/nss3/keythi.h:41,
> from /usr/include/nss3/keyt.h:41,
> from /usr/include/nss3/pk11pub.h:43,
> from libcacard/vcard_emul_nss.c:21:
> /usr/include/nss3/pkcs11n.h:365:26: error: "__GNUC_MINOR" is not defined
>
> This is a bug in nss3. But why didn't configure bail out of the feature
> if it doesn't even compile? Because this really is just a warning, not an
> error. But configure builds its test program without -Werror, while we do
> build our sources with -Werror by default.
>
> Force the check to also use -Werror. This fixes the default build for me again.
Good idea, but shouldn't we do that
(a) for all compile tests and
(b) only with --enable-werror
?
cheers,
Gerd
next prev parent reply other threads:[~2012-07-09 13:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-09 12:06 [Qemu-devel] [PATCH] configure: fix libsmartcard_nss compile check Alexander Graf
2012-07-09 13:26 ` Andreas Färber
2012-07-09 13:29 ` Gerd Hoffmann [this message]
2012-07-09 13:30 ` Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FFADCA3.7060101@redhat.com \
--to=kraxel@redhat.com \
--cc=agraf@suse.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.