* [PATCH 0/3] Add -cpu best support @ 2012-07-09 12:10 ` Alexander Graf 0 siblings, 0 replies; 12+ messages in thread From: Alexander Graf @ 2012-07-09 12:10 UTC (permalink / raw) To: qemu-devel qemu-devel Cc: KVM list, Ryan Harper, Anthony Liguori, Andreas Färber, Avi Kivity This patch set implements support for a sane default CPU type, that plays the middle ground between -cpu host (unmanagable test matrix) and -cpu qemu64 (breaks assumptions wrt family/model numbers). It also makes it the default for -M pc, so that users who don't specify a specific CPU type on the command line always get a fast, yet reliable CPU type chosen for them. For a detailed description, please see patch 1/3. Alexander Graf (3): KVM: Add new -cpu best KVM: Use -cpu best as default on x86 i386: KVM: List -cpu host and best in -cpu ? hw/pc_piix.c | 34 +++++++++++++++++----- target-i386/cpu.c | 79 +++++++++++++++++++++++++++++++++++++++++++++++++++-- 2 files changed, 102 insertions(+), 11 deletions(-) ^ permalink raw reply [flat|nested] 12+ messages in thread
* [Qemu-devel] [PATCH 0/3] Add -cpu best support @ 2012-07-09 12:10 ` Alexander Graf 0 siblings, 0 replies; 12+ messages in thread From: Alexander Graf @ 2012-07-09 12:10 UTC (permalink / raw) To: qemu-devel qemu-devel Cc: Avi Kivity, Ryan Harper, Anthony Liguori, KVM list, Andreas Färber This patch set implements support for a sane default CPU type, that plays the middle ground between -cpu host (unmanagable test matrix) and -cpu qemu64 (breaks assumptions wrt family/model numbers). It also makes it the default for -M pc, so that users who don't specify a specific CPU type on the command line always get a fast, yet reliable CPU type chosen for them. For a detailed description, please see patch 1/3. Alexander Graf (3): KVM: Add new -cpu best KVM: Use -cpu best as default on x86 i386: KVM: List -cpu host and best in -cpu ? hw/pc_piix.c | 34 +++++++++++++++++----- target-i386/cpu.c | 79 +++++++++++++++++++++++++++++++++++++++++++++++++++-- 2 files changed, 102 insertions(+), 11 deletions(-) ^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 1/3] KVM: Add new -cpu best 2012-07-09 12:10 ` [Qemu-devel] " Alexander Graf @ 2012-07-09 12:10 ` Alexander Graf -1 siblings, 0 replies; 12+ messages in thread From: Alexander Graf @ 2012-07-09 12:10 UTC (permalink / raw) To: qemu-devel qemu-devel Cc: KVM list, Ryan Harper, Anthony Liguori, Andreas Färber, Avi Kivity During discussions on whether to support -cpu host in SLE, I found myself disagreeing to the thought, because it potentially opens a big can of worms for potential bugs. But if I already am so opposed to it for SLE, how can it possibly be reasonable to default to -cpu host in upstream QEMU? And what would a sane default look like? So I had this idea of looping through all available CPU definitions. We can pretty well tell if our host is able to execute any of them by checking the respective flags and seeing if our host has all features the CPU definition requires. With that, we can create a -cpu type that would fall back to the "best known CPU definition" that our host can fulfill. On my Phenom II system for example, that would be -cpu phenom. With this approach we can test and verify that CPU types actually work at any random user setup, because we can always verify that all the -cpu types we ship actually work. And we only default to some clever mechanism that chooses from one of these. Signed-off-by: Alexander Graf <agraf@suse.de> --- v2 -> v3: - clarify commit message - fix avi's style comments --- target-i386/cpu.c | 72 +++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 72 insertions(+), 0 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 5521709..a5d9468 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -558,6 +558,76 @@ static int cpu_x86_fill_host(x86_def_t *x86_cpu_def) return 0; } +/* Are all guest feature bits present on the host? */ +static bool cpu_x86_feature_subset(uint32_t host, uint32_t guest) +{ + return !(guest & ~host); +} + +/* Does the host support all the features of the CPU definition? */ +static bool cpu_x86_fits_host(x86_def_t *x86_cpu_def) +{ + uint32_t eax = 0, ebx = 0, ecx = 0, edx = 0; + + host_cpuid(0x0, 0, &eax, &ebx, &ecx, &edx); + if (x86_cpu_def->level > eax) { + return false; + } + if ((x86_cpu_def->vendor1 != ebx) || + (x86_cpu_def->vendor2 != edx) || + (x86_cpu_def->vendor3 != ecx)) { + return false; + } + + host_cpuid(0x1, 0, &eax, &ebx, &ecx, &edx); + if (!cpu_x86_feature_subset(ecx, x86_cpu_def->ext_features) || + !cpu_x86_feature_subset(edx, x86_cpu_def->features)) { + return false; + } + + host_cpuid(0x80000000, 0, &eax, &ebx, &ecx, &edx); + if (x86_cpu_def->xlevel > eax) { + return false; + } + + host_cpuid(0x80000001, 0, &eax, &ebx, &ecx, &edx); + if (!cpu_x86_feature_subset(edx, x86_cpu_def->ext2_features) || + !cpu_x86_feature_subset(ecx, x86_cpu_def->ext3_features)) { + return false; + } + + return true; +} + +/* Returns true when new_def is higher versioned than old_def */ +static int cpu_x86_fits_higher(x86_def_t *new_def, x86_def_t *old_def) +{ + int old_fammod = (old_def->family << 24) | (old_def->model << 8) + | (old_def->stepping); + int new_fammod = (new_def->family << 24) | (new_def->model << 8) + | (new_def->stepping); + + return new_fammod > old_fammod; +} + +static void cpu_x86_fill_best(x86_def_t *x86_cpu_def) +{ + x86_def_t *def; + + x86_cpu_def->family = 0; + x86_cpu_def->model = 0; + for (def = x86_defs; def; def = def->next) { + if (cpu_x86_fits_host(def) && cpu_x86_fits_higher(def, x86_cpu_def)) { + *x86_cpu_def = *def; + } + } + + if (!x86_cpu_def->family && !x86_cpu_def->model) { + fprintf(stderr, "No fitting CPU model found!\n"); + exit(1); + } +} + static int unavailable_host_feature(struct model_features_t *f, uint32_t mask) { int i; @@ -878,6 +948,8 @@ static int cpu_x86_find_by_name(x86_def_t *x86_cpu_def, const char *cpu_model) break; if (kvm_enabled() && name && strcmp(name, "host") == 0) { cpu_x86_fill_host(x86_cpu_def); + } else if (kvm_enabled() && name && strcmp(name, "best") == 0) { + cpu_x86_fill_best(x86_cpu_def); } else if (!def) { goto error; } else { -- 1.6.0.2 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* [Qemu-devel] [PATCH 1/3] KVM: Add new -cpu best @ 2012-07-09 12:10 ` Alexander Graf 0 siblings, 0 replies; 12+ messages in thread From: Alexander Graf @ 2012-07-09 12:10 UTC (permalink / raw) To: qemu-devel qemu-devel Cc: Avi Kivity, Ryan Harper, Anthony Liguori, KVM list, Andreas Färber During discussions on whether to support -cpu host in SLE, I found myself disagreeing to the thought, because it potentially opens a big can of worms for potential bugs. But if I already am so opposed to it for SLE, how can it possibly be reasonable to default to -cpu host in upstream QEMU? And what would a sane default look like? So I had this idea of looping through all available CPU definitions. We can pretty well tell if our host is able to execute any of them by checking the respective flags and seeing if our host has all features the CPU definition requires. With that, we can create a -cpu type that would fall back to the "best known CPU definition" that our host can fulfill. On my Phenom II system for example, that would be -cpu phenom. With this approach we can test and verify that CPU types actually work at any random user setup, because we can always verify that all the -cpu types we ship actually work. And we only default to some clever mechanism that chooses from one of these. Signed-off-by: Alexander Graf <agraf@suse.de> --- v2 -> v3: - clarify commit message - fix avi's style comments --- target-i386/cpu.c | 72 +++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 72 insertions(+), 0 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 5521709..a5d9468 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -558,6 +558,76 @@ static int cpu_x86_fill_host(x86_def_t *x86_cpu_def) return 0; } +/* Are all guest feature bits present on the host? */ +static bool cpu_x86_feature_subset(uint32_t host, uint32_t guest) +{ + return !(guest & ~host); +} + +/* Does the host support all the features of the CPU definition? */ +static bool cpu_x86_fits_host(x86_def_t *x86_cpu_def) +{ + uint32_t eax = 0, ebx = 0, ecx = 0, edx = 0; + + host_cpuid(0x0, 0, &eax, &ebx, &ecx, &edx); + if (x86_cpu_def->level > eax) { + return false; + } + if ((x86_cpu_def->vendor1 != ebx) || + (x86_cpu_def->vendor2 != edx) || + (x86_cpu_def->vendor3 != ecx)) { + return false; + } + + host_cpuid(0x1, 0, &eax, &ebx, &ecx, &edx); + if (!cpu_x86_feature_subset(ecx, x86_cpu_def->ext_features) || + !cpu_x86_feature_subset(edx, x86_cpu_def->features)) { + return false; + } + + host_cpuid(0x80000000, 0, &eax, &ebx, &ecx, &edx); + if (x86_cpu_def->xlevel > eax) { + return false; + } + + host_cpuid(0x80000001, 0, &eax, &ebx, &ecx, &edx); + if (!cpu_x86_feature_subset(edx, x86_cpu_def->ext2_features) || + !cpu_x86_feature_subset(ecx, x86_cpu_def->ext3_features)) { + return false; + } + + return true; +} + +/* Returns true when new_def is higher versioned than old_def */ +static int cpu_x86_fits_higher(x86_def_t *new_def, x86_def_t *old_def) +{ + int old_fammod = (old_def->family << 24) | (old_def->model << 8) + | (old_def->stepping); + int new_fammod = (new_def->family << 24) | (new_def->model << 8) + | (new_def->stepping); + + return new_fammod > old_fammod; +} + +static void cpu_x86_fill_best(x86_def_t *x86_cpu_def) +{ + x86_def_t *def; + + x86_cpu_def->family = 0; + x86_cpu_def->model = 0; + for (def = x86_defs; def; def = def->next) { + if (cpu_x86_fits_host(def) && cpu_x86_fits_higher(def, x86_cpu_def)) { + *x86_cpu_def = *def; + } + } + + if (!x86_cpu_def->family && !x86_cpu_def->model) { + fprintf(stderr, "No fitting CPU model found!\n"); + exit(1); + } +} + static int unavailable_host_feature(struct model_features_t *f, uint32_t mask) { int i; @@ -878,6 +948,8 @@ static int cpu_x86_find_by_name(x86_def_t *x86_cpu_def, const char *cpu_model) break; if (kvm_enabled() && name && strcmp(name, "host") == 0) { cpu_x86_fill_host(x86_cpu_def); + } else if (kvm_enabled() && name && strcmp(name, "best") == 0) { + cpu_x86_fill_best(x86_cpu_def); } else if (!def) { goto error; } else { -- 1.6.0.2 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 2/3] KVM: Use -cpu best as default on x86 2012-07-09 12:10 ` [Qemu-devel] " Alexander Graf @ 2012-07-09 12:10 ` Alexander Graf -1 siblings, 0 replies; 12+ messages in thread From: Alexander Graf @ 2012-07-09 12:10 UTC (permalink / raw) To: qemu-devel qemu-devel Cc: KVM list, Ryan Harper, Anthony Liguori, Andreas Färber, Avi Kivity When running QEMU without -cpu parameter, the user usually wants a sane default. So far, we're using the qemu64/qemu32 CPU type, which basically means "the maximum TCG can emulate". That's a really good default when using TCG, but when running with KVM we much rather want a default saying "the maximum performance I can get". Fortunately we just added an option that gives us the best performance while still staying safe on the testability side of things: -cpu best. So all we need to do is make -cpu best the default when the user doesn't explicitly specify a CPU type. This fixes a lot of subtle breakage in the GNU toolchain (libgmp) which hicks up on QEMU's non-existent CPU models. This patch also adds a new pc-1.2 machine type to stay backwards compatible with older versions of QEMU. Signed-off-by: Alexander Graf <agraf@suse.de> --- v1 -> v2: - rebase v2 -> v3: - fix typo in commit message --- hw/pc_piix.c | 34 ++++++++++++++++++++++++++-------- 1 files changed, 26 insertions(+), 8 deletions(-) diff --git a/hw/pc_piix.c b/hw/pc_piix.c index 0c0096f..a955bf8 100644 --- a/hw/pc_piix.c +++ b/hw/pc_piix.c @@ -127,7 +127,8 @@ static void pc_init1(MemoryRegion *system_memory, const char *initrd_filename, const char *cpu_model, int pci_enabled, - int kvmclock_enabled) + int kvmclock_enabled, + int may_cpu_best) { int i; ram_addr_t below_4g_mem_size, above_4g_mem_size; @@ -149,6 +150,9 @@ static void pc_init1(MemoryRegion *system_memory, MemoryRegion *rom_memory; void *fw_cfg = NULL; + if (!cpu_model && kvm_enabled() && may_cpu_best) { + cpu_model = "best"; + } pc_cpus_init(cpu_model); if (kvmclock_enabled) { @@ -298,7 +302,21 @@ static void pc_init_pci(ram_addr_t ram_size, get_system_io(), ram_size, boot_device, kernel_filename, kernel_cmdline, - initrd_filename, cpu_model, 1, 1); + initrd_filename, cpu_model, 1, 1, 1); +} + +static void pc_init_pci_oldcpu(ram_addr_t ram_size, + const char *boot_device, + const char *kernel_filename, + const char *kernel_cmdline, + const char *initrd_filename, + const char *cpu_model) +{ + pc_init1(get_system_memory(), + get_system_io(), + ram_size, boot_device, + kernel_filename, kernel_cmdline, + initrd_filename, cpu_model, 1, 1, 0); } static void pc_init_pci_no_kvmclock(ram_addr_t ram_size, @@ -312,7 +330,7 @@ static void pc_init_pci_no_kvmclock(ram_addr_t ram_size, get_system_io(), ram_size, boot_device, kernel_filename, kernel_cmdline, - initrd_filename, cpu_model, 1, 0); + initrd_filename, cpu_model, 1, 0, 0); } static void pc_init_isa(ram_addr_t ram_size, @@ -328,7 +346,7 @@ static void pc_init_isa(ram_addr_t ram_size, get_system_io(), ram_size, boot_device, kernel_filename, kernel_cmdline, - initrd_filename, cpu_model, 0, 1); + initrd_filename, cpu_model, 0, 1, 0); } #ifdef CONFIG_XEN @@ -380,7 +398,7 @@ static QEMUMachine pc_machine_v1_2 = { static QEMUMachine pc_machine_v1_1 = { .name = "pc-1.1", .desc = "Standard PC", - .init = pc_init_pci, + .init = pc_init_pci_oldcpu, .max_cpus = 255, .compat_props = (GlobalProperty[]) { PC_COMPAT_1_1, @@ -415,7 +433,7 @@ static QEMUMachine pc_machine_v1_1 = { static QEMUMachine pc_machine_v1_0 = { .name = "pc-1.0", .desc = "Standard PC", - .init = pc_init_pci, + .init = pc_init_pci_oldcpu, .max_cpus = 255, .compat_props = (GlobalProperty[]) { PC_COMPAT_1_0, @@ -430,7 +448,7 @@ static QEMUMachine pc_machine_v1_0 = { static QEMUMachine pc_machine_v0_15 = { .name = "pc-0.15", .desc = "Standard PC", - .init = pc_init_pci, + .init = pc_init_pci_oldcpu, .max_cpus = 255, .compat_props = (GlobalProperty[]) { PC_COMPAT_0_15, @@ -462,7 +480,7 @@ static QEMUMachine pc_machine_v0_15 = { static QEMUMachine pc_machine_v0_14 = { .name = "pc-0.14", .desc = "Standard PC", - .init = pc_init_pci, + .init = pc_init_pci_oldcpu, .max_cpus = 255, .compat_props = (GlobalProperty[]) { PC_COMPAT_0_14, -- 1.6.0.2 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* [Qemu-devel] [PATCH 2/3] KVM: Use -cpu best as default on x86 @ 2012-07-09 12:10 ` Alexander Graf 0 siblings, 0 replies; 12+ messages in thread From: Alexander Graf @ 2012-07-09 12:10 UTC (permalink / raw) To: qemu-devel qemu-devel Cc: Avi Kivity, Ryan Harper, Anthony Liguori, KVM list, Andreas Färber When running QEMU without -cpu parameter, the user usually wants a sane default. So far, we're using the qemu64/qemu32 CPU type, which basically means "the maximum TCG can emulate". That's a really good default when using TCG, but when running with KVM we much rather want a default saying "the maximum performance I can get". Fortunately we just added an option that gives us the best performance while still staying safe on the testability side of things: -cpu best. So all we need to do is make -cpu best the default when the user doesn't explicitly specify a CPU type. This fixes a lot of subtle breakage in the GNU toolchain (libgmp) which hicks up on QEMU's non-existent CPU models. This patch also adds a new pc-1.2 machine type to stay backwards compatible with older versions of QEMU. Signed-off-by: Alexander Graf <agraf@suse.de> --- v1 -> v2: - rebase v2 -> v3: - fix typo in commit message --- hw/pc_piix.c | 34 ++++++++++++++++++++++++++-------- 1 files changed, 26 insertions(+), 8 deletions(-) diff --git a/hw/pc_piix.c b/hw/pc_piix.c index 0c0096f..a955bf8 100644 --- a/hw/pc_piix.c +++ b/hw/pc_piix.c @@ -127,7 +127,8 @@ static void pc_init1(MemoryRegion *system_memory, const char *initrd_filename, const char *cpu_model, int pci_enabled, - int kvmclock_enabled) + int kvmclock_enabled, + int may_cpu_best) { int i; ram_addr_t below_4g_mem_size, above_4g_mem_size; @@ -149,6 +150,9 @@ static void pc_init1(MemoryRegion *system_memory, MemoryRegion *rom_memory; void *fw_cfg = NULL; + if (!cpu_model && kvm_enabled() && may_cpu_best) { + cpu_model = "best"; + } pc_cpus_init(cpu_model); if (kvmclock_enabled) { @@ -298,7 +302,21 @@ static void pc_init_pci(ram_addr_t ram_size, get_system_io(), ram_size, boot_device, kernel_filename, kernel_cmdline, - initrd_filename, cpu_model, 1, 1); + initrd_filename, cpu_model, 1, 1, 1); +} + +static void pc_init_pci_oldcpu(ram_addr_t ram_size, + const char *boot_device, + const char *kernel_filename, + const char *kernel_cmdline, + const char *initrd_filename, + const char *cpu_model) +{ + pc_init1(get_system_memory(), + get_system_io(), + ram_size, boot_device, + kernel_filename, kernel_cmdline, + initrd_filename, cpu_model, 1, 1, 0); } static void pc_init_pci_no_kvmclock(ram_addr_t ram_size, @@ -312,7 +330,7 @@ static void pc_init_pci_no_kvmclock(ram_addr_t ram_size, get_system_io(), ram_size, boot_device, kernel_filename, kernel_cmdline, - initrd_filename, cpu_model, 1, 0); + initrd_filename, cpu_model, 1, 0, 0); } static void pc_init_isa(ram_addr_t ram_size, @@ -328,7 +346,7 @@ static void pc_init_isa(ram_addr_t ram_size, get_system_io(), ram_size, boot_device, kernel_filename, kernel_cmdline, - initrd_filename, cpu_model, 0, 1); + initrd_filename, cpu_model, 0, 1, 0); } #ifdef CONFIG_XEN @@ -380,7 +398,7 @@ static QEMUMachine pc_machine_v1_2 = { static QEMUMachine pc_machine_v1_1 = { .name = "pc-1.1", .desc = "Standard PC", - .init = pc_init_pci, + .init = pc_init_pci_oldcpu, .max_cpus = 255, .compat_props = (GlobalProperty[]) { PC_COMPAT_1_1, @@ -415,7 +433,7 @@ static QEMUMachine pc_machine_v1_1 = { static QEMUMachine pc_machine_v1_0 = { .name = "pc-1.0", .desc = "Standard PC", - .init = pc_init_pci, + .init = pc_init_pci_oldcpu, .max_cpus = 255, .compat_props = (GlobalProperty[]) { PC_COMPAT_1_0, @@ -430,7 +448,7 @@ static QEMUMachine pc_machine_v1_0 = { static QEMUMachine pc_machine_v0_15 = { .name = "pc-0.15", .desc = "Standard PC", - .init = pc_init_pci, + .init = pc_init_pci_oldcpu, .max_cpus = 255, .compat_props = (GlobalProperty[]) { PC_COMPAT_0_15, @@ -462,7 +480,7 @@ static QEMUMachine pc_machine_v0_15 = { static QEMUMachine pc_machine_v0_14 = { .name = "pc-0.14", .desc = "Standard PC", - .init = pc_init_pci, + .init = pc_init_pci_oldcpu, .max_cpus = 255, .compat_props = (GlobalProperty[]) { PC_COMPAT_0_14, -- 1.6.0.2 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [Qemu-devel] [PATCH 2/3] KVM: Use -cpu best as default on x86 2012-07-09 12:10 ` [Qemu-devel] " Alexander Graf @ 2012-07-09 13:47 ` Eric Blake -1 siblings, 0 replies; 12+ messages in thread From: Eric Blake @ 2012-07-09 13:47 UTC (permalink / raw) To: Alexander Graf Cc: qemu-devel qemu-devel, Avi Kivity, Ryan Harper, Anthony Liguori, KVM list, Andreas Färber [-- Attachment #1: Type: text/plain, Size: 398 bytes --] On 07/09/2012 06:10 AM, Alexander Graf wrote: > > This fixes a lot of subtle breakage in the GNU toolchain (libgmp) which > hicks up on QEMU's non-existent CPU models. s/hicks up/hiccups/ > > v2 -> v3: > > - fix typo in commit message but not all of them :) -- Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 620 bytes --] ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Qemu-devel] [PATCH 2/3] KVM: Use -cpu best as default on x86 @ 2012-07-09 13:47 ` Eric Blake 0 siblings, 0 replies; 12+ messages in thread From: Eric Blake @ 2012-07-09 13:47 UTC (permalink / raw) To: Alexander Graf Cc: KVM list, qemu-devel qemu-devel, Ryan Harper, Avi Kivity, Anthony Liguori, Andreas Färber [-- Attachment #1: Type: text/plain, Size: 398 bytes --] On 07/09/2012 06:10 AM, Alexander Graf wrote: > > This fixes a lot of subtle breakage in the GNU toolchain (libgmp) which > hicks up on QEMU's non-existent CPU models. s/hicks up/hiccups/ > > v2 -> v3: > > - fix typo in commit message but not all of them :) -- Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 620 bytes --] ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Qemu-devel] [PATCH 2/3] KVM: Use -cpu best as default on x86 2012-07-09 13:47 ` Eric Blake @ 2012-07-09 13:48 ` Alexander Graf -1 siblings, 0 replies; 12+ messages in thread From: Alexander Graf @ 2012-07-09 13:48 UTC (permalink / raw) To: Eric Blake Cc: qemu-devel qemu-devel, Avi Kivity, Ryan Harper, Anthony Liguori, KVM list, Andreas Färber On 09.07.2012, at 15:47, Eric Blake wrote: > On 07/09/2012 06:10 AM, Alexander Graf wrote: > >> >> This fixes a lot of subtle breakage in the GNU toolchain (libgmp) which >> hicks up on QEMU's non-existent CPU models. > > s/hicks up/hiccups/ > > >> >> v2 -> v3: >> >> - fix typo in commit message > > but not all of them :) I hope you don't expect me to respin now :) Alex ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Qemu-devel] [PATCH 2/3] KVM: Use -cpu best as default on x86 @ 2012-07-09 13:48 ` Alexander Graf 0 siblings, 0 replies; 12+ messages in thread From: Alexander Graf @ 2012-07-09 13:48 UTC (permalink / raw) To: Eric Blake Cc: KVM list, qemu-devel qemu-devel, Ryan Harper, Avi Kivity, Anthony Liguori, Andreas Färber On 09.07.2012, at 15:47, Eric Blake wrote: > On 07/09/2012 06:10 AM, Alexander Graf wrote: > >> >> This fixes a lot of subtle breakage in the GNU toolchain (libgmp) which >> hicks up on QEMU's non-existent CPU models. > > s/hicks up/hiccups/ > > >> >> v2 -> v3: >> >> - fix typo in commit message > > but not all of them :) I hope you don't expect me to respin now :) Alex ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Qemu-devel] [PATCH 2/3] KVM: Use -cpu best as default on x86 2012-07-09 13:48 ` Alexander Graf @ 2012-07-09 13:52 ` Eric Blake -1 siblings, 0 replies; 12+ messages in thread From: Eric Blake @ 2012-07-09 13:52 UTC (permalink / raw) To: Alexander Graf Cc: qemu-devel qemu-devel, Avi Kivity, Ryan Harper, Anthony Liguori, KVM list, Andreas Färber [-- Attachment #1: Type: text/plain, Size: 682 bytes --] On 07/09/2012 07:48 AM, Alexander Graf wrote: > > On 09.07.2012, at 15:47, Eric Blake wrote: > >> On 07/09/2012 06:10 AM, Alexander Graf wrote: >> >>> >>> This fixes a lot of subtle breakage in the GNU toolchain (libgmp) which >>> hicks up on QEMU's non-existent CPU models. >> >> s/hicks up/hiccups/ >> >> >>> >>> v2 -> v3: >>> >>> - fix typo in commit message >> >> but not all of them :) > > I hope you don't expect me to respin now :) I don't. If someone wants to touch it up, great; if not, it's not the first typo in a commit. :) -- Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 620 bytes --] ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Qemu-devel] [PATCH 2/3] KVM: Use -cpu best as default on x86 @ 2012-07-09 13:52 ` Eric Blake 0 siblings, 0 replies; 12+ messages in thread From: Eric Blake @ 2012-07-09 13:52 UTC (permalink / raw) To: Alexander Graf Cc: KVM list, qemu-devel qemu-devel, Ryan Harper, Avi Kivity, Anthony Liguori, Andreas Färber [-- Attachment #1: Type: text/plain, Size: 682 bytes --] On 07/09/2012 07:48 AM, Alexander Graf wrote: > > On 09.07.2012, at 15:47, Eric Blake wrote: > >> On 07/09/2012 06:10 AM, Alexander Graf wrote: >> >>> >>> This fixes a lot of subtle breakage in the GNU toolchain (libgmp) which >>> hicks up on QEMU's non-existent CPU models. >> >> s/hicks up/hiccups/ >> >> >>> >>> v2 -> v3: >>> >>> - fix typo in commit message >> >> but not all of them :) > > I hope you don't expect me to respin now :) I don't. If someone wants to touch it up, great; if not, it's not the first typo in a commit. :) -- Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 620 bytes --] ^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2012-07-09 13:52 UTC | newest] Thread overview: 12+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2012-07-09 12:10 [PATCH 0/3] Add -cpu best support Alexander Graf 2012-07-09 12:10 ` [Qemu-devel] " Alexander Graf 2012-07-09 12:10 ` [PATCH 1/3] KVM: Add new -cpu best Alexander Graf 2012-07-09 12:10 ` [Qemu-devel] " Alexander Graf 2012-07-09 12:10 ` [PATCH 2/3] KVM: Use -cpu best as default on x86 Alexander Graf 2012-07-09 12:10 ` [Qemu-devel] " Alexander Graf 2012-07-09 13:47 ` Eric Blake 2012-07-09 13:47 ` Eric Blake 2012-07-09 13:48 ` Alexander Graf 2012-07-09 13:48 ` Alexander Graf 2012-07-09 13:52 ` Eric Blake 2012-07-09 13:52 ` Eric Blake
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.