From: Tabi Timur-B04825 <B04825@freescale.com>
To: David Miller <davem@davemloft.net>
Cc: Fleming Andy-AFLEMING <afleming@freescale.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH] net/fsl_pq_mdio: use spin_event_timeout() to poll the indicator register
Date: Mon, 9 Jul 2012 14:31:33 +0000 [thread overview]
Message-ID: <4FFAEB44.2030600@freescale.com> (raw)
In-Reply-To: <20120708.235926.1117975937932919247.davem@davemloft.net>
David Miller wrote:
> Define a macro for the timeout value rather than use an arbitrary
> constant.
Ok.
>> + status = spin_event_timeout(!(in_be32(®s->miimind) & MIIMIND_BUSY),
>> + 1000, 0);
>
> This indentation is absolutely terrible.
Can you give me a clue as to how you think it should look? I could not
come up with a good way to break up these lines and keep them under 80
characters.
--
Timur Tabi
Linux kernel developer at Freescale
next prev parent reply other threads:[~2012-07-09 14:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-03 23:16 [PATCH] net/fsl_pq_mdio: use spin_event_timeout() to poll the indicator register Timur Tabi
2012-07-09 6:59 ` David Miller
2012-07-09 14:31 ` Tabi Timur-B04825 [this message]
2012-07-09 19:50 ` Jan Ceuleers
2012-07-09 21:17 ` David Miller
2012-07-09 21:19 ` Timur Tabi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FFAEB44.2030600@freescale.com \
--to=b04825@freescale.com \
--cc=afleming@freescale.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.