All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Ceuleers <jan.ceuleers@computer.org>
To: Tabi Timur-B04825 <B04825@freescale.com>
Cc: David Miller <davem@davemloft.net>,
	Fleming Andy-AFLEMING <afleming@freescale.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH] net/fsl_pq_mdio: use spin_event_timeout() to poll the indicator register
Date: Mon, 09 Jul 2012 21:50:46 +0200	[thread overview]
Message-ID: <4FFB3616.2070403@computer.org> (raw)
In-Reply-To: <4FFAEB44.2030600@freescale.com>

On 07/09/2012 04:31 PM, Tabi Timur-B04825 wrote:
>> This indentation is absolutely terrible.
> 
> Can you give me a clue as to how you think it should look?  I could not 
> come up with a good way to break up these lines and keep them under 80 
> characters.
> 

How about this:

+	status = spin_event_timeout(!(in_be32(&regs->miimind) &	MIIMIND_BUSY),
+				    1000, 0);

On the second line use as many tabs as possible, then continue with spaces until the '1' in 1000 lines up with the '!'.

HTH, Jan

  reply	other threads:[~2012-07-09 19:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-03 23:16 [PATCH] net/fsl_pq_mdio: use spin_event_timeout() to poll the indicator register Timur Tabi
2012-07-09  6:59 ` David Miller
2012-07-09 14:31   ` Tabi Timur-B04825
2012-07-09 19:50     ` Jan Ceuleers [this message]
2012-07-09 21:17     ` David Miller
2012-07-09 21:19       ` Timur Tabi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FFB3616.2070403@computer.org \
    --to=jan.ceuleers@computer.org \
    --cc=B04825@freescale.com \
    --cc=afleming@freescale.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.