* [patch] net/mlx4: off by one in parse_trans_rule()
@ 2012-07-11 6:33 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2012-07-11 6:33 UTC (permalink / raw)
To: Hadar Hen Zion
Cc: David S. Miller, Or Gerlitz, Eugenia Emantayev, Yevgeny Petrilin,
netdev, kernel-janitors
This should be ">=" here instead of ">". MLX4_NET_TRANS_RULE_NUM is 6.
We use "spec->id" as an array offset into the __rule_hw_sz[] and
__sw_id_hw[] arrays which have 6 elements.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/net/ethernet/mellanox/mlx4/mcg.c b/drivers/net/ethernet/mellanox/mlx4/mcg.c
index bc62f53..5bac0df 100644
--- a/drivers/net/ethernet/mellanox/mlx4/mcg.c
+++ b/drivers/net/ethernet/mellanox/mlx4/mcg.c
@@ -773,7 +773,7 @@ static int parse_trans_rule(struct mlx4_dev *dev, struct mlx4_spec_list *spec,
[MLX4_NET_TRANS_RULE_ID_UDP] sizeof(struct mlx4_net_trans_rule_hw_tcp_udp)
};
- if (spec->id > MLX4_NET_TRANS_RULE_NUM) {
+ if (spec->id >= MLX4_NET_TRANS_RULE_NUM) {
mlx4_err(dev, "Invalid network rule id. id = %d\n", spec->id);
return -EINVAL;
}
^ permalink raw reply related [flat|nested] 6+ messages in thread* [patch] net/mlx4: off by one in parse_trans_rule()
@ 2012-07-11 6:33 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2012-07-11 6:33 UTC (permalink / raw)
To: Hadar Hen Zion
Cc: David S. Miller, Or Gerlitz, Eugenia Emantayev, Yevgeny Petrilin,
netdev, kernel-janitors
This should be ">=" here instead of ">". MLX4_NET_TRANS_RULE_NUM is 6.
We use "spec->id" as an array offset into the __rule_hw_sz[] and
__sw_id_hw[] arrays which have 6 elements.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/net/ethernet/mellanox/mlx4/mcg.c b/drivers/net/ethernet/mellanox/mlx4/mcg.c
index bc62f53..5bac0df 100644
--- a/drivers/net/ethernet/mellanox/mlx4/mcg.c
+++ b/drivers/net/ethernet/mellanox/mlx4/mcg.c
@@ -773,7 +773,7 @@ static int parse_trans_rule(struct mlx4_dev *dev, struct mlx4_spec_list *spec,
[MLX4_NET_TRANS_RULE_ID_UDP] =
sizeof(struct mlx4_net_trans_rule_hw_tcp_udp)
};
- if (spec->id > MLX4_NET_TRANS_RULE_NUM) {
+ if (spec->id >= MLX4_NET_TRANS_RULE_NUM) {
mlx4_err(dev, "Invalid network rule id. id = %d\n", spec->id);
return -EINVAL;
}
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [patch] net/mlx4: off by one in parse_trans_rule()
2012-07-11 6:33 ` Dan Carpenter
@ 2012-07-11 14:51 ` Hadar Hen Zion
-1 siblings, 0 replies; 6+ messages in thread
From: Hadar Hen Zion @ 2012-07-11 14:51 UTC (permalink / raw)
To: Dan Carpenter
Cc: Hadar Hen Zion, David S. Miller, Or Gerlitz, Eugenia Emantayev,
Yevgeny Petrilin, netdev, kernel-janitors
On 7/11/2012 9:33 AM, Dan Carpenter wrote:
> This should be ">=" here instead of ">". MLX4_NET_TRANS_RULE_NUM is 6.
> We use "spec->id" as an array offset into the __rule_hw_sz[] and
> __sw_id_hw[] arrays which have 6 elements.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/net/ethernet/mellanox/mlx4/mcg.c b/drivers/net/ethernet/mellanox/mlx4/mcg.c
> index bc62f53..5bac0df 100644
> --- a/drivers/net/ethernet/mellanox/mlx4/mcg.c
> +++ b/drivers/net/ethernet/mellanox/mlx4/mcg.c
> @@ -773,7 +773,7 @@ static int parse_trans_rule(struct mlx4_dev *dev, struct mlx4_spec_list *spec,
> [MLX4_NET_TRANS_RULE_ID_UDP] > sizeof(struct mlx4_net_trans_rule_hw_tcp_udp)
> };
> - if (spec->id > MLX4_NET_TRANS_RULE_NUM) {
> + if (spec->id >= MLX4_NET_TRANS_RULE_NUM) {
> mlx4_err(dev, "Invalid network rule id. id = %d\n", spec->id);
> return -EINVAL;
> }
>
Hi Dan,
This is indeed a bug, thanks for spotting this over,
Please add:
Acked-by: Hadar Hen Zion <hadarh@mellanox.co.il>
Hadar
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [patch] net/mlx4: off by one in parse_trans_rule()
@ 2012-07-11 14:51 ` Hadar Hen Zion
0 siblings, 0 replies; 6+ messages in thread
From: Hadar Hen Zion @ 2012-07-11 14:51 UTC (permalink / raw)
To: Dan Carpenter
Cc: Hadar Hen Zion, David S. Miller, Or Gerlitz, Eugenia Emantayev,
Yevgeny Petrilin, netdev, kernel-janitors
On 7/11/2012 9:33 AM, Dan Carpenter wrote:
> This should be ">=" here instead of ">". MLX4_NET_TRANS_RULE_NUM is 6.
> We use "spec->id" as an array offset into the __rule_hw_sz[] and
> __sw_id_hw[] arrays which have 6 elements.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/net/ethernet/mellanox/mlx4/mcg.c b/drivers/net/ethernet/mellanox/mlx4/mcg.c
> index bc62f53..5bac0df 100644
> --- a/drivers/net/ethernet/mellanox/mlx4/mcg.c
> +++ b/drivers/net/ethernet/mellanox/mlx4/mcg.c
> @@ -773,7 +773,7 @@ static int parse_trans_rule(struct mlx4_dev *dev, struct mlx4_spec_list *spec,
> [MLX4_NET_TRANS_RULE_ID_UDP] =
> sizeof(struct mlx4_net_trans_rule_hw_tcp_udp)
> };
> - if (spec->id > MLX4_NET_TRANS_RULE_NUM) {
> + if (spec->id >= MLX4_NET_TRANS_RULE_NUM) {
> mlx4_err(dev, "Invalid network rule id. id = %d\n", spec->id);
> return -EINVAL;
> }
>
Hi Dan,
This is indeed a bug, thanks for spotting this over,
Please add:
Acked-by: Hadar Hen Zion <hadarh@mellanox.co.il>
Hadar
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch] net/mlx4: off by one in parse_trans_rule()
2012-07-11 6:33 ` Dan Carpenter
@ 2012-07-17 5:58 ` David Miller
-1 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2012-07-17 5:58 UTC (permalink / raw)
To: dan.carpenter
Cc: hadarh, ogerlitz, eugenia, yevgenyp, netdev, kernel-janitors
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Wed, 11 Jul 2012 09:33:36 +0300
> This should be ">=" here instead of ">". MLX4_NET_TRANS_RULE_NUM is 6.
> We use "spec->id" as an array offset into the __rule_hw_sz[] and
> __sw_id_hw[] arrays which have 6 elements.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied, thanks.
Dan, in the future please indicate clearly that your patches are
targetted at net-next specifically. Thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch] net/mlx4: off by one in parse_trans_rule()
@ 2012-07-17 5:58 ` David Miller
0 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2012-07-17 5:58 UTC (permalink / raw)
To: dan.carpenter
Cc: hadarh, ogerlitz, eugenia, yevgenyp, netdev, kernel-janitors
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Wed, 11 Jul 2012 09:33:36 +0300
> This should be ">=" here instead of ">". MLX4_NET_TRANS_RULE_NUM is 6.
> We use "spec->id" as an array offset into the __rule_hw_sz[] and
> __sw_id_hw[] arrays which have 6 elements.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied, thanks.
Dan, in the future please indicate clearly that your patches are
targetted at net-next specifically. Thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-07-17 5:58 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-11 6:33 [patch] net/mlx4: off by one in parse_trans_rule() Dan Carpenter
2012-07-11 6:33 ` Dan Carpenter
2012-07-11 14:51 ` Hadar Hen Zion
2012-07-11 14:51 ` Hadar Hen Zion
2012-07-17 5:58 ` David Miller
2012-07-17 5:58 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.