Re: [PATCH] cpan.bbclass: Fix CCFLAGS.

[Pascal Ouyang <xin.ouyang@windriver.com>]

Hi Saul,

I have sent this patch for a while. Please merge this if no objections. 
Thanks.

- Pascal

On 2012年07月06日 13:39, Khem Raj wrote:
> On Thu, Jul 5, 2012 at 10:33 PM, Pascal Ouyang <xin.ouyang@windriver.com> wrote:
>> On 2012年07月05日 22:57, Khem Raj wrote:
>>>
>>> On Thu, Jul 5, 2012 at 4:17 AM, Pascal Ouyang <xin.ouyang@windriver.com>
>>> wrote:
>>>>
>>>>
>>>> So, I still don't know what is your opinion of this patch.
>>>
>>>
>>> I think we still need the CC and CFLAGS to appear in CCFLAGS since
>>> they sometimes decide ABI etc. that we use and without that
>>> the modules will be incompatible. So may be
>>> appending to CCFLAGS would work instead
>>>
>>
>> Exactly in my patch, this just appends CFLAGS to CCFLAGS.
>>
>
> seems ok I guess
>
>>
>> @@ -26,13 +26,14 @@ cpan_do_configure () {
>>                          test -f $f2 || continue
>>                          sed -i -e "s:\(PERL_ARCHLIB =
>> \).*:\1${PERL_ARCHLIB}:" \
>>                                  -e 's/perl.real/perl/' \
>> +                               -e "s/^\(CCFLAGS =.*\)/\1 ${CFLAGS}/" \
>>                                  $f2
>>                  done
>>          fi
>>   }
>>
>> Thanks.
>> --
>> - Pascal
>>
>>


-- 
- Pascal