All of lore.kernel.org
 help / color / mirror / Atom feed
From: Saul Wold <sgw@linux.intel.com>
To: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] cpan.bbclass: Fix CCFLAGS.
Date: Tue, 17 Jul 2012 09:16:13 -0700	[thread overview]
Message-ID: <50058FCD.9060806@linux.intel.com> (raw)
In-Reply-To: <1340262834-27560-1-git-send-email-xin.ouyang@windriver.com>

On 06/21/2012 12:13 AM, xin.ouyang@windriver.com wrote:
> From: Xin Ouyang <Xin.Ouyang@windriver.com>
>
> We should not just replace CCFLAGS with CFLAGS while compiling, because
> this may cause run-time errors with perl's DynaLoader.pm.
>
> Tested on qemux86 with new libnet-libidn-perl bb recipe:
>
> root@qemux86:~# perl -e "use Net::LibIDN"
> Not a CODE reference at /usr/lib/perl/5.14.2//DynaLoader.pm line 213.
> END failed--call queue aborted at /usr/lib/perl/vendor_perl/5.14.2//Net/LibIDN.pm line 213.
> Compilation failed in require at -e line 1.
> BEGIN failed--compilation aborted at -e line 1.
>
> Signed-off-by: Xin Ouyang <Xin.Ouyang@windriver.com>
> ---
>   meta/classes/cpan.bbclass |    3 ++-
>   1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/meta/classes/cpan.bbclass b/meta/classes/cpan.bbclass
> index 2e9432c..957a6e2 100644
> --- a/meta/classes/cpan.bbclass
> +++ b/meta/classes/cpan.bbclass
> @@ -26,13 +26,14 @@ cpan_do_configure () {
>   			test -f $f2 || continue
>   			sed -i -e "s:\(PERL_ARCHLIB = \).*:\1${PERL_ARCHLIB}:" \
>   				-e 's/perl.real/perl/' \
> +				-e "s/^\(CCFLAGS =.*\)/\1 ${CFLAGS}/" \
>   				$f2
>   		done
>   	fi
>   }
>
>   cpan_do_compile () {
> -	oe_runmake PASTHRU_INC="${CFLAGS}" CCFLAGS="${CFLAGS}" LD="${CCLD}"
> +	oe_runmake PASTHRU_INC="${CFLAGS}" LD="${CCLD}"
>   }
>
>   cpan_do_install () {
>

Merged into OE-Core

Thanks
	Sau!



      parent reply	other threads:[~2012-07-17 16:27 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-21  7:13 [PATCH] cpan.bbclass: Fix CCFLAGS xin.ouyang
2012-06-21 15:47 ` Khem Raj
2012-06-28  7:59   ` Pascal Ouyang
2012-06-28 16:04     ` Khem Raj
2012-07-02  7:54       ` Pascal Ouyang
2012-07-05 11:17       ` Pascal Ouyang
2012-07-05 14:57         ` Khem Raj
2012-07-06  5:33           ` Pascal Ouyang
2012-07-06  5:39             ` Khem Raj
2012-07-12  6:46               ` Pascal Ouyang
2012-07-17 16:16 ` Saul Wold [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50058FCD.9060806@linux.intel.com \
    --to=sgw@linux.intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.