All of lore.kernel.org
 help / color / mirror / Atom feed
From: Clemens Ladisch <clemens@ladisch.de>
To: Daniel Mack <zonque@gmail.com>
Cc: tiwai@suse.de, alsa-devel@alsa-project.org, philipp@dreimann.net,
	joseph.salisbury@canonical.com
Subject: Re: [PATCH 1/2] ALSA: snd-usb: tighten EP_FLAG_RUNNING checks
Date: Thu, 12 Jul 2012 16:29:12 +0200	[thread overview]
Message-ID: <4FFEDF38.7060808@ladisch.de> (raw)
In-Reply-To: <1342099187-6978-1-git-send-email-zonque@gmail.com>

Daniel Mack wrote:
> In endpoint.c, bail out earlier in case the stream is stopped.
> ...
> @@ -350,7 +350,8 @@ static void snd_complete_urb(struct urb *urb)
>  		     urb->status == -ENODEV ||		/* device removed */
>  		     urb->status == -ECONNRESET ||	/* unlinked */
>  		     urb->status == -ESHUTDOWN ||	/* device disabled */
> -		     ep->chip->shutdown))		/* device disconnected */
> +		     ep->chip->shutdown) ||		/* device disconnected */
> +		     !test_bit(EP_FLAG_RUNNING, &ep->flags))
>  		goto exit_clear;

Is this really needed?
The URBs will be unlinked at the same time.


Regards,
Clemens

  parent reply	other threads:[~2012-07-12 14:29 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-12 13:19 [PATCH 1/2] ALSA: snd-usb: tighten EP_FLAG_RUNNING checks Daniel Mack
2012-07-12 13:19 ` [PATCH 2/2] ALSA: snd-usb: move calls to usb_set_interface Daniel Mack
2012-07-13  5:58   ` Takashi Iwai
2012-07-13  6:08     ` Daniel Mack
2012-07-13  7:33       ` Takashi Iwai
2012-07-12 14:29 ` Clemens Ladisch [this message]
2012-07-12 14:58   ` [PATCH 1/2] ALSA: snd-usb: tighten EP_FLAG_RUNNING checks Daniel Mack
2012-07-12 15:20     ` Clemens Ladisch
2012-07-12 15:27       ` Daniel Mack
     [not found]         ` <4FFF232E.8020008@canonical.com>
2012-07-12 19:26           ` Daniel Mack

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FFEDF38.7060808@ladisch.de \
    --to=clemens@ladisch.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=joseph.salisbury@canonical.com \
    --cc=philipp@dreimann.net \
    --cc=tiwai@suse.de \
    --cc=zonque@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.