From: Timur Tabi <b04825@freescale.com>
To: Liu Qiang-B32616 <B32616@freescale.com>
Cc: "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
Vinod Koul <vinod.koul@intel.com>,
"herbert@gondor.hengli.com.au" <herbert@gondor.hengli.com.au>,
Dan Williams <dan.j.williams@intel.com>,
Li Yang-R58472 <r58472@freescale.com>,
"davem@davemloft.net" <davem@davemloft.net>
Subject: Re: [linuxppc-release] [PATCH v2 4/4] fsl-dma: use spin_lock_bh to instead of spin_lock_irqsave
Date: Thu, 12 Jul 2012 13:23:47 -0500 [thread overview]
Message-ID: <4FFF1633.1080308@freescale.com> (raw)
In-Reply-To: <BCB48C05FCE8BC4D9E61E841ECBE6DB70C0987@039-SN2MPN1-011.039d.mgd.msft.net>
Liu Qiang-B32616 wrote:
> I compared my test result before and after this patch, write performance can
> improved by 15%. I will send the latest patches sooner because of Ira's concern.
> I will give a complete description about the improvement of spin_lock_bh().
>
> About your question, spin_lock_bh is used in the case of bottom/half as its
> name, there is no need to protect a running/pending list with spin_lock_irqsave.
Please respin the patch and include this information in the patch description.
--
Timur Tabi
Linux kernel developer at Freescale
WARNING: multiple messages have this Message-ID (diff)
From: Timur Tabi <b04825@freescale.com>
To: Liu Qiang-B32616 <B32616@freescale.com>
Cc: Li Yang-R58472 <r58472@freescale.com>,
Vinod Koul <vinod.koul@intel.com>,
"herbert@gondor.hengli.com.au" <herbert@gondor.hengli.com.au>,
"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
Dan Williams <dan.j.williams@intel.com>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"davem@davemloft.net" <davem@davemloft.net>
Subject: Re: [linuxppc-release] [PATCH v2 4/4] fsl-dma: use spin_lock_bh to instead of spin_lock_irqsave
Date: Thu, 12 Jul 2012 13:23:47 -0500 [thread overview]
Message-ID: <4FFF1633.1080308@freescale.com> (raw)
In-Reply-To: <BCB48C05FCE8BC4D9E61E841ECBE6DB70C0987@039-SN2MPN1-011.039d.mgd.msft.net>
Liu Qiang-B32616 wrote:
> I compared my test result before and after this patch, write performance can
> improved by 15%. I will send the latest patches sooner because of Ira's concern.
> I will give a complete description about the improvement of spin_lock_bh().
>
> About your question, spin_lock_bh is used in the case of bottom/half as its
> name, there is no need to protect a running/pending list with spin_lock_irqsave.
Please respin the patch and include this information in the patch description.
--
Timur Tabi
Linux kernel developer at Freescale
next prev parent reply other threads:[~2012-07-12 18:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-11 9:02 [PATCH v2 4/4] fsl-dma: use spin_lock_bh to instead of spin_lock_irqsave Qiang Liu
2012-07-11 9:02 ` Qiang Liu
2012-07-11 15:01 ` [linuxppc-release] " Timur Tabi
2012-07-11 15:01 ` Timur Tabi
2012-07-12 9:07 ` Liu Qiang-B32616
2012-07-12 9:07 ` Liu Qiang-B32616
2012-07-12 18:23 ` Timur Tabi [this message]
2012-07-12 18:23 ` Timur Tabi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FFF1633.1080308@freescale.com \
--to=b04825@freescale.com \
--cc=B32616@freescale.com \
--cc=dan.j.williams@intel.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.hengli.com.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=r58472@freescale.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.