From: Oleksii Kurochko <oleksii.kurochko@gmail.com>
To: dmukhin@ford.com, xen-devel@lists.xenproject.org
Cc: andrew.cooper3@citrix.com, anthony.perard@vates.tech,
jbeulich@suse.com, julien@xen.org, michal.orzel@amd.com,
roger@xenproject.org, sstabellini@kernel.org,
xakep.amatop@gmail.com, dmukhin@xen.org
Subject: Re: [PATCH v8 24/26] ci: add initial NS16550-compatible XTF test
Date: Fri, 20 Nov 2026 11:34:47 +0100 [thread overview]
Message-ID: <4adb2aa1-0125-4fa4-b7a6-9e1aa418ff6b@gmail.com> (raw)
In-Reply-To: <20261111194800.1070016-25-dmukhin@ford.com>
On 11/11/26 8:47 PM, dmukhin@ford.com wrote:
> From: Denis Mukhin <dmukhin@ford.com>
>
> Enable simple functional test for NS16550-compatible emulator by adding
> CONFIG_VUART_NS16X50=y
> CONFIG_SHADOW_PAGING=y
It would help to say what the test checks, and why SHADOW_PAGING is
needed. If it is something obvious and there is no sense to put this
infromation in commit message then could you please just for me explain
why SHADOW_PAGING should be enabled?
> for alpine-3.24-x86_64-gcc-debug Xen build.
>
> Signed-off-by: Denis Mukhin <dmukhin@ford.com>
> ---
> automation/gitlab-ci/build.yaml | 2 ++
> automation/gitlab-ci/test.yaml | 10 ++++++++++
> automation/scripts/include/xtf-runner | 2 ++
> 3 files changed, 14 insertions(+)
>
> diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/build.yaml
> index 3d37e0b572d0..f2072f6a9829 100644
> --- a/automation/gitlab-ci/build.yaml
> +++ b/automation/gitlab-ci/build.yaml
> @@ -290,6 +290,8 @@ alpine-3.24-x86_64-gcc-debug:
> CONFIG_UBSAN_FATAL=y
> CONFIG_MICROCODE_SCAN_DEFAULT=y
> CONFIG_XHCI=y
> + CONFIG_VUART_NS16X50=y
> + CONFIG_SHADOW_PAGING=y
>
> debian-13-x86_64-gcc-debug:
> extends: .gcc-x86_64-build-debug
> diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml
> index 96127995d7be..4f4ce8aab9e9 100644
> --- a/automation/gitlab-ci/test.yaml
> +++ b/automation/gitlab-ci/test.yaml
> @@ -785,6 +785,16 @@ qemu-xtf-argo-x86_64-gcc-debug:
> needs:
> - alpine-3.24-x86_64-gcc-debug
>
> +qemu-xtf-emul-ns16x50-x86_64-gcc-debug:
> + extends: .qemu-smoke-x86_64
> + variables:
> + TEST_TIMEOUT_OVERRIDE: 60
> + BOOT_MSG: "NS16550-compatible emulator tests"
> + script:
> + - ./automation/scripts/qemu-xtf.sh x86_64 hvm64 emul-ns16x50 2>&1 | tee ${LOGFILE}
As far as I can see, emul-ns16x50 isn't in upstream XTF. With the
default XTF_SRC_URI/XTF_SRC_BRANCH (xenbits master) this job would fail
to find the test; only 26/26, marked "do not merge", points CI at your
XTF branch. Has the XTF test been posted? IIRC, it is posted. I think
this patch has to wait until it's in XTF, and the cover letter should
say so.
> + needs:
> + - alpine-3.24-x86_64-gcc-debug
> +
> qemu-smoke-riscv64-gcc:
> extends: .qemu-riscv64
> script:
> diff --git a/automation/scripts/include/xtf-runner b/automation/scripts/include/xtf-runner
> index d1ef888465c3..41deb49d1c5d 100644
> --- a/automation/scripts/include/xtf-runner
> +++ b/automation/scripts/include/xtf-runner
> @@ -70,6 +70,8 @@ function xtf_build_cmdline()
> declare -a cmdline=()
> declare -A per_test_args=(
> [argo]="argo=1,mac-permissive=1"
> + # QEMU emulates COM1 (0x3f8) by default, use COM2 for test
> + [emul-ns16x50]="vuart=0:ns16550,com2 -- console=com2"
Could the comment say why COM1 isn't used? Xen's own console is on
QEMU's COM1 (console=com1 in XEN_CMDLINE), but since the test domain's
accesses to an emulated port are intercepted anyway, it's not obvious
to me that an emulated COM1 wouldn't work as well.
Also, no CI build enables CONFIG_VUART_NS16X50_DEBUG, which is how the
build failure in 13/26 went unnoticed. Adding it to one of the debug
builds would cover that code.
~ Oleksii
next prev parent reply other threads:[~2026-11-20 10:35 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-11 19:47 [PATCH v8 00/26] x86: introduce NS16550-compatible UART emulator dmukhin
2026-11-11 19:47 ` [PATCH v8 01/26] emul/vuart: introduce framework for UART emulators dmukhin
2026-11-12 15:35 ` Oleksii Kurochko
2026-11-11 19:47 ` [PATCH v8 02/26] xen/8250-uart: update definitions dmukhin
2026-11-12 14:49 ` Jan Beulich
2026-11-12 16:34 ` Oleksii Kurochko
2026-11-11 19:47 ` [PATCH v8 03/26] x86: fixup dependencies for asm/x86_emulate.h dmukhin
2026-11-12 20:25 ` Oleksii Kurochko
2026-11-13 7:20 ` Jan Beulich
2026-11-11 19:47 ` [PATCH v8 04/26] emul/ns16x50: implement emulator stub dmukhin
2026-11-13 11:48 ` Oleksii Kurochko
2026-11-11 19:47 ` [PATCH v8 05/26] emul/ns16x50: implement DLL/DLM registers dmukhin
2026-11-16 10:36 ` Oleksii Kurochko
2026-11-11 19:47 ` [PATCH v8 06/26] emul/ns16x50: implement SCR register dmukhin
2026-11-16 10:42 ` Oleksii Kurochko
2026-11-11 19:47 ` [PATCH v8 07/26] emul/ns16x50: implement IER/IIR registers dmukhin
2026-11-16 16:59 ` Oleksii Kurochko
2026-11-11 19:47 ` [PATCH v8 08/26] emul/ns16x50: implement LCR/LSR registers dmukhin
2026-11-17 16:33 ` Oleksii Kurochko
2026-11-11 19:47 ` [PATCH v8 09/26] emul/ns16x50: implement MCR/MSR registers dmukhin
2026-11-17 18:32 ` Oleksii Kurochko
2026-11-11 19:47 ` [PATCH v8 10/26] emul/ns16x50: implement RBR register dmukhin
2026-11-18 16:28 ` Oleksii Kurochko
2026-11-11 19:47 ` [PATCH v8 11/26] emul/ns16x50: implement THR register dmukhin
2026-11-19 10:22 ` Oleksii Kurochko
2026-11-11 19:47 ` [PATCH v8 12/26] emul/ns16x50: implement FCR register (write-only) dmukhin
2026-11-19 11:14 ` Oleksii Kurochko
2026-11-11 19:47 ` [PATCH v8 13/26] emul/ns16550: implement dump_state() hook dmukhin
2026-11-19 19:43 ` Oleksii Kurochko
2026-11-11 19:47 ` [PATCH v8 14/26] emul/vuart: add global UART emulator configuration knob dmukhin
2026-11-20 9:37 ` Oleksii Kurochko
2026-11-11 19:47 ` [PATCH v8 15/26] emul/ns16x50: enable emulator dmukhin
2026-11-20 9:45 ` Oleksii Kurochko
2026-11-11 19:47 ` [PATCH v8 16/26] emul/ns16x50: add Kconfig options dmukhin
2026-11-20 9:53 ` Oleksii Kurochko
2026-11-11 19:47 ` [PATCH v8 17/26] x86/domain: enable per-domain I/O port bitmaps dmukhin
2026-11-11 19:47 ` [PATCH v8 18/26] emul/ns16x50: resolve physical I/O port sharing dmukhin
2026-11-20 10:17 ` Oleksii Kurochko
2026-11-11 19:47 ` [PATCH v8 19/26] xen/domain: allocate d->irq_caps before arch-specific initialization dmukhin
2026-11-11 19:47 ` [PATCH v8 20/26] emul/ns16x50: resolve physical IRQ sharing dmukhin
2026-11-11 19:47 ` [PATCH v8 21/26] emul/ns16x50: implement IRQ emulation via vIOAPIC dmukhin
2026-11-11 19:47 ` [PATCH v8 22/26] MAINTAINERS: add myself as vUART framework maintainer dmukhin
2026-11-20 10:23 ` Oleksii Kurochko
2026-11-11 19:47 ` [PATCH v8 23/26] docs/fusa: add NS16x50 UART requirements for x86 dmukhin
2026-11-19 17:10 ` Halder, Ayan Kumar
2026-11-19 22:22 ` Stefano Stabellini
2026-11-20 11:17 ` Halder, Ayan Kumar
2026-11-20 10:26 ` Oleksii Kurochko
2026-11-20 11:16 ` Halder, Ayan Kumar
2026-11-11 19:47 ` [PATCH v8 24/26] ci: add initial NS16550-compatible XTF test dmukhin
2026-11-20 10:34 ` Oleksii Kurochko [this message]
2026-11-11 19:47 ` [PATCH v8 25/26] ci: add smoke NS16550-compatible PVH Linux test dmukhin
2026-11-11 19:48 ` [PATCH v8 26/26] ci: do not merge: test dmukhin
2026-11-12 14:53 ` [PATCH v8 00/26] x86: introduce NS16550-compatible UART emulator Oleksii Kurochko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4adb2aa1-0125-4fa4-b7a6-9e1aa418ff6b@gmail.com \
--to=oleksii.kurochko@gmail.com \
--cc=andrew.cooper3@citrix.com \
--cc=anthony.perard@vates.tech \
--cc=dmukhin@ford.com \
--cc=dmukhin@xen.org \
--cc=jbeulich@suse.com \
--cc=julien@xen.org \
--cc=michal.orzel@amd.com \
--cc=roger@xenproject.org \
--cc=sstabellini@kernel.org \
--cc=xakep.amatop@gmail.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.