All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oleksii Kurochko <oleksii.kurochko@gmail.com>
To: dmukhin@ford.com, xen-devel@lists.xenproject.org
Cc: andrew.cooper3@citrix.com, anthony.perard@vates.tech,
	jbeulich@suse.com, julien@xen.org, michal.orzel@amd.com,
	roger@xenproject.org, sstabellini@kernel.org,
	xakep.amatop@gmail.com, dmukhin@xen.org
Subject: Re: [PATCH v8 18/26] emul/ns16x50: resolve physical I/O port sharing
Date: Fri, 20 Nov 2026 11:17:38 +0100	[thread overview]
Message-ID: <ca34f34b-a6fc-4a14-899c-cd9e30437c85@gmail.com> (raw)
In-Reply-To: <20261111194800.1070016-19-dmukhin@ford.com>



On 11/11/26 8:47 PM, dmukhin@ford.com wrote:
> From: Denis Mukhin <dmukhin@ford.com>
> 
> Ensure NS16550 emulator does not share I/O ports with the physical I/O
> ports, which is essential for emulation in PVH hwdom case (dom0).
> 
> Signed-off-by: Denis Mukhin <dmukhin@ford.com>
> ---
>   xen/common/emul/vuart/ns16x50.c | 20 ++++++++++++++++++++
>   1 file changed, 20 insertions(+)
> 
> diff --git a/xen/common/emul/vuart/ns16x50.c b/xen/common/emul/vuart/ns16x50.c
> index cda21c15cf78..97e12a99368a 100644
> --- a/xen/common/emul/vuart/ns16x50.c
> +++ b/xen/common/emul/vuart/ns16x50.c
> @@ -901,14 +901,27 @@ static int ns16x50_init(void *arg)
>       struct vuart_ns16x50 *vdev = arg;
>       const struct vuart_info *info;
>       struct domain *d;
> +    const char *as;
> +    int rc;
>   
>       ASSERT(vdev);
>   
>       d = vdev->owner;
>       info = vdev->info;
> +    as = (info->base_type & IORESOURCE_IO) ? "ioport": "iomem";
>   
>       if ( info->base_type & IORESOURCE_IO )
>       {
> +        /* Disallow sharing physical I/O port */
> +        rc = ioports_deny_access(d, info->base_addr,
> +                                 info->base_addr + info->size - 1);
> +        if ( rc )
> +        {
> +            ns16x50_err(info, "virtual %s range [%#"PRIx64"..%#"PRIx64"]: conflict w/ physical range\n",
> +                        as, info->base_addr, info->base_addr + info->size - 1);
> +            return rc;
> +        }
> +
>           register_portio_handler(d, info->base_addr, info->size, ns16x50_io_handle);
>       }
>       else if ( info->base_type & IORESOURCE_MEM )
> @@ -928,13 +941,20 @@ static int ns16x50_init(void *arg)
>   static void cf_check ns16x50_deinit(void *arg)
>   {
>       struct vuart_ns16x50 *vdev = arg;
> +    const struct vuart_info *info;
>       unsigned long flags;
>   
>       ASSERT(vdev);
>   
> +    info = vdev->info;
> +
>       ns16x50_lock(vdev, &flags);
>       ns16x50_fifo_tx_flush(vdev);
>       ns16x50_unlock(vdev, &flags);
> +
> +    if ( info->base_type & IORESOURCE_IO )
> +        ioports_permit_access(d, info->base_addr,
> +                              info->base_addr + info->size - 1);

Two things. d isn't declared in ns16x50_deinit() until 21/26, so this
patch, 19/26 and 20/26 don't build with CONFIG_VUART_NS16X50=y (see my
reply to the cover letter). And the permit is unconditional: for a
domain that never had access to the range (any domU), this grants it.
As deinit only runs when the domain is going away, I'd drop the permit;
otherwise it has to restore the state from before ns16x50_init() rather
than assume access was there.

Also, on the error paths of ns16x50_init() that follow (20/26, 21/26),
the range stays denied and the portio handler stays registered. That's
harmless only because the domain then fails to be created; worth a
comment at least.

Another one question I would like to rise is this is x86-specific (I/O 
ports, ioport_caps, the PVH hwdom I/O bitmap) in otherwise 
arch-independent code, and it isn't specific to an NS16550 either: any 
emulated device handed to a domain at a resource the domain could 
otherwise reach directly needs the same.

I'd do it in the framework, through a per-arch hook called by
vuart_init() before emulator->alloc() (together with the IRQ part from
20/26), rather than in ns16x50_init(). That's also where an MMIO-based
variant would use iomem_deny_access() instead.

~ Oleksii


  reply	other threads:[~2026-11-20 10:18 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-11 19:47 [PATCH v8 00/26] x86: introduce NS16550-compatible UART emulator dmukhin
2026-11-11 19:47 ` [PATCH v8 01/26] emul/vuart: introduce framework for UART emulators dmukhin
2026-11-12 15:35   ` Oleksii Kurochko
2026-11-11 19:47 ` [PATCH v8 02/26] xen/8250-uart: update definitions dmukhin
2026-11-12 14:49   ` Jan Beulich
2026-11-12 16:34   ` Oleksii Kurochko
2026-11-11 19:47 ` [PATCH v8 03/26] x86: fixup dependencies for asm/x86_emulate.h dmukhin
2026-11-12 20:25   ` Oleksii Kurochko
2026-11-13  7:20     ` Jan Beulich
2026-11-11 19:47 ` [PATCH v8 04/26] emul/ns16x50: implement emulator stub dmukhin
2026-11-13 11:48   ` Oleksii Kurochko
2026-11-11 19:47 ` [PATCH v8 05/26] emul/ns16x50: implement DLL/DLM registers dmukhin
2026-11-16 10:36   ` Oleksii Kurochko
2026-11-11 19:47 ` [PATCH v8 06/26] emul/ns16x50: implement SCR register dmukhin
2026-11-16 10:42   ` Oleksii Kurochko
2026-11-11 19:47 ` [PATCH v8 07/26] emul/ns16x50: implement IER/IIR registers dmukhin
2026-11-16 16:59   ` Oleksii Kurochko
2026-11-11 19:47 ` [PATCH v8 08/26] emul/ns16x50: implement LCR/LSR registers dmukhin
2026-11-17 16:33   ` Oleksii Kurochko
2026-11-11 19:47 ` [PATCH v8 09/26] emul/ns16x50: implement MCR/MSR registers dmukhin
2026-11-17 18:32   ` Oleksii Kurochko
2026-11-11 19:47 ` [PATCH v8 10/26] emul/ns16x50: implement RBR register dmukhin
2026-11-18 16:28   ` Oleksii Kurochko
2026-11-11 19:47 ` [PATCH v8 11/26] emul/ns16x50: implement THR register dmukhin
2026-11-19 10:22   ` Oleksii Kurochko
2026-11-11 19:47 ` [PATCH v8 12/26] emul/ns16x50: implement FCR register (write-only) dmukhin
2026-11-19 11:14   ` Oleksii Kurochko
2026-11-11 19:47 ` [PATCH v8 13/26] emul/ns16550: implement dump_state() hook dmukhin
2026-11-19 19:43   ` Oleksii Kurochko
2026-11-11 19:47 ` [PATCH v8 14/26] emul/vuart: add global UART emulator configuration knob dmukhin
2026-11-20  9:37   ` Oleksii Kurochko
2026-11-11 19:47 ` [PATCH v8 15/26] emul/ns16x50: enable emulator dmukhin
2026-11-20  9:45   ` Oleksii Kurochko
2026-11-11 19:47 ` [PATCH v8 16/26] emul/ns16x50: add Kconfig options dmukhin
2026-11-20  9:53   ` Oleksii Kurochko
2026-11-11 19:47 ` [PATCH v8 17/26] x86/domain: enable per-domain I/O port bitmaps dmukhin
2026-11-11 19:47 ` [PATCH v8 18/26] emul/ns16x50: resolve physical I/O port sharing dmukhin
2026-11-20 10:17   ` Oleksii Kurochko [this message]
2026-11-11 19:47 ` [PATCH v8 19/26] xen/domain: allocate d->irq_caps before arch-specific initialization dmukhin
2026-11-11 19:47 ` [PATCH v8 20/26] emul/ns16x50: resolve physical IRQ sharing dmukhin
2026-11-11 19:47 ` [PATCH v8 21/26] emul/ns16x50: implement IRQ emulation via vIOAPIC dmukhin
2026-11-11 19:47 ` [PATCH v8 22/26] MAINTAINERS: add myself as vUART framework maintainer dmukhin
2026-11-20 10:23   ` Oleksii Kurochko
2026-11-11 19:47 ` [PATCH v8 23/26] docs/fusa: add NS16x50 UART requirements for x86 dmukhin
2026-11-19 17:10   ` Halder, Ayan Kumar
2026-11-19 22:22     ` Stefano Stabellini
2026-11-20 11:17       ` Halder, Ayan Kumar
2026-11-20 10:26   ` Oleksii Kurochko
2026-11-20 11:16     ` Halder, Ayan Kumar
2026-11-11 19:47 ` [PATCH v8 24/26] ci: add initial NS16550-compatible XTF test dmukhin
2026-11-20 10:34   ` Oleksii Kurochko
2026-11-11 19:47 ` [PATCH v8 25/26] ci: add smoke NS16550-compatible PVH Linux test dmukhin
2026-11-11 19:48 ` [PATCH v8 26/26] ci: do not merge: test dmukhin
2026-11-12 14:53 ` [PATCH v8 00/26] x86: introduce NS16550-compatible UART emulator Oleksii Kurochko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ca34f34b-a6fc-4a14-899c-cd9e30437c85@gmail.com \
    --to=oleksii.kurochko@gmail.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=anthony.perard@vates.tech \
    --cc=dmukhin@ford.com \
    --cc=dmukhin@xen.org \
    --cc=jbeulich@suse.com \
    --cc=julien@xen.org \
    --cc=michal.orzel@amd.com \
    --cc=roger@xenproject.org \
    --cc=sstabellini@kernel.org \
    --cc=xakep.amatop@gmail.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.