All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kumar Gala <kumar.gala@freescale.com>
To: "Tom Rini" <trini@kernel.crashing.org>
Cc: Kumar Gala <galak@freescale.com>,
	linuxppc-embedded <linuxppc-embedded@ozlabs.org>
Subject: Re: [RFC] ppc32: Report chip version in common /proc/cpuinfo handling
Date: Mon, 21 Mar 2005 11:21:28 -0600	[thread overview]
Message-ID: <4ae19fb229974e099a8472158be9482f@freescale.com> (raw)
In-Reply-To: <20050321163904.GT8345@smtp.west.cox.net>


On Mar 21, 2005, at 10:39 AM, Tom Rini wrote:

> On Fri, Mar 18, 2005 at 06:26:52PM -0600, Kumar Gala wrote:
>
> >
> > You asked me to look at doing the following.=A0 I just want to make=20=

> sure
> > this is what we want to do (and call it).=A0 I'm a little concerned=20=

> that
> > 'chip' is not necessary the right name in light of TSI10x and =
MV64x60
> > being described by ppc_sys in the future.
>
> "chip" or "chip(set)" or anything else is fine with me (I'm horrible =
at
>  names).=A0 But I don't like:
>
> > +#if defined (CONFIG_85xx) || defined (CONFIG_83xx)
> > +=A0=A0=A0=A0 if (cur_ppc_sys_spec->ppc_sys_name)
> > +=A0=A0=A0=A0 =A0=A0=A0=A0=A0=A0=A0 seq_printf(m, "chip\t\t: %s\n",=20=

> cur_ppc_sys_spec->ppc_sys_name);
> > +#endif
>
> ifdef'ing this.=A0 If the field is set, we should print it.

The only reason this is ifdef'd is that cur_ppc_sys_spec does not=20
always exist on all platforms built.

- kumar=

  reply	other threads:[~2005-03-21 17:21 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-03-19  0:26 [RFC] ppc32: Report chip version in common /proc/cpuinfo handling Kumar Gala
2005-03-21 16:33 ` Kumar Gala
2005-03-21 16:39 ` Tom Rini
2005-03-21 17:21   ` Kumar Gala [this message]
2005-03-21 18:05     ` Tom Rini
2005-03-21 18:32       ` Kumar Gala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ae19fb229974e099a8472158be9482f@freescale.com \
    --to=kumar.gala@freescale.com \
    --cc=galak@freescale.com \
    --cc=linuxppc-embedded@ozlabs.org \
    --cc=trini@kernel.crashing.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.