From: Kumar Gala <kumar.gala@freescale.com>
To: "Tom Rini" <trini@kernel.crashing.org>
Cc: Kumar Gala <galak@freescale.com>,
linuxppc-embedded <linuxppc-embedded@ozlabs.org>
Subject: Re: [RFC] ppc32: Report chip version in common /proc/cpuinfo handling
Date: Mon, 21 Mar 2005 12:32:06 -0600 [thread overview]
Message-ID: <d4a949778fc5fa91525b2d936bae2c50@freescale.com> (raw)
In-Reply-To: <20050321180548.GU8345@smtp.west.cox.net>
On Mar 21, 2005, at 12:05 PM, Tom Rini wrote:
> On Mon, Mar 21, 2005 at 11:21:28AM -0600, Kumar Gala wrote:
> >
> > On Mar 21, 2005, at 10:39 AM, Tom Rini wrote:
> >
> > >On Fri, Mar 18, 2005 at 06:26:52PM -0600, Kumar Gala wrote:
> > >
> > >>
> > >> You asked me to look at doing the following.? I just want to =
make
> > >sure
> > >> this is what we want to do (and call it).? I'm a little =
concerned
> > >that
> > >> 'chip' is not necessary the right name in light of TSI10x and=20
> MV64x60
> > >> being described by ppc_sys in the future.
> > >
> > >"chip" or "chip(set)" or anything else is fine with me (I'm=20
> horrible at
> > > names).? But I don't like:
> > >
> > >> +#if defined (CONFIG_85xx) || defined (CONFIG_83xx)
> > >> +???? if (cur_ppc_sys_spec->ppc_sys_name)
> > >> +???? ??????? seq_printf(m, "chip\t\t: %s\n",
> > >cur_ppc_sys_spec->ppc_sys_name);
> > >> +#endif
> > >
> > >ifdef'ing this.? If the field is set, we should print it.
> >
> > The only reason this is ifdef'd is that cur_ppc_sys_spec does not
> > always exist on all platforms built.
>
> Oh boy, I sense an <asm-ppc/serial.h> in the making.=A0 Please tell me
> it's at least not possible that someone could stick an 85xx and an
> MV64x60 together.=A0 So we want the enum there to do sanity checking,
> right?
It is not possible that this could happen, in the sense that you are=20
using the MV64x60 as a chipset, not a PCI device or something bizarre.
- kumar=
prev parent reply other threads:[~2005-03-21 18:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-19 0:26 [RFC] ppc32: Report chip version in common /proc/cpuinfo handling Kumar Gala
2005-03-21 16:33 ` Kumar Gala
2005-03-21 16:39 ` Tom Rini
2005-03-21 17:21 ` Kumar Gala
2005-03-21 18:05 ` Tom Rini
2005-03-21 18:32 ` Kumar Gala [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d4a949778fc5fa91525b2d936bae2c50@freescale.com \
--to=kumar.gala@freescale.com \
--cc=galak@freescale.com \
--cc=linuxppc-embedded@ozlabs.org \
--cc=trini@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.