* [Intel-wired-lan] [PATCH net-next] intel: Remove redundant ternary operators
@ 2025-08-27 12:12 ` Liao Yuanhong
0 siblings, 0 replies; 4+ messages in thread
From: Liao Yuanhong @ 2025-08-27 12:12 UTC (permalink / raw)
To: Tony Nguyen, Przemek Kitszel, Andrew Lunn, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni,
moderated list:INTEL ETHERNET DRIVERS,
open list:NETWORKING DRIVERS, open list
Cc: Liao Yuanhong
For ternary operators in the form of "a ? true : false", if 'a' itself
returns a boolean result, the ternary operator can be omitted. Remove
redundant ternary operators to clean up the code.
Signed-off-by: Liao Yuanhong <liaoyuanhong@vivo.com>
---
drivers/net/ethernet/intel/igb/e1000_phy.c | 2 +-
drivers/net/ethernet/intel/igc/igc_phy.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/intel/igb/e1000_phy.c b/drivers/net/ethernet/intel/igb/e1000_phy.c
index cd65008c7ef5..c21cd6311f45 100644
--- a/drivers/net/ethernet/intel/igb/e1000_phy.c
+++ b/drivers/net/ethernet/intel/igb/e1000_phy.c
@@ -1652,7 +1652,7 @@ s32 igb_phy_has_link(struct e1000_hw *hw, u32 iterations,
udelay(usec_interval);
}
- *success = (i < iterations) ? true : false;
+ *success = i < iterations;
return ret_val;
}
diff --git a/drivers/net/ethernet/intel/igc/igc_phy.c b/drivers/net/ethernet/intel/igc/igc_phy.c
index 6c4d204aecfa..828884d76f04 100644
--- a/drivers/net/ethernet/intel/igc/igc_phy.c
+++ b/drivers/net/ethernet/intel/igc/igc_phy.c
@@ -94,7 +94,7 @@ s32 igc_phy_has_link(struct igc_hw *hw, u32 iterations,
udelay(usec_interval);
}
- *success = (i < iterations) ? true : false;
+ *success = i < iterations;
return ret_val;
}
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH net-next] intel: Remove redundant ternary operators
@ 2025-08-27 12:12 ` Liao Yuanhong
0 siblings, 0 replies; 4+ messages in thread
From: Liao Yuanhong @ 2025-08-27 12:12 UTC (permalink / raw)
To: Tony Nguyen, Przemek Kitszel, Andrew Lunn, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni,
moderated list:INTEL ETHERNET DRIVERS,
open list:NETWORKING DRIVERS, open list
Cc: Liao Yuanhong
For ternary operators in the form of "a ? true : false", if 'a' itself
returns a boolean result, the ternary operator can be omitted. Remove
redundant ternary operators to clean up the code.
Signed-off-by: Liao Yuanhong <liaoyuanhong@vivo.com>
---
drivers/net/ethernet/intel/igb/e1000_phy.c | 2 +-
drivers/net/ethernet/intel/igc/igc_phy.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/intel/igb/e1000_phy.c b/drivers/net/ethernet/intel/igb/e1000_phy.c
index cd65008c7ef5..c21cd6311f45 100644
--- a/drivers/net/ethernet/intel/igb/e1000_phy.c
+++ b/drivers/net/ethernet/intel/igb/e1000_phy.c
@@ -1652,7 +1652,7 @@ s32 igb_phy_has_link(struct e1000_hw *hw, u32 iterations,
udelay(usec_interval);
}
- *success = (i < iterations) ? true : false;
+ *success = i < iterations;
return ret_val;
}
diff --git a/drivers/net/ethernet/intel/igc/igc_phy.c b/drivers/net/ethernet/intel/igc/igc_phy.c
index 6c4d204aecfa..828884d76f04 100644
--- a/drivers/net/ethernet/intel/igc/igc_phy.c
+++ b/drivers/net/ethernet/intel/igc/igc_phy.c
@@ -94,7 +94,7 @@ s32 igc_phy_has_link(struct igc_hw *hw, u32 iterations,
udelay(usec_interval);
}
- *success = (i < iterations) ? true : false;
+ *success = i < iterations;
return ret_val;
}
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Intel-wired-lan] [PATCH net-next] intel: Remove redundant ternary operators
2025-08-27 12:12 ` Liao Yuanhong
@ 2025-08-27 13:42 ` Przemek Kitszel
-1 siblings, 0 replies; 4+ messages in thread
From: Przemek Kitszel @ 2025-08-27 13:42 UTC (permalink / raw)
To: Liao Yuanhong
Cc: Tony Nguyen, Andrew Lunn, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni,
moderated list:INTEL ETHERNET DRIVERS,
open list:NETWORKING DRIVERS, open list
On 8/27/25 14:12, Liao Yuanhong wrote:
> For ternary operators in the form of "a ? true : false", if 'a' itself
> returns a boolean result, the ternary operator can be omitted. Remove
> redundant ternary operators to clean up the code.
>
> Signed-off-by: Liao Yuanhong <liaoyuanhong@vivo.com>
Netdev discourages patches which perform simple clean-ups, which are not
in the context of other work
https://docs.kernel.org/process/maintainer-netdev.html#clean-up-patches
> ---
> drivers/net/ethernet/intel/igb/e1000_phy.c | 2 +-
> drivers/net/ethernet/intel/igc/igc_phy.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/igb/e1000_phy.c b/drivers/net/ethernet/intel/igb/e1000_phy.c
> index cd65008c7ef5..c21cd6311f45 100644
> --- a/drivers/net/ethernet/intel/igb/e1000_phy.c
> +++ b/drivers/net/ethernet/intel/igb/e1000_phy.c
> @@ -1652,7 +1652,7 @@ s32 igb_phy_has_link(struct e1000_hw *hw, u32 iterations,
> udelay(usec_interval);
> }
>
> - *success = (i < iterations) ? true : false;
> + *success = i < iterations;
>
> return ret_val;
> }
> diff --git a/drivers/net/ethernet/intel/igc/igc_phy.c b/drivers/net/ethernet/intel/igc/igc_phy.c
> index 6c4d204aecfa..828884d76f04 100644
> --- a/drivers/net/ethernet/intel/igc/igc_phy.c
> +++ b/drivers/net/ethernet/intel/igc/igc_phy.c
> @@ -94,7 +94,7 @@ s32 igc_phy_has_link(struct igc_hw *hw, u32 iterations,
> udelay(usec_interval);
> }
>
> - *success = (i < iterations) ? true : false;
> + *success = i < iterations;
>
> return ret_val;
> }
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] intel: Remove redundant ternary operators
@ 2025-08-27 13:42 ` Przemek Kitszel
0 siblings, 0 replies; 4+ messages in thread
From: Przemek Kitszel @ 2025-08-27 13:42 UTC (permalink / raw)
To: Liao Yuanhong
Cc: Tony Nguyen, Andrew Lunn, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni,
moderated list:INTEL ETHERNET DRIVERS,
open list:NETWORKING DRIVERS, open list
On 8/27/25 14:12, Liao Yuanhong wrote:
> For ternary operators in the form of "a ? true : false", if 'a' itself
> returns a boolean result, the ternary operator can be omitted. Remove
> redundant ternary operators to clean up the code.
>
> Signed-off-by: Liao Yuanhong <liaoyuanhong@vivo.com>
Netdev discourages patches which perform simple clean-ups, which are not
in the context of other work
https://docs.kernel.org/process/maintainer-netdev.html#clean-up-patches
> ---
> drivers/net/ethernet/intel/igb/e1000_phy.c | 2 +-
> drivers/net/ethernet/intel/igc/igc_phy.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/igb/e1000_phy.c b/drivers/net/ethernet/intel/igb/e1000_phy.c
> index cd65008c7ef5..c21cd6311f45 100644
> --- a/drivers/net/ethernet/intel/igb/e1000_phy.c
> +++ b/drivers/net/ethernet/intel/igb/e1000_phy.c
> @@ -1652,7 +1652,7 @@ s32 igb_phy_has_link(struct e1000_hw *hw, u32 iterations,
> udelay(usec_interval);
> }
>
> - *success = (i < iterations) ? true : false;
> + *success = i < iterations;
>
> return ret_val;
> }
> diff --git a/drivers/net/ethernet/intel/igc/igc_phy.c b/drivers/net/ethernet/intel/igc/igc_phy.c
> index 6c4d204aecfa..828884d76f04 100644
> --- a/drivers/net/ethernet/intel/igc/igc_phy.c
> +++ b/drivers/net/ethernet/intel/igc/igc_phy.c
> @@ -94,7 +94,7 @@ s32 igc_phy_has_link(struct igc_hw *hw, u32 iterations,
> udelay(usec_interval);
> }
>
> - *success = (i < iterations) ? true : false;
> + *success = i < iterations;
>
> return ret_val;
> }
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-08-27 15:15 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-27 12:12 [Intel-wired-lan] [PATCH net-next] intel: Remove redundant ternary operators Liao Yuanhong
2025-08-27 12:12 ` Liao Yuanhong
2025-08-27 13:42 ` [Intel-wired-lan] " Przemek Kitszel
2025-08-27 13:42 ` Przemek Kitszel
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.