[PATCH 1/2] filesetup: make longest_existing_path() static and const-correct

[PATCH 1/2] filesetup: make longest_existing_path() static and const-correct

[Tomas Winkler]

Mark longest_existing_path() as static since it is only used within
filesetup.c. Also, declare the 'path' parameter as const char *
because it is not modified within the function.

Signed-off-by: Tomas Winkler tomas.winkler@sandisk.com
---
 filesetup.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/filesetup.c b/filesetup.c
index a94d3b38..bcbd871e 100644
--- a/filesetup.c
+++ b/filesetup.c
@@ -1002,7 +1002,8 @@ uint64_t get_start_offset(struct thread_data *td, struct fio_file *f)
 /*
  * Find longest path component that exists and return its length
  */
-int longest_existing_path(char *path) {
+static int longest_existing_path(const char *path)
+{
 	char buf[PATH_MAX];
 	bool done;
 	char *buf_pos;
-- 
2.45.2

[PATCH 2/2] eta: convert skip_eta() to ANSI C declaration

[Tomas Winkler]

Update skip_eta() to use an ANSI C function declaration
by explicitly specifying the void parameter list.

Signed-off-by: Tomas Winkler <tomas.winkler@sandisk.com>
---
 eta.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/eta.c b/eta.c
index 7d07708f..16109510 100644
--- a/eta.c
+++ b/eta.c
@@ -381,7 +381,7 @@ bool eta_time_within_slack(unsigned int time)
  * These are the conditions under which we might be able to skip the eta
  * calculation.
  */
-static bool skip_eta()
+static bool skip_eta(void)
 {
 	if (!(output_format & FIO_OUTPUT_NORMAL) && f_out == stdout)
 		return true;
-- 
2.45.2

Re: [PATCH 1/2] filesetup: make longest_existing_path() static and const-correct

[Vincent Fu]

On 7/31/25 8:20 AM, Tomas Winkler wrote:
> Mark longest_existing_path() as static since it is only used within
> filesetup.c. Also, declare the 'path' parameter as const char *
> because it is not modified within the function.
> 
> Signed-off-by: Tomas Winkler tomas.winkler@sandisk.com
> ---
>   filesetup.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/filesetup.c b/filesetup.c
> index a94d3b38..bcbd871e 100644
> --- a/filesetup.c
> +++ b/filesetup.c
> @@ -1002,7 +1002,8 @@ uint64_t get_start_offset(struct thread_data *td, struct fio_file *f)
>   /*
>    * Find longest path component that exists and return its length
>    */
> -int longest_existing_path(char *path) {
> +static int longest_existing_path(const char *path)
> +{
>   	char buf[PATH_MAX];
>   	bool done;
>   	char *buf_pos;

Applied. Thanks. Next time when you post more than one patch please 
include a cover letter.

Vincent

Re: [PATCH 1/2] filesetup: make longest_existing_path() static and const-correct

[fiotestbot]

[-- Attachment #1: Type: text/plain, Size: 144 bytes --]


The result of fio's continuous integration tests was: success

For more details see https://github.com/fiotestbot/fio/actions/runs/16652224455