From: "Purkait, Soham" <soham.purkait@intel.com>
To: Karthik Poosa <karthik.poosa@intel.com>,
<intel-xe@lists.freedesktop.org>
Cc: <rodrigo.vivi@intel.com>, <anshuman.gupta@intel.com>,
<badal.nilawar@intel.com>, <raag.jadav@intel.com>,
<riana.tauro@intel.com>, <sk.anirban@intel.com>,
<mallesh.koujalagi@intel.com>
Subject: Re: [PATCH v2 6/9] drm/xe/hwmon: Enable fan curve control support
Date: Wed, 22 Jul 2026 23:46:41 +0530 [thread overview]
Message-ID: <4b1dd652-77d4-4f14-941d-3b53d04ffefe@intel.com> (raw)
In-Reply-To: <20260717041757.2759084-7-karthik.poosa@intel.com>
Hi Karthik,
On 17-07-2026 09:47, Karthik Poosa wrote:
> Expose curve-point temperature and pwm controls via
> pwmF_auto_point[P]_temp and pwmF_auto_point[P]_pwm, where
> F is the fan number and P is the fan curve point number.
> Each fan curve point has temperature and pwm sysfs.
>
> Update Xe hwmon ABI documentation for pwm auto point temperature
> attributes.
>
> v2:
> - Use xe helpers for dmesg logs.
> - Update kernel version in Xe hwmon documentation.
> - Correct debug level of some dmesg logs.
>
> Signed-off-by: Karthik Poosa <karthik.poosa@intel.com>
> Assisted-by: Codex:gpt-5-4
> ---
> .../ABI/testing/sysfs-driver-intel-xe-hwmon | 16 +
> drivers/gpu/drm/xe/xe_hwmon.c | 700 +++++++++++++++++-
> 2 files changed, 715 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/ABI/testing/sysfs-driver-intel-xe-hwmon b/Documentation/ABI/testing/sysfs-driver-intel-xe-hwmon
> index effc7d38ce1f..68cc6b99e8a5 100644
> --- a/Documentation/ABI/testing/sysfs-driver-intel-xe-hwmon
> +++ b/Documentation/ABI/testing/sysfs-driver-intel-xe-hwmon
> @@ -341,3 +341,19 @@ Description: RW. Fan control mode selector.
> user table control and value 2 to use firmware default behavior.
>
> Only supported for particular Intel Xe graphics platforms.
> +
> +What: /sys/bus/pci/drivers/xe/.../hwmon/hwmon<i>/pwm[1-3]_auto_point[1-10]_temp
> +Date: June 2026
> +KernelVersion: 7.2
> +Contact: intel-xe@lists.freedesktop.org
> +Description: RW. Temperature in millidegree Celsius for each fan curve point.
> +
> + Only supported for particular Intel Xe graphics platforms.
> +
> +What: /sys/bus/pci/drivers/xe/.../hwmon/hwmon<i>/pwm[1-3]_auto_point[1-10]_pwm
> +Date: June 2026
> +KernelVersion: 7.2
> +Contact: intel-xe@lists.freedesktop.org
> +Description: RW. PWM duty value (0..255) for each fan curve point.
> +
> + Only supported for particular Intel Xe graphics platforms.
> diff --git a/drivers/gpu/drm/xe/xe_hwmon.c b/drivers/gpu/drm/xe/xe_hwmon.c
> index fa9dbadd5fd6..a3ed139ad446 100644
> --- a/drivers/gpu/drm/xe/xe_hwmon.c
> +++ b/drivers/gpu/drm/xe/xe_hwmon.c
> @@ -173,6 +173,10 @@ struct xe_hwmon_fan_info {
> /** @speed: fan speed in percentage */
> u8 speed;
> } fcp[MAX_FAN_CONTROL_POINTS];
> + /** @last_point_temp_valid: last user temperature point was written */
> + bool last_point_temp_valid;
> + /** @last_point_speed_valid: last user PWM point was written */
> + bool last_point_speed_valid;
> } fan_table[FAN_TABLE_MAX];
> /** @max_rps: maximum fan RPS */
> u32 max_rps;
> @@ -779,8 +783,11 @@ static const struct attribute_group hwmon_attrgroup = {
> .is_visible = xe_hwmon_attributes_visible,
> };
>
> +static const struct attribute_group hwmon_curve_attrgroup;
> +
> static const struct attribute_group *hwmon_groups[] = {
> &hwmon_attrgroup,
> + &hwmon_curve_attrgroup,
> NULL
> };
>
> @@ -945,7 +952,7 @@ static int xe_hwmon_get_num_fans(const struct xe_hwmon *hwmon, u32 *num_fans)
> }
>
> static int xe_hwmon_get_fan_point_count(struct xe_hwmon *hwmon, u8 fan, u32 *point_count,
> - int table_type)
> + enum fan_table_type table_type)
> {
> int ret;
>
> @@ -960,6 +967,16 @@ static int xe_hwmon_get_fan_point_count(struct xe_hwmon *hwmon, u8 fan, u32 *poi
> return ret;
> }
>
> + xe_dbg(hwmon->xe, "fan %d %s point count read as %u\n", fan,
> + (table_type == USER_FAN_TABLE) ? "user" : "stock", *point_count);
Remove duplicate log.
> +
> + if (*point_count > MAX_FAN_CONTROL_POINTS) {
> + xe_err(hwmon->xe, "fan %d %s point count %u exceeds max %u\n", fan,
> + (table_type == USER_FAN_TABLE) ? "user" : "stock", *point_count,
> + MAX_FAN_CONTROL_POINTS);
> + return -EINVAL;
> + }
> +
> xe_dbg(hwmon->xe, "fan %d %s point count read as %u\n", fan,
> (table_type == USER_FAN_TABLE) ? "user" : "stock", *point_count);
>
> @@ -985,6 +1002,60 @@ static int xe_hwmon_write_user_fan_point(struct xe_hwmon *hwmon, u8 fan, u8 poin
> return ret;
> }
>
> +static int xe_hwmon_commit_user_fan_table(struct xe_hwmon *hwmon, u8 fan)
> +{
> + struct xe_hwmon_fan_info *fi = &hwmon->fi[fan];
> + struct xe_tile *root_tile = xe_device_get_root_tile(hwmon->xe);
> + u32 point_count = fi->fan_table[USER_FAN_TABLE].fan_control_point_count;
> + int point;
> + int ret;
> +
> + if (!point_count)
> + return -ENODATA;
> +
> + for (point = 0; point < point_count; point++) {
> + u8 temp = fi->fan_table[USER_FAN_TABLE].fcp[point].temp;
> + u8 speed = fi->fan_table[USER_FAN_TABLE].fcp[point].speed;
> +
> + /* Ensure fan control points are strictly increasing order */
> + if (point > 0) {
> + u8 prev_temp = fi->fan_table[USER_FAN_TABLE].fcp[point - 1].temp;
> + u8 prev_speed = fi->fan_table[USER_FAN_TABLE].fcp[point - 1].speed;
> +
> + if (temp < prev_temp || speed < prev_speed) {
> + drm_dbg(&hwmon->xe->drm,
> + "fan %d invalid user point previous value > current %d: %u/%u prev=%u/%u\n",
> + fan, point, temp, speed, prev_temp, prev_speed);
> + return -EINVAL;
> + }
> + }
> +
> + drm_dbg(&hwmon->xe->drm,
> + "committing fan %d user point %d temp %u, speed %u %%\n",
> + fan, point, temp, speed);
> + ret = xe_hwmon_write_user_fan_point(hwmon, fan, point, temp, speed);
> + if (ret)
> + return ret;
> + }
> +
> + drm_dbg(&hwmon->xe->drm,
> + "committing fan %d user table with %d points\n", fan, point_count);
> + ret = xe_pcode_write_timeout(root_tile, PCODE_MBOX(FAN_SPEED_CONTROL,
> + FSC_WRITE_NUM_FAN_CONTROL_POINTS,
> + fan),
> + point_count, XE_PCODE_FAN_CONTROL_TIMEOUT_MS);
> + if (ret) {
> + drm_dbg(&hwmon->xe->drm,
> + "failed to update fan %d user table count, ret=%d\n", fan, ret);
> + return ret;
> + }
> +
> + fi->pwm_enable_mode = XE_FAN_PWM_MANUAL_USER_TABLE;
> + fi->is_full_speed = false;
> +
> + return 0;
> +}
> +
> static int xe_hwmon_activate_user_fan_table(struct xe_hwmon *hwmon, u8 fan,
> bool is_full_speed, enum fan_table_type table_source)
> {
> @@ -1105,6 +1176,633 @@ static int xe_hwmon_set_user_fan_pwm(struct xe_hwmon *hwmon, u8 fan, u8 pwm)
> return 0;
> }
>
> +#define XE_CURVE_IDX(fan, point) (((fan) << 8) | (point))
> +#define XE_CURVE_FAN(idx) ((u8)(((idx) >> 8) & 0xff))
> +#define XE_CURVE_POINT(idx) ((u8)((idx) & 0xff))
> +
> +static int
> +xe_hwmon_decode_curve_index(u32 index, u8 *fan, u8 *point)
> +{
> + u8 local_fan = XE_CURVE_FAN(index);
> + u8 local_point = XE_CURVE_POINT(index);
> +
> + if (local_fan >= FAN_MAX || local_point >= MAX_FAN_CONTROL_POINTS)
> + return -EINVAL;
> +
> + *fan = local_fan;
> + *point = local_point;
> +
> + return 0;
> +}
> +
> +static inline enum fan_table_type xe_hwmon_get_active_fan_table(struct xe_hwmon *hwmon, u8 fan)
> +{
> + if (hwmon->fi[fan].pwm_enable_mode == XE_FAN_PWM_AUTO_STOCK_TABLE)
> + return STOCK_FAN_TABLE;
> + else
> + return USER_FAN_TABLE;
> +}
> +
> +static ssize_t
> +xe_hwmon_pwm_auto_point_temp_show(struct device *dev,
> + struct device_attribute *attr, char *buf)
> +{
> + struct sensor_device_attribute *sattr = to_sensor_dev_attr(attr);
> + struct xe_hwmon *hwmon = dev_get_drvdata(dev);
> + struct xe_hwmon_fan_info *fi;
> + u32 point_count;
> + u8 fan;
> + u8 point;
> + u8 temp;
> + int ret;
> + enum fan_table_type active_table;
> +
> + ret = xe_hwmon_decode_curve_index(sattr->index, &fan, &point);
> + if (ret)
> + return ret;
> +
> + fi = &hwmon->fi[fan];
> + active_table = xe_hwmon_get_active_fan_table(hwmon, fan);
> +
> + guard(xe_pm_runtime)(hwmon->xe);
> +
> + mutex_lock(&hwmon->hwmon_lock);
> +
> + fi = &hwmon->fi[fan];
> +
> + ret = xe_hwmon_get_fan_point_count(hwmon, fan, &point_count, active_table);
> + if (ret)
> + goto unlock;
> +
> + if (point >= point_count) {
> + ret = -EINVAL;
> + goto unlock;
> + }
> +
> + temp = fi->fan_table[active_table].fcp[point].temp;
> + ret = sysfs_emit(buf, "%u\n", temp * MILLIDEGREE_PER_DEGREE);
> +
> +unlock:
> + mutex_unlock(&hwmon->hwmon_lock);
> +
> + return ret;
> +}
> +
> +static int xe_hwmon_update_user_fan_point(struct xe_hwmon *hwmon, u8 fan, u32 point,
> + u32 point_count, u8 temp, u8 pwm)
> +{
> + struct xe_hwmon_fan_info *fi = &hwmon->fi[fan];
> + int ret;
> +
> + if (temp) {
But as per the xe_hwmon_get_u8_from_sysfs() "0" is a acceptable curve
point then, why is it being over loaded here ?
Thanks,
Soham
> + fi->fan_table[USER_FAN_TABLE].fcp[point].temp = temp;
> + if (point == (point_count - 1))
> + fi->fan_table[USER_FAN_TABLE].last_point_temp_valid = true;
> + } else {
> + fi->fan_table[USER_FAN_TABLE].fcp[point].speed = pwm;
> + if (point == (point_count - 1))
> + fi->fan_table[USER_FAN_TABLE].last_point_speed_valid = true;
> + }
> +
> + /* Cache intermediate points and commit once the last point arrives. */
> + if (point == (point_count - 1) &&
> + fi->fan_table[USER_FAN_TABLE].last_point_temp_valid &&
> + fi->fan_table[USER_FAN_TABLE].last_point_speed_valid) {
> + ret = xe_hwmon_commit_user_fan_table(hwmon, fan);
> + if (ret)
> + return ret;
> + fi->fan_table[USER_FAN_TABLE].last_point_temp_valid = false;
> + fi->fan_table[USER_FAN_TABLE].last_point_speed_valid = false;
> + }
> + return 0;
> +}
> +
> +static int xe_hwmon_get_u8_from_sysfs(long val, bool is_temp, u8 *out)
> +{
> + long hw_val;
> +
> + if (is_temp)
> + hw_val = DIV_ROUND_CLOSEST(val, MILLIDEGREE_PER_DEGREE);
> + else
> + hw_val = DIV_ROUND_CLOSEST(val * 100, U8_MAX);
> +
> + if (hw_val < 0 || hw_val > U8_MAX)
> + return -EINVAL;
> +
> + *out = hw_val;
> +
> + return 0;
> +}
> +
> +static ssize_t
> +xe_hwmon_pwm_auto_point_temp_store(struct device *dev,
> + struct device_attribute *attr,
> + const char *buf, size_t count)
> +{
> + struct sensor_device_attribute *sattr = to_sensor_dev_attr(attr);
> + struct xe_hwmon *hwmon = dev_get_drvdata(dev);
> + struct xe_hwmon_fan_info *fi;
> + u8 fan;
> + u8 point;
> + u32 point_count;
> + u8 temp;
> + long val;
> + int ret;
> +
> + ret = xe_hwmon_decode_curve_index(sattr->index, &fan, &point);
> + if (ret)
> + return ret;
> +
> + fi = &hwmon->fi[fan];
> +
> + if (fi->pwm_enable_mode != XE_FAN_PWM_MANUAL_USER_TABLE) {
> + drm_err(&hwmon->xe->drm,
> + "pwm%d_enable not in manual mode; cannot update temp point %d\n",
> + fan, point);
> + return -EINVAL;
> + }
> +
> + ret = kstrtol(buf, 10, &val);
> + if (ret)
> + return ret;
> +
> + ret = xe_hwmon_get_u8_from_sysfs(val, true, &temp);
> + if (ret)
> + return ret;
> +
> + guard(xe_pm_runtime)(hwmon->xe);
> +
> + mutex_lock(&hwmon->hwmon_lock);
> +
> + ret = xe_hwmon_get_fan_point_count(hwmon, fan, &point_count, USER_FAN_TABLE);
> + if (ret)
> + goto unlock;
> +
> + if (point >= point_count) {
> + ret = -EINVAL;
> + goto unlock;
> + }
> +
> + drm_dbg(&hwmon->xe->drm,
> + "updating fan %d point %d temp to %u, pwm %u\n", fan, point,
> + temp, fi->fan_table[USER_FAN_TABLE].fcp[point].speed);
> + ret = xe_hwmon_update_user_fan_point(hwmon, fan, point, point_count, temp, 0);
> +
> +unlock:
> + mutex_unlock(&hwmon->hwmon_lock);
> +
> + return ret ? ret : count;
> +}
> +
> +static ssize_t
> +xe_hwmon_pwm_auto_point_pwm_show(struct device *dev,
> + struct device_attribute *attr,
> + char *buf)
> +{
> + struct sensor_device_attribute *sattr = to_sensor_dev_attr(attr);
> + struct xe_hwmon *hwmon = dev_get_drvdata(dev);
> + struct xe_hwmon_fan_info *fi;
> + u8 fan;
> + u8 point;
> + u32 point_count;
> + int ret;
> + enum fan_table_type active_table;
> +
> + ret = xe_hwmon_decode_curve_index(sattr->index, &fan, &point);
> + if (ret)
> + return ret;
> +
> + fi = &hwmon->fi[fan];
> + active_table = xe_hwmon_get_active_fan_table(hwmon, fan);
> +
> + guard(xe_pm_runtime)(hwmon->xe);
> +
> + mutex_lock(&hwmon->hwmon_lock);
> +
> + ret = xe_hwmon_get_fan_point_count(hwmon, fan, &point_count, active_table);
> + if (ret)
> + goto unlock;
> +
> + if (point >= point_count) {
> + ret = -EINVAL;
> + goto unlock;
> + }
> +
> + ret = sysfs_emit(buf, "%u\n",
> + DIV_ROUND_CLOSEST(fi->fan_table[active_table].fcp[point].speed * U8_MAX,
> + 100));
> +
> +unlock:
> + mutex_unlock(&hwmon->hwmon_lock);
> +
> + return ret;
> +}
> +
> +static ssize_t
> +xe_hwmon_pwm_auto_point_pwm_store(struct device *dev,
> + struct device_attribute *attr,
> + const char *buf, size_t count)
> +{
> + struct sensor_device_attribute *sattr = to_sensor_dev_attr(attr);
> + struct xe_hwmon *hwmon = dev_get_drvdata(dev);
> + struct xe_hwmon_fan_info *fi;
> + u32 point_count;
> + long val;
> + u8 point;
> + u8 fan;
> + u8 pwm;
> + int ret;
> +
> + ret = xe_hwmon_decode_curve_index(sattr->index, &fan, &point);
> + if (ret)
> + return ret;
> +
> + fi = &hwmon->fi[fan];
> +
> + if (fi->pwm_enable_mode != XE_FAN_PWM_MANUAL_USER_TABLE) {
> + drm_err(&hwmon->xe->drm,
> + "pwm%d_enable is not in manual user mode, cannot update pwm point %d\n",
> + fan, point);
> + return -EINVAL;
> + }
> +
> + ret = kstrtol(buf, 10, &val);
> + if (ret)
> + return ret;
> +
> + ret = xe_hwmon_get_u8_from_sysfs(val, false, &pwm);
> + if (ret)
> + return ret;
> +
> + guard(xe_pm_runtime)(hwmon->xe);
> +
> + mutex_lock(&hwmon->hwmon_lock);
> +
> + ret = xe_hwmon_get_fan_point_count(hwmon, fan, &point_count, USER_FAN_TABLE);
> + if (ret)
> + goto unlock;
> +
> + if (point >= point_count) {
> + ret = -EINVAL;
> + goto unlock;
> + }
> +
> + pwm = max_t(u8, pwm, fi->min_pwm);
> +
> + drm_dbg(&hwmon->xe->drm, "updating fan %d point %d pwm to %u\n",
> + fan, point, pwm);
> + ret = xe_hwmon_update_user_fan_point(hwmon, fan, point, point_count, 0, pwm);
> +
> +unlock:
> + mutex_unlock(&hwmon->hwmon_lock);
> +
> + return ret ? ret : count;
> +}
> +
> +static SENSOR_DEVICE_ATTR(pwm1_auto_point1_temp, 0644,
> + xe_hwmon_pwm_auto_point_temp_show,
> + xe_hwmon_pwm_auto_point_temp_store,
> + XE_CURVE_IDX(0, 0));
> +static SENSOR_DEVICE_ATTR(pwm1_auto_point1_pwm, 0644,
> + xe_hwmon_pwm_auto_point_pwm_show,
> + xe_hwmon_pwm_auto_point_pwm_store,
> + XE_CURVE_IDX(0, 0));
> +static SENSOR_DEVICE_ATTR(pwm1_auto_point2_temp, 0644,
> + xe_hwmon_pwm_auto_point_temp_show,
> + xe_hwmon_pwm_auto_point_temp_store,
> + XE_CURVE_IDX(0, 1));
> +static SENSOR_DEVICE_ATTR(pwm1_auto_point2_pwm, 0644,
> + xe_hwmon_pwm_auto_point_pwm_show,
> + xe_hwmon_pwm_auto_point_pwm_store,
> + XE_CURVE_IDX(0, 1));
> +static SENSOR_DEVICE_ATTR(pwm1_auto_point3_temp, 0644,
> + xe_hwmon_pwm_auto_point_temp_show,
> + xe_hwmon_pwm_auto_point_temp_store,
> + XE_CURVE_IDX(0, 2));
> +static SENSOR_DEVICE_ATTR(pwm1_auto_point3_pwm, 0644,
> + xe_hwmon_pwm_auto_point_pwm_show,
> + xe_hwmon_pwm_auto_point_pwm_store,
> + XE_CURVE_IDX(0, 2));
> +static SENSOR_DEVICE_ATTR(pwm1_auto_point4_temp, 0644,
> + xe_hwmon_pwm_auto_point_temp_show,
> + xe_hwmon_pwm_auto_point_temp_store,
> + XE_CURVE_IDX(0, 3));
> +static SENSOR_DEVICE_ATTR(pwm1_auto_point4_pwm, 0644,
> + xe_hwmon_pwm_auto_point_pwm_show,
> + xe_hwmon_pwm_auto_point_pwm_store,
> + XE_CURVE_IDX(0, 3));
> +static SENSOR_DEVICE_ATTR(pwm1_auto_point5_temp, 0644,
> + xe_hwmon_pwm_auto_point_temp_show,
> + xe_hwmon_pwm_auto_point_temp_store,
> + XE_CURVE_IDX(0, 4));
> +static SENSOR_DEVICE_ATTR(pwm1_auto_point5_pwm, 0644,
> + xe_hwmon_pwm_auto_point_pwm_show,
> + xe_hwmon_pwm_auto_point_pwm_store,
> + XE_CURVE_IDX(0, 4));
> +static SENSOR_DEVICE_ATTR(pwm1_auto_point6_temp, 0644,
> + xe_hwmon_pwm_auto_point_temp_show,
> + xe_hwmon_pwm_auto_point_temp_store,
> + XE_CURVE_IDX(0, 5));
> +static SENSOR_DEVICE_ATTR(pwm1_auto_point6_pwm, 0644,
> + xe_hwmon_pwm_auto_point_pwm_show,
> + xe_hwmon_pwm_auto_point_pwm_store,
> + XE_CURVE_IDX(0, 5));
> +static SENSOR_DEVICE_ATTR(pwm1_auto_point7_temp, 0644,
> + xe_hwmon_pwm_auto_point_temp_show,
> + xe_hwmon_pwm_auto_point_temp_store,
> + XE_CURVE_IDX(0, 6));
> +static SENSOR_DEVICE_ATTR(pwm1_auto_point7_pwm, 0644,
> + xe_hwmon_pwm_auto_point_pwm_show,
> + xe_hwmon_pwm_auto_point_pwm_store,
> + XE_CURVE_IDX(0, 6));
> +static SENSOR_DEVICE_ATTR(pwm1_auto_point8_temp, 0644,
> + xe_hwmon_pwm_auto_point_temp_show,
> + xe_hwmon_pwm_auto_point_temp_store,
> + XE_CURVE_IDX(0, 7));
> +static SENSOR_DEVICE_ATTR(pwm1_auto_point8_pwm, 0644,
> + xe_hwmon_pwm_auto_point_pwm_show,
> + xe_hwmon_pwm_auto_point_pwm_store,
> + XE_CURVE_IDX(0, 7));
> +static SENSOR_DEVICE_ATTR(pwm1_auto_point9_temp, 0644,
> + xe_hwmon_pwm_auto_point_temp_show,
> + xe_hwmon_pwm_auto_point_temp_store,
> + XE_CURVE_IDX(0, 8));
> +static SENSOR_DEVICE_ATTR(pwm1_auto_point9_pwm, 0644,
> + xe_hwmon_pwm_auto_point_pwm_show,
> + xe_hwmon_pwm_auto_point_pwm_store,
> + XE_CURVE_IDX(0, 8));
> +static SENSOR_DEVICE_ATTR(pwm1_auto_point10_temp, 0644,
> + xe_hwmon_pwm_auto_point_temp_show,
> + xe_hwmon_pwm_auto_point_temp_store,
> + XE_CURVE_IDX(0, 9));
> +static SENSOR_DEVICE_ATTR(pwm1_auto_point10_pwm, 0644,
> + xe_hwmon_pwm_auto_point_pwm_show,
> + xe_hwmon_pwm_auto_point_pwm_store,
> + XE_CURVE_IDX(0, 9));
> +static SENSOR_DEVICE_ATTR(pwm2_auto_point1_temp, 0644,
> + xe_hwmon_pwm_auto_point_temp_show,
> + xe_hwmon_pwm_auto_point_temp_store,
> + XE_CURVE_IDX(1, 0));
> +static SENSOR_DEVICE_ATTR(pwm2_auto_point1_pwm, 0644,
> + xe_hwmon_pwm_auto_point_pwm_show,
> + xe_hwmon_pwm_auto_point_pwm_store,
> + XE_CURVE_IDX(1, 0));
> +static SENSOR_DEVICE_ATTR(pwm2_auto_point2_temp, 0644,
> + xe_hwmon_pwm_auto_point_temp_show,
> + xe_hwmon_pwm_auto_point_temp_store,
> + XE_CURVE_IDX(1, 1));
> +static SENSOR_DEVICE_ATTR(pwm2_auto_point2_pwm, 0644,
> + xe_hwmon_pwm_auto_point_pwm_show,
> + xe_hwmon_pwm_auto_point_pwm_store,
> + XE_CURVE_IDX(1, 1));
> +static SENSOR_DEVICE_ATTR(pwm2_auto_point3_temp, 0644,
> + xe_hwmon_pwm_auto_point_temp_show,
> + xe_hwmon_pwm_auto_point_temp_store,
> + XE_CURVE_IDX(1, 2));
> +static SENSOR_DEVICE_ATTR(pwm2_auto_point3_pwm, 0644,
> + xe_hwmon_pwm_auto_point_pwm_show,
> + xe_hwmon_pwm_auto_point_pwm_store,
> + XE_CURVE_IDX(1, 2));
> +static SENSOR_DEVICE_ATTR(pwm2_auto_point4_temp, 0644,
> + xe_hwmon_pwm_auto_point_temp_show,
> + xe_hwmon_pwm_auto_point_temp_store,
> + XE_CURVE_IDX(1, 3));
> +static SENSOR_DEVICE_ATTR(pwm2_auto_point4_pwm, 0644,
> + xe_hwmon_pwm_auto_point_pwm_show,
> + xe_hwmon_pwm_auto_point_pwm_store,
> + XE_CURVE_IDX(1, 3));
> +static SENSOR_DEVICE_ATTR(pwm2_auto_point5_temp, 0644,
> + xe_hwmon_pwm_auto_point_temp_show,
> + xe_hwmon_pwm_auto_point_temp_store,
> + XE_CURVE_IDX(1, 4));
> +static SENSOR_DEVICE_ATTR(pwm2_auto_point5_pwm, 0644,
> + xe_hwmon_pwm_auto_point_pwm_show,
> + xe_hwmon_pwm_auto_point_pwm_store,
> + XE_CURVE_IDX(1, 4));
> +static SENSOR_DEVICE_ATTR(pwm2_auto_point6_temp, 0644,
> + xe_hwmon_pwm_auto_point_temp_show,
> + xe_hwmon_pwm_auto_point_temp_store,
> + XE_CURVE_IDX(1, 5));
> +static SENSOR_DEVICE_ATTR(pwm2_auto_point6_pwm, 0644,
> + xe_hwmon_pwm_auto_point_pwm_show,
> + xe_hwmon_pwm_auto_point_pwm_store,
> + XE_CURVE_IDX(1, 5));
> +static SENSOR_DEVICE_ATTR(pwm2_auto_point7_temp, 0644,
> + xe_hwmon_pwm_auto_point_temp_show,
> + xe_hwmon_pwm_auto_point_temp_store,
> + XE_CURVE_IDX(1, 6));
> +static SENSOR_DEVICE_ATTR(pwm2_auto_point7_pwm, 0644,
> + xe_hwmon_pwm_auto_point_pwm_show,
> + xe_hwmon_pwm_auto_point_pwm_store,
> + XE_CURVE_IDX(1, 6));
> +static SENSOR_DEVICE_ATTR(pwm2_auto_point8_temp, 0644,
> + xe_hwmon_pwm_auto_point_temp_show,
> + xe_hwmon_pwm_auto_point_temp_store,
> + XE_CURVE_IDX(1, 7));
> +static SENSOR_DEVICE_ATTR(pwm2_auto_point8_pwm, 0644,
> + xe_hwmon_pwm_auto_point_pwm_show,
> + xe_hwmon_pwm_auto_point_pwm_store,
> + XE_CURVE_IDX(1, 7));
> +static SENSOR_DEVICE_ATTR(pwm2_auto_point9_temp, 0644,
> + xe_hwmon_pwm_auto_point_temp_show,
> + xe_hwmon_pwm_auto_point_temp_store,
> + XE_CURVE_IDX(1, 8));
> +static SENSOR_DEVICE_ATTR(pwm2_auto_point9_pwm, 0644,
> + xe_hwmon_pwm_auto_point_pwm_show,
> + xe_hwmon_pwm_auto_point_pwm_store,
> + XE_CURVE_IDX(1, 8));
> +static SENSOR_DEVICE_ATTR(pwm2_auto_point10_temp, 0644,
> + xe_hwmon_pwm_auto_point_temp_show,
> + xe_hwmon_pwm_auto_point_temp_store,
> + XE_CURVE_IDX(1, 9));
> +static SENSOR_DEVICE_ATTR(pwm2_auto_point10_pwm, 0644,
> + xe_hwmon_pwm_auto_point_pwm_show,
> + xe_hwmon_pwm_auto_point_pwm_store,
> + XE_CURVE_IDX(1, 9));
> +static SENSOR_DEVICE_ATTR(pwm3_auto_point1_temp, 0644,
> + xe_hwmon_pwm_auto_point_temp_show,
> + xe_hwmon_pwm_auto_point_temp_store,
> + XE_CURVE_IDX(2, 0));
> +static SENSOR_DEVICE_ATTR(pwm3_auto_point1_pwm, 0644,
> + xe_hwmon_pwm_auto_point_pwm_show,
> + xe_hwmon_pwm_auto_point_pwm_store,
> + XE_CURVE_IDX(2, 0));
> +static SENSOR_DEVICE_ATTR(pwm3_auto_point2_temp, 0644,
> + xe_hwmon_pwm_auto_point_temp_show,
> + xe_hwmon_pwm_auto_point_temp_store,
> + XE_CURVE_IDX(2, 1));
> +static SENSOR_DEVICE_ATTR(pwm3_auto_point2_pwm, 0644,
> + xe_hwmon_pwm_auto_point_pwm_show,
> + xe_hwmon_pwm_auto_point_pwm_store,
> + XE_CURVE_IDX(2, 1));
> +static SENSOR_DEVICE_ATTR(pwm3_auto_point3_temp, 0644,
> + xe_hwmon_pwm_auto_point_temp_show,
> + xe_hwmon_pwm_auto_point_temp_store,
> + XE_CURVE_IDX(2, 2));
> +static SENSOR_DEVICE_ATTR(pwm3_auto_point3_pwm, 0644,
> + xe_hwmon_pwm_auto_point_pwm_show,
> + xe_hwmon_pwm_auto_point_pwm_store,
> + XE_CURVE_IDX(2, 2));
> +static SENSOR_DEVICE_ATTR(pwm3_auto_point4_temp, 0644,
> + xe_hwmon_pwm_auto_point_temp_show,
> + xe_hwmon_pwm_auto_point_temp_store,
> + XE_CURVE_IDX(2, 3));
> +static SENSOR_DEVICE_ATTR(pwm3_auto_point4_pwm, 0644,
> + xe_hwmon_pwm_auto_point_pwm_show,
> + xe_hwmon_pwm_auto_point_pwm_store,
> + XE_CURVE_IDX(2, 3));
> +static SENSOR_DEVICE_ATTR(pwm3_auto_point5_temp, 0644,
> + xe_hwmon_pwm_auto_point_temp_show,
> + xe_hwmon_pwm_auto_point_temp_store,
> + XE_CURVE_IDX(2, 4));
> +static SENSOR_DEVICE_ATTR(pwm3_auto_point5_pwm, 0644,
> + xe_hwmon_pwm_auto_point_pwm_show,
> + xe_hwmon_pwm_auto_point_pwm_store,
> + XE_CURVE_IDX(2, 4));
> +static SENSOR_DEVICE_ATTR(pwm3_auto_point6_temp, 0644,
> + xe_hwmon_pwm_auto_point_temp_show,
> + xe_hwmon_pwm_auto_point_temp_store,
> + XE_CURVE_IDX(2, 5));
> +static SENSOR_DEVICE_ATTR(pwm3_auto_point6_pwm, 0644,
> + xe_hwmon_pwm_auto_point_pwm_show,
> + xe_hwmon_pwm_auto_point_pwm_store,
> + XE_CURVE_IDX(2, 5));
> +static SENSOR_DEVICE_ATTR(pwm3_auto_point7_temp, 0644,
> + xe_hwmon_pwm_auto_point_temp_show,
> + xe_hwmon_pwm_auto_point_temp_store,
> + XE_CURVE_IDX(2, 6));
> +static SENSOR_DEVICE_ATTR(pwm3_auto_point7_pwm, 0644,
> + xe_hwmon_pwm_auto_point_pwm_show,
> + xe_hwmon_pwm_auto_point_pwm_store,
> + XE_CURVE_IDX(2, 6));
> +static SENSOR_DEVICE_ATTR(pwm3_auto_point8_temp, 0644,
> + xe_hwmon_pwm_auto_point_temp_show,
> + xe_hwmon_pwm_auto_point_temp_store,
> + XE_CURVE_IDX(2, 7));
> +static SENSOR_DEVICE_ATTR(pwm3_auto_point8_pwm, 0644,
> + xe_hwmon_pwm_auto_point_pwm_show,
> + xe_hwmon_pwm_auto_point_pwm_store,
> + XE_CURVE_IDX(2, 7));
> +static SENSOR_DEVICE_ATTR(pwm3_auto_point9_temp, 0644,
> + xe_hwmon_pwm_auto_point_temp_show,
> + xe_hwmon_pwm_auto_point_temp_store,
> + XE_CURVE_IDX(2, 8));
> +static SENSOR_DEVICE_ATTR(pwm3_auto_point9_pwm, 0644,
> + xe_hwmon_pwm_auto_point_pwm_show,
> + xe_hwmon_pwm_auto_point_pwm_store,
> + XE_CURVE_IDX(2, 8));
> +static SENSOR_DEVICE_ATTR(pwm3_auto_point10_temp, 0644,
> + xe_hwmon_pwm_auto_point_temp_show,
> + xe_hwmon_pwm_auto_point_temp_store,
> + XE_CURVE_IDX(2, 9));
> +static SENSOR_DEVICE_ATTR(pwm3_auto_point10_pwm, 0644,
> + xe_hwmon_pwm_auto_point_pwm_show,
> + xe_hwmon_pwm_auto_point_pwm_store,
> + XE_CURVE_IDX(2, 9));
> +
> +static struct attribute *hwmon_curve_attributes[] = {
> + &sensor_dev_attr_pwm1_auto_point1_temp.dev_attr.attr,
> + &sensor_dev_attr_pwm1_auto_point2_temp.dev_attr.attr,
> + &sensor_dev_attr_pwm1_auto_point3_temp.dev_attr.attr,
> + &sensor_dev_attr_pwm1_auto_point4_temp.dev_attr.attr,
> + &sensor_dev_attr_pwm1_auto_point5_temp.dev_attr.attr,
> + &sensor_dev_attr_pwm1_auto_point6_temp.dev_attr.attr,
> + &sensor_dev_attr_pwm1_auto_point7_temp.dev_attr.attr,
> + &sensor_dev_attr_pwm1_auto_point8_temp.dev_attr.attr,
> + &sensor_dev_attr_pwm1_auto_point9_temp.dev_attr.attr,
> + &sensor_dev_attr_pwm1_auto_point10_temp.dev_attr.attr,
> + &sensor_dev_attr_pwm1_auto_point1_pwm.dev_attr.attr,
> + &sensor_dev_attr_pwm1_auto_point2_pwm.dev_attr.attr,
> + &sensor_dev_attr_pwm1_auto_point3_pwm.dev_attr.attr,
> + &sensor_dev_attr_pwm1_auto_point4_pwm.dev_attr.attr,
> + &sensor_dev_attr_pwm1_auto_point5_pwm.dev_attr.attr,
> + &sensor_dev_attr_pwm1_auto_point6_pwm.dev_attr.attr,
> + &sensor_dev_attr_pwm1_auto_point7_pwm.dev_attr.attr,
> + &sensor_dev_attr_pwm1_auto_point8_pwm.dev_attr.attr,
> + &sensor_dev_attr_pwm1_auto_point9_pwm.dev_attr.attr,
> + &sensor_dev_attr_pwm1_auto_point10_pwm.dev_attr.attr,
> + &sensor_dev_attr_pwm2_auto_point1_temp.dev_attr.attr,
> + &sensor_dev_attr_pwm2_auto_point2_temp.dev_attr.attr,
> + &sensor_dev_attr_pwm2_auto_point3_temp.dev_attr.attr,
> + &sensor_dev_attr_pwm2_auto_point4_temp.dev_attr.attr,
> + &sensor_dev_attr_pwm2_auto_point5_temp.dev_attr.attr,
> + &sensor_dev_attr_pwm2_auto_point6_temp.dev_attr.attr,
> + &sensor_dev_attr_pwm2_auto_point7_temp.dev_attr.attr,
> + &sensor_dev_attr_pwm2_auto_point8_temp.dev_attr.attr,
> + &sensor_dev_attr_pwm2_auto_point9_temp.dev_attr.attr,
> + &sensor_dev_attr_pwm2_auto_point10_temp.dev_attr.attr,
> + &sensor_dev_attr_pwm2_auto_point1_pwm.dev_attr.attr,
> + &sensor_dev_attr_pwm2_auto_point2_pwm.dev_attr.attr,
> + &sensor_dev_attr_pwm2_auto_point3_pwm.dev_attr.attr,
> + &sensor_dev_attr_pwm2_auto_point4_pwm.dev_attr.attr,
> + &sensor_dev_attr_pwm2_auto_point5_pwm.dev_attr.attr,
> + &sensor_dev_attr_pwm2_auto_point6_pwm.dev_attr.attr,
> + &sensor_dev_attr_pwm2_auto_point7_pwm.dev_attr.attr,
> + &sensor_dev_attr_pwm2_auto_point8_pwm.dev_attr.attr,
> + &sensor_dev_attr_pwm2_auto_point9_pwm.dev_attr.attr,
> + &sensor_dev_attr_pwm2_auto_point10_pwm.dev_attr.attr,
> + &sensor_dev_attr_pwm3_auto_point1_temp.dev_attr.attr,
> + &sensor_dev_attr_pwm3_auto_point2_temp.dev_attr.attr,
> + &sensor_dev_attr_pwm3_auto_point3_temp.dev_attr.attr,
> + &sensor_dev_attr_pwm3_auto_point4_temp.dev_attr.attr,
> + &sensor_dev_attr_pwm3_auto_point5_temp.dev_attr.attr,
> + &sensor_dev_attr_pwm3_auto_point6_temp.dev_attr.attr,
> + &sensor_dev_attr_pwm3_auto_point7_temp.dev_attr.attr,
> + &sensor_dev_attr_pwm3_auto_point8_temp.dev_attr.attr,
> + &sensor_dev_attr_pwm3_auto_point9_temp.dev_attr.attr,
> + &sensor_dev_attr_pwm3_auto_point10_temp.dev_attr.attr,
> + &sensor_dev_attr_pwm3_auto_point1_pwm.dev_attr.attr,
> + &sensor_dev_attr_pwm3_auto_point2_pwm.dev_attr.attr,
> + &sensor_dev_attr_pwm3_auto_point3_pwm.dev_attr.attr,
> + &sensor_dev_attr_pwm3_auto_point4_pwm.dev_attr.attr,
> + &sensor_dev_attr_pwm3_auto_point5_pwm.dev_attr.attr,
> + &sensor_dev_attr_pwm3_auto_point6_pwm.dev_attr.attr,
> + &sensor_dev_attr_pwm3_auto_point7_pwm.dev_attr.attr,
> + &sensor_dev_attr_pwm3_auto_point8_pwm.dev_attr.attr,
> + &sensor_dev_attr_pwm3_auto_point9_pwm.dev_attr.attr,
> + &sensor_dev_attr_pwm3_auto_point10_pwm.dev_attr.attr,
> + NULL
> +};
> +
> +static umode_t xe_hwmon_curve_attributes_visible(struct kobject *kobj,
> + struct attribute *attr, int index)
> +{
> + struct device *dev = kobj_to_dev(kobj);
> + struct xe_hwmon *hwmon = dev_get_drvdata(dev);
> +
> + /* Temp/PWM pairs for each point. */
> + u32 attrs_per_fan = 2 * MAX_FAN_CONTROL_POINTS;
> + u32 fan = index / attrs_per_fan;
> + u32 local = index % attrs_per_fan;
> + u32 point_count;
> +
> + if (!hwmon->xe->info.has_fan_control)
> + return 0;
> +
> + if (fan >= hwmon->num_fans)
> + return 0;
> +
> + point_count = max(hwmon->fi[fan].fan_table[USER_FAN_TABLE].fan_control_point_count,
> + hwmon->fi[fan].fan_table[STOCK_FAN_TABLE].fan_control_point_count);
> +
> + if (!point_count)
> + return 0;
> +
> + if (local < MAX_FAN_CONTROL_POINTS)
> + return (local + 1) <= point_count ? attr->mode : 0;
> +
> + if (local < (2 * MAX_FAN_CONTROL_POINTS))
> + return (local - MAX_FAN_CONTROL_POINTS + 1) <= point_count ?
> + attr->mode : 0;
> +
> + return 0;
> +}
> +
> +static const struct attribute_group hwmon_curve_attrgroup = {
> + .attrs = hwmon_curve_attributes,
> + .is_visible = xe_hwmon_curve_attributes_visible,
> +};
> +
> static int xe_hwmon_read_fan_control_info(struct xe_hwmon *hwmon)
> {
> struct xe_tile *root_tile = xe_device_get_root_tile(hwmon->xe);
next prev parent reply other threads:[~2026-07-22 18:16 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-17 4:17 [PATCH v2 0/9] Add fan control support Karthik Poosa
2026-07-17 4:16 ` ✓ CI.KUnit: success for Add fan control support (rev2) Patchwork
2026-07-17 4:17 ` [PATCH v2 1/9] drm/xe/pcode: Introduce xe_pcode_read_timeout() API Karthik Poosa
2026-07-17 4:17 ` [PATCH v2 2/9] drm/xe/hwmon: initialize fan-control backend and table cache Karthik Poosa
2026-08-10 6:03 ` Nilawar, Badal
2026-08-11 13:11 ` Nilawar, Badal
2026-07-17 4:17 ` [PATCH v2 3/9] drm/xe/hwmon: expose fanN_max Karthik Poosa
2026-07-23 5:34 ` Purkait, Soham
2026-07-17 4:17 ` [PATCH v2 4/9] drm/xe/hwmon: expose pwm[1-3] Karthik Poosa
2026-07-24 7:02 ` Purkait, Soham
2026-08-11 13:58 ` Poosa, Karthik
2026-07-17 4:17 ` [PATCH v2 5/9] drm/xe/hwmon: expose pwm[1-3]_enable Karthik Poosa
2026-07-17 4:17 ` [PATCH v2 6/9] drm/xe/hwmon: Enable fan curve control support Karthik Poosa
2026-07-22 18:16 ` Purkait, Soham [this message]
2026-07-17 4:17 ` [PATCH v2 7/9] drm/xe/hwmon: Add kernel-doc for fan control Karthik Poosa
2026-07-17 4:17 ` [PATCH v2 8/9] drm/xe/hwmon: preserve fan user table across suspend resume Karthik Poosa
2026-08-10 5:53 ` Nilawar, Badal
2026-07-17 4:17 ` [PATCH v2 9/9] drm/xe/hwmon: Update fan info after late binding Karthik Poosa
2026-07-20 6:20 ` Purkait, Soham
2026-07-17 5:00 ` ✓ Xe.CI.BAT: success for Add fan control support (rev2) Patchwork
2026-07-17 8:18 ` ✗ Xe.CI.FULL: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b1dd652-77d4-4f14-941d-3b53d04ffefe@intel.com \
--to=soham.purkait@intel.com \
--cc=anshuman.gupta@intel.com \
--cc=badal.nilawar@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=karthik.poosa@intel.com \
--cc=mallesh.koujalagi@intel.com \
--cc=raag.jadav@intel.com \
--cc=riana.tauro@intel.com \
--cc=rodrigo.vivi@intel.com \
--cc=sk.anirban@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.