From: Keller, Jacob E <jacob.e.keller@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH] ethernet/intel: fix PTP_1588_CLOCK dependencies
Date: Tue, 27 Jul 2021 07:25:04 +0000 [thread overview]
Message-ID: <4b305f11-8cb5-03cd-07bd-12625cf35949@intel.com> (raw)
In-Reply-To: <CAK8P3a05D_P20Jjt5cf-0V2=dY_HvVRWJTBtpf_txc1e7b-POw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1736 bytes --]
On 7/26/2021 5:27 AM, Arnd Bergmann wrote:
> On Mon, Jul 26, 2021 at 12:29 PM kernel test robot <lkp@intel.com> wrote:
>
>>>> drivers/i2c/Kconfig:8:error: recursive dependency detected!
>> drivers/i2c/Kconfig:8: symbol I2C is selected by IGB
>> drivers/net/ethernet/intel/Kconfig:87: symbol IGB depends on PTP_1588_CLOCK
>> drivers/ptp/Kconfig:8: symbol PTP_1588_CLOCK is implied by MLX4_EN
>> drivers/net/ethernet/mellanox/mlx4/Kconfig:6: symbol MLX4_EN depends on NET_VENDOR_MELLANOX
>> drivers/net/ethernet/mellanox/Kconfig:6: symbol NET_VENDOR_MELLANOX depends on I2C
>> For a resolution refer to Documentation/kbuild/kconfig-language.rst
>> subsection "Kconfig recursive dependency limitations"
>
> Sorry about this, the patch I was testing with has this additional hunk
>
> @@ -88,7 +88,7 @@ config IGB
> tristate "Intel(R) 82575/82576 PCI-Express Gigabit Ethernet support"
> depends on PCI
> depends on PTP_1588_CLOCK || !PTP_1588_CLOCK
> - select I2C
> + depends on I2C
> select I2C_ALGOBIT
> help
> This driver supports Intel(R) 82575/82576 gigabit ethernet family of
>
> that I even describe in the changelog but forgot to include in the patch I sent.
>
> Arnd
>
With this hunk applied, everything looks good to me. Thanks for the fix!
It would be nice if this sort of dependency had a keyword or some other
slightly more intuitive way of handling it.
We could make run-time IS_REACHABLE checks so that the functions which
call into enable PTP support were disabled at run time in that case, I
suppose as an alternative fix to this....
Acked-by: Jacob Keller <jacob.e.keller@intel.com>
WARNING: multiple messages have this Message-ID (diff)
From: "Keller, Jacob E" <jacob.e.keller@intel.com>
To: Arnd Bergmann <arnd@kernel.org>, lkp <lkp@intel.com>
Cc: "Brandeburg, Jesse" <jesse.brandeburg@intel.com>,
"Nguyen, Anthony L" <anthony.l.nguyen@intel.com>,
"David S. Miller" <davem@davemloft.net>,
"Jakub Kicinski" <kuba@kernel.org>,
"kbuild-all@lists.01.org" <kbuild-all@lists.01.org>,
Networking <netdev@vger.kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
Kurt Kanzenbach <kurt@linutronix.de>,
"Saleem, Shiraz" <shiraz.saleem@intel.com>,
"Ertman, David M" <david.m.ertman@intel.com>
Subject: Re: [PATCH] ethernet/intel: fix PTP_1588_CLOCK dependencies
Date: Tue, 27 Jul 2021 07:25:04 +0000 [thread overview]
Message-ID: <4b305f11-8cb5-03cd-07bd-12625cf35949@intel.com> (raw)
In-Reply-To: <CAK8P3a05D_P20Jjt5cf-0V2=dY_HvVRWJTBtpf_txc1e7b-POw@mail.gmail.com>
On 7/26/2021 5:27 AM, Arnd Bergmann wrote:
> On Mon, Jul 26, 2021 at 12:29 PM kernel test robot <lkp@intel.com> wrote:
>
>>>> drivers/i2c/Kconfig:8:error: recursive dependency detected!
>> drivers/i2c/Kconfig:8: symbol I2C is selected by IGB
>> drivers/net/ethernet/intel/Kconfig:87: symbol IGB depends on PTP_1588_CLOCK
>> drivers/ptp/Kconfig:8: symbol PTP_1588_CLOCK is implied by MLX4_EN
>> drivers/net/ethernet/mellanox/mlx4/Kconfig:6: symbol MLX4_EN depends on NET_VENDOR_MELLANOX
>> drivers/net/ethernet/mellanox/Kconfig:6: symbol NET_VENDOR_MELLANOX depends on I2C
>> For a resolution refer to Documentation/kbuild/kconfig-language.rst
>> subsection "Kconfig recursive dependency limitations"
>
> Sorry about this, the patch I was testing with has this additional hunk
>
> @@ -88,7 +88,7 @@ config IGB
> tristate "Intel(R) 82575/82576 PCI-Express Gigabit Ethernet support"
> depends on PCI
> depends on PTP_1588_CLOCK || !PTP_1588_CLOCK
> - select I2C
> + depends on I2C
> select I2C_ALGOBIT
> help
> This driver supports Intel(R) 82575/82576 gigabit ethernet family of
>
> that I even describe in the changelog but forgot to include in the patch I sent.
>
> Arnd
>
With this hunk applied, everything looks good to me. Thanks for the fix!
It would be nice if this sort of dependency had a keyword or some other
slightly more intuitive way of handling it.
We could make run-time IS_REACHABLE checks so that the functions which
call into enable PTP support were disabled at run time in that case, I
suppose as an alternative fix to this....
Acked-by: Jacob Keller <jacob.e.keller@intel.com>
next prev parent reply other threads:[~2021-07-27 7:25 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-26 8:45 [Intel-wired-lan] [PATCH] ethernet/intel: fix PTP_1588_CLOCK dependencies Arnd Bergmann
2021-07-26 8:45 ` Arnd Bergmann
2021-07-26 10:27 ` kernel test robot
2021-07-26 10:27 ` kernel test robot
2021-07-26 12:27 ` Arnd Bergmann
2021-07-26 12:27 ` Arnd Bergmann
2021-07-27 7:25 ` Keller, Jacob E [this message]
2021-07-27 7:25 ` Keller, Jacob E
2021-07-26 13:44 ` kernel test robot
2021-07-26 13:44 ` kernel test robot
2021-07-26 21:21 ` [Intel-wired-lan] " Keller, Jacob E
2021-07-26 21:21 ` Keller, Jacob E
2021-08-02 13:07 ` [Intel-wired-lan] " G, GurucharanX
2021-08-02 13:07 ` G, GurucharanX
2021-08-02 14:37 ` Arnd Bergmann
2021-08-02 14:37 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b305f11-8cb5-03cd-07bd-12625cf35949@intel.com \
--to=jacob.e.keller@intel.com \
--cc=kbuild-all@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.