All of lore.kernel.org
 help / color / mirror / Atom feed
From: "John Rigby" <jcrigby@gmail.com>
To: "Jeff Garzik" <jeff@garzik.org>
Cc: Scott Wood <scottwood@freescale.com>,
	linuxppc-dev@ozlabs.org, Sam Ravnborg <sam@ravnborg.org>,
	netdev@vger.kernel.org
Subject: Re: [PATCH 1/2] fs_enet: fix checkpatch.pl problems
Date: Tue, 17 Jun 2008 22:12:35 -0600	[thread overview]
Message-ID: <4b73d43f0806172112s63ada35brb2e27f3262d7c07@mail.gmail.com> (raw)
In-Reply-To: <485886D9.5070800@garzik.org>

[-- Attachment #1: Type: text/plain, Size: 1220 bytes --]

Sorry, I thought I was doing the right thing to base the patch on Kumar's
patch that removes the CONFIG_PPC_CPM_NEW_BINDING stuff.  That is likely why
it did not apply.

On Tue, Jun 17, 2008 at 9:54 PM, Jeff Garzik <jeff@garzik.org> wrote:

> John Rigby wrote:
>
>> Fixed all errors and warnings that checkpatch.pl
>> reports if this was a new submission.
>> Also changed instances of fec_t to struct fec in
>> mac-fec.c and mii-fec.c.
>>
>> This is in preparation of adding MPC5121 support.
>>
>> Signed-off-by: John Rigby <jrigby@freescale.com>
>> ---
>>  drivers/net/fs_enet/fs_enet-main.c |   70
>> ++++++++++++++++++++---------------
>>  drivers/net/fs_enet/fs_enet.h      |   15 +++++---
>>  drivers/net/fs_enet/mac-fcc.c      |    7 ++--
>>  drivers/net/fs_enet/mac-fec.c      |   40 ++++++++++----------
>>  drivers/net/fs_enet/mac-scc.c      |   13 ++++---
>>  drivers/net/fs_enet/mii-bitbang.c  |    4 +-
>>  drivers/net/fs_enet/mii-fec.c      |   23 +++++++-----
>>  7 files changed, 95 insertions(+), 77 deletions(-)
>>
>
> patch does not apply
>
>
>
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev
>

[-- Attachment #2: Type: text/html, Size: 2074 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: "John Rigby" <jcrigby@gmail.com>
To: "Jeff Garzik" <jeff@garzik.org>
Cc: Scott Wood <scottwood@freescale.com>,
	linuxppc-dev@ozlabs.org, Sam Ravnborg <sam@ravnborg.org>,
	netdev@vger.kernel.org
Subject: Re: [PATCH 1/2] fs_enet: fix checkpatch.pl problems
Date: Tue, 17 Jun 2008 22:12:35 -0600	[thread overview]
Message-ID: <4b73d43f0806172112s63ada35brb2e27f3262d7c07@mail.gmail.com> (raw)
In-Reply-To: <485886D9.5070800@garzik.org>


[-- Attachment #1.1: Type: text/plain, Size: 1220 bytes --]

Sorry, I thought I was doing the right thing to base the patch on Kumar's
patch that removes the CONFIG_PPC_CPM_NEW_BINDING stuff.  That is likely why
it did not apply.

On Tue, Jun 17, 2008 at 9:54 PM, Jeff Garzik <jeff@garzik.org> wrote:

> John Rigby wrote:
>
>> Fixed all errors and warnings that checkpatch.pl
>> reports if this was a new submission.
>> Also changed instances of fec_t to struct fec in
>> mac-fec.c and mii-fec.c.
>>
>> This is in preparation of adding MPC5121 support.
>>
>> Signed-off-by: John Rigby <jrigby@freescale.com>
>> ---
>>  drivers/net/fs_enet/fs_enet-main.c |   70
>> ++++++++++++++++++++---------------
>>  drivers/net/fs_enet/fs_enet.h      |   15 +++++---
>>  drivers/net/fs_enet/mac-fcc.c      |    7 ++--
>>  drivers/net/fs_enet/mac-fec.c      |   40 ++++++++++----------
>>  drivers/net/fs_enet/mac-scc.c      |   13 ++++---
>>  drivers/net/fs_enet/mii-bitbang.c  |    4 +-
>>  drivers/net/fs_enet/mii-fec.c      |   23 +++++++-----
>>  7 files changed, 95 insertions(+), 77 deletions(-)
>>
>
> patch does not apply
>
>
>
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev
>

[-- Attachment #1.2: Type: text/html, Size: 2074 bytes --]

[-- Attachment #2: Type: text/plain, Size: 146 bytes --]

_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev

  reply	other threads:[~2008-06-18  4:12 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-17 23:03 [PATCH 0/2] Add MPC5121 FEC suppport John Rigby
2008-06-17 23:03 ` [PATCH 1/2] fs_enet: fix checkpatch.pl problems John Rigby
2008-06-17 23:03   ` [PATCH 2/2] fs_enet: add MPC5121 FEC support John Rigby
2008-06-18  3:54   ` [PATCH 1/2] fs_enet: fix checkpatch.pl problems Jeff Garzik
2008-06-18  4:12     ` John Rigby [this message]
2008-06-18  4:12       ` John Rigby
2008-06-18 15:07       ` Kumar Gala
2008-06-18 15:07         ` Kumar Gala
2008-06-18  5:20   ` Grant Likely
2008-06-18  5:20     ` Grant Likely
2008-06-18 13:29     ` John Rigby
2008-06-18 13:29       ` John Rigby
2008-06-18 15:50   ` Scott Wood
2008-06-18 15:50     ` Scott Wood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4b73d43f0806172112s63ada35brb2e27f3262d7c07@mail.gmail.com \
    --to=jcrigby@gmail.com \
    --cc=jeff@garzik.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=netdev@vger.kernel.org \
    --cc=sam@ravnborg.org \
    --cc=scottwood@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.