All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Zimmermann <tzimmermann@suse.de>
To: Takashi Iwai <tiwai@suse.de>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v3 03/12] drm/udl: Enable damage clipping
Date: Thu, 8 Sep 2022 15:09:39 +0200	[thread overview]
Message-ID: <4bdcfc5a-f5e3-75ef-574d-517bc4ec5d5f@suse.de> (raw)
In-Reply-To: <20220908095115.23396-4-tiwai@suse.de>


[-- Attachment #1.1: Type: text/plain, Size: 1339 bytes --]

Hi

Am 08.09.22 um 11:51 schrieb Takashi Iwai:
> From: Thomas Zimmermann <tzimmermann@suse.de>
> 
> Call drm_plane_enable_fb_damage_clips() and give userspace a chance
> of minimizing the updated display area.
> 
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> Signed-off-by: Takashi Iwai <tiwai@suse.de>

Daniel already gave an R-B here:

   https://patchwork.freedesktop.org/patch/495812/?series=106800&rev=1

I think the whole series should have been reviewed now. If nothing else 
comes in, we can merge it tomorrow or Monday.

Best regards
Thomas

> ---
>   drivers/gpu/drm/udl/udl_modeset.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/udl/udl_modeset.c b/drivers/gpu/drm/udl/udl_modeset.c
> index 34ce5b43c5db..b2377b706482 100644
> --- a/drivers/gpu/drm/udl/udl_modeset.c
> +++ b/drivers/gpu/drm/udl/udl_modeset.c
> @@ -480,6 +480,7 @@ int udl_modeset_init(struct drm_device *dev)
>   					   format_count, NULL, connector);
>   	if (ret)
>   		return ret;
> +	drm_plane_enable_fb_damage_clips(&udl->display_pipe.plane);
>   
>   	drm_mode_config_reset(dev);
>   

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Thomas Zimmermann <tzimmermann@suse.de>
To: Takashi Iwai <tiwai@suse.de>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 03/12] drm/udl: Enable damage clipping
Date: Thu, 8 Sep 2022 15:09:39 +0200	[thread overview]
Message-ID: <4bdcfc5a-f5e3-75ef-574d-517bc4ec5d5f@suse.de> (raw)
In-Reply-To: <20220908095115.23396-4-tiwai@suse.de>


[-- Attachment #1.1: Type: text/plain, Size: 1339 bytes --]

Hi

Am 08.09.22 um 11:51 schrieb Takashi Iwai:
> From: Thomas Zimmermann <tzimmermann@suse.de>
> 
> Call drm_plane_enable_fb_damage_clips() and give userspace a chance
> of minimizing the updated display area.
> 
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> Signed-off-by: Takashi Iwai <tiwai@suse.de>

Daniel already gave an R-B here:

   https://patchwork.freedesktop.org/patch/495812/?series=106800&rev=1

I think the whole series should have been reviewed now. If nothing else 
comes in, we can merge it tomorrow or Monday.

Best regards
Thomas

> ---
>   drivers/gpu/drm/udl/udl_modeset.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/udl/udl_modeset.c b/drivers/gpu/drm/udl/udl_modeset.c
> index 34ce5b43c5db..b2377b706482 100644
> --- a/drivers/gpu/drm/udl/udl_modeset.c
> +++ b/drivers/gpu/drm/udl/udl_modeset.c
> @@ -480,6 +480,7 @@ int udl_modeset_init(struct drm_device *dev)
>   					   format_count, NULL, connector);
>   	if (ret)
>   		return ret;
> +	drm_plane_enable_fb_damage_clips(&udl->display_pipe.plane);
>   
>   	drm_mode_config_reset(dev);
>   

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]

  reply	other threads:[~2022-09-08 13:09 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-08  9:51 [PATCH v3 00/12] drm/udl: More fixes Takashi Iwai
2022-09-08  9:51 ` Takashi Iwai
2022-09-08  9:51 ` [PATCH v3 01/12] drm/udl: Restore display mode on resume Takashi Iwai
2022-09-08  9:51   ` Takashi Iwai
2022-09-08  9:51 ` [PATCH v3 02/12] drm/udl: Add reset_resume Takashi Iwai
2022-09-08  9:51   ` Takashi Iwai
2022-09-08  9:51 ` [PATCH v3 03/12] drm/udl: Enable damage clipping Takashi Iwai
2022-09-08  9:51   ` Takashi Iwai
2022-09-08 13:09   ` Thomas Zimmermann [this message]
2022-09-08 13:09     ` Thomas Zimmermann
2022-09-08  9:51 ` [PATCH v3 04/12] Revert "drm/udl: Kill pending URBs at suspend and disconnect" Takashi Iwai
2022-09-08  9:51   ` Takashi Iwai
2022-09-08  9:51 ` [PATCH v3 05/12] drm/udl: Suppress error print for -EPROTO at URB completion Takashi Iwai
2022-09-08  9:51   ` Takashi Iwai
2022-09-08  9:51 ` [PATCH v3 06/12] drm/udl: Increase the default URB list size to 20 Takashi Iwai
2022-09-08  9:51   ` Takashi Iwai
2022-09-08  9:51 ` [PATCH v3 07/12] drm/udl: Drop unneeded alignment Takashi Iwai
2022-09-08  9:51   ` Takashi Iwai
2022-09-08  9:51 ` [PATCH v3 08/12] drm/udl: Pass rectangle directly to udl_handle_damage() Takashi Iwai
2022-09-08  9:51   ` Takashi Iwai
2022-09-08 12:47   ` Thomas Zimmermann
2022-09-08 12:47     ` Thomas Zimmermann
2022-09-08 12:54     ` Takashi Iwai
2022-09-08 12:54       ` Takashi Iwai
2022-09-08 13:07       ` Thomas Zimmermann
2022-09-08  9:51 ` [PATCH v3 09/12] drm/udl: Fix potential URB leaks Takashi Iwai
2022-09-08  9:51   ` Takashi Iwai
2022-09-08  9:51 ` [PATCH v3 10/12] drm/udl: Fix inconsistent urbs.count value during udl_free_urb_list() Takashi Iwai
2022-09-08  9:51   ` Takashi Iwai
2022-09-08  9:51 ` [PATCH v3 11/12] drm/udl: Don't re-initialize stuff at retrying the URB list allocation Takashi Iwai
2022-09-08  9:51   ` Takashi Iwai
2022-09-08  9:51 ` [PATCH v3 12/12] drm/udl: Sync pending URBs at the end of suspend Takashi Iwai
2022-09-08  9:51   ` Takashi Iwai
2022-09-12  7:06 ` [PATCH v3 00/12] drm/udl: More fixes Thomas Zimmermann
2022-09-12  7:06   ` Thomas Zimmermann
2022-09-12 11:51   ` Takashi Iwai
2022-09-12 11:51     ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4bdcfc5a-f5e3-75ef-574d-517bc4ec5d5f@suse.de \
    --to=tzimmermann@suse.de \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.