All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hao Xu <haoxu@linux.alibaba.com>
To: Jens Axboe <axboe@kernel.dk>, Pavel Begunkov <asml.silence@gmail.com>
Cc: io-uring <io-uring@vger.kernel.org>,
	Joseph Qi <joseph.qi@linux.alibaba.com>
Subject: Re: Question about poll_multi_file
Date: Sun, 6 Jun 2021 22:08:14 +0800	[thread overview]
Message-ID: <4c341c96-8d66-eae3-ba4a-e1655ee463a8@linux.alibaba.com> (raw)
In-Reply-To: <f2fa9534-e07c-fd18-759e-b3ca99b714a7@kernel.dk>

在 2021/6/4 上午2:01, Jens Axboe 写道:
> On 6/3/21 6:53 AM, Hao Xu wrote:
>> Hi Jens,
>> I've a question about poll_multi_file in io_do_iopoll().
>> It keeps spinning in f_op->iopoll() if poll_multi_file is
>> true (and we're under the requested amount). But in my
>> understanding, reqs may be in different hardware queues
>> for blk-mq device even in this situation.
>> Should we consider the hardware queue number as well? Some
>> thing like below:
> 
> That looks reasonable to me - do you have any performance
> numbers to go with it?

Not very easy for me to construct a good case. I'm trying to
mock the below situation:
manully control uring reqs to go to 2 hardware queues, like:
    hw_queue0     hw_queue1
    heavy_req     simple_req
    heavy_req     simple_req
      ...            ...

heavy_req is some request that needs more time to complete,
while simple_req takes less time. And make the io_do_iopoll()
alway first spin on hw_queue0.
any ideas?

Thanks,
Hao
> 


  reply	other threads:[~2021-06-06 14:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-03 12:53 Question about poll_multi_file Hao Xu
2021-06-03 18:01 ` Jens Axboe
2021-06-06 14:08   ` Hao Xu [this message]
2021-06-07 16:45     ` Pavel Begunkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4c341c96-8d66-eae3-ba4a-e1655ee463a8@linux.alibaba.com \
    --to=haoxu@linux.alibaba.com \
    --cc=asml.silence@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=io-uring@vger.kernel.org \
    --cc=joseph.qi@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.